| Message ID | 20191204171537.14163-1-miquel.raynal@bootlin.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: rockchip: Move xin32k fixed-clock out of PX30 DTSI | expand |
Hi Miquel, Am Mittwoch, 4. Dezember 2019, 18:15:37 CET schrieb Miquel Raynal: > This clock has nothing to do in the PX30 DTSI as it is supposed to be > an input of the SoC. Moving it to the EVB DTS (only board file using > this DTSI) makes more sense. Also, when this clock is not a fixed > clock and comes from eg. a PMIC the situation can be described cleanly > in the device tree (avoids having to delete the fixed-clock node > first). > > This clock is not mandatory to boot so it should not break existing > users. > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Sorry foo being the bearer of bad news again, but that issue got already fixed by: arm64: dts: rockchip: remove static xin32k from px30 https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v5.5-armsoc/dts64&id=00519137f7d4fc19ff27f3d3f4fc45b5b222ae82 arm64: dts: rockchip: fix the px30-evb power tree https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v5.5-armsoc/dts64&id=915b6a8b54a6d436885a458867e59fb20fc6356d On most/all Rockchip the xin32k clock is actually provided by the boards pmic - the rk809 in this case. Heiko
Hi Heiko, Heiko Stübner <heiko@sntech.de> wrote on Wed, 04 Dec 2019 18:31:46 +0100: > Hi Miquel, > > Am Mittwoch, 4. Dezember 2019, 18:15:37 CET schrieb Miquel Raynal: > > This clock has nothing to do in the PX30 DTSI as it is supposed to be > > an input of the SoC. Moving it to the EVB DTS (only board file using > > this DTSI) makes more sense. Also, when this clock is not a fixed > > clock and comes from eg. a PMIC the situation can be described cleanly > > in the device tree (avoids having to delete the fixed-clock node > > first). > > > > This clock is not mandatory to boot so it should not break existing > > users. > > > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > > Sorry foo being the bearer of bad news again, but that issue got already > fixed by: He he, no problem :) I was not actually looking at the right branch (v5.5-armsoc/dts64). > arm64: dts: rockchip: remove static xin32k from px30 > https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v5.5-armsoc/dts64&id=00519137f7d4fc19ff27f3d3f4fc45b5b222ae82 > > arm64: dts: rockchip: fix the px30-evb power tree > https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v5.5-armsoc/dts64&id=915b6a8b54a6d436885a458867e59fb20fc6356d > > > On most/all Rockchip the xin32k clock is actually provided by the boards > pmic - the rk809 in this case. Thanks for the confirmation! Miquèl
diff --git a/arch/arm64/boot/dts/rockchip/px30-evb.dts b/arch/arm64/boot/dts/rockchip/px30-evb.dts index 6eb7407a84aa..ee0b677209e4 100644 --- a/arch/arm64/boot/dts/rockchip/px30-evb.dts +++ b/arch/arm64/boot/dts/rockchip/px30-evb.dts @@ -89,6 +89,13 @@ regulator-min-microvolt = <5000000>; regulator-max-microvolt = <5000000>; }; + + xin32k: xin32k { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <32768>; + clock-output-names = "xin32k"; + }; }; &display_subsystem { diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi index 1fd12bd09e83..06328f1b05e8 100644 --- a/arch/arm64/boot/dts/rockchip/px30.dtsi +++ b/arch/arm64/boot/dts/rockchip/px30.dtsi @@ -195,13 +195,6 @@ clock-output-names = "xin24m"; }; - xin32k: xin32k { - compatible = "fixed-clock"; - #clock-cells = <0>; - clock-frequency = <32768>; - clock-output-names = "xin32k"; - }; - pmu: power-management@ff000000 { compatible = "rockchip,px30-pmu", "syscon", "simple-mfd"; reg = <0x0 0xff000000 0x0 0x1000>;
This clock has nothing to do in the PX30 DTSI as it is supposed to be an input of the SoC. Moving it to the EVB DTS (only board file using this DTSI) makes more sense. Also, when this clock is not a fixed clock and comes from eg. a PMIC the situation can be described cleanly in the device tree (avoids having to delete the fixed-clock node first). This clock is not mandatory to boot so it should not break existing users. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- arch/arm64/boot/dts/rockchip/px30-evb.dts | 7 +++++++ arch/arm64/boot/dts/rockchip/px30.dtsi | 7 ------- 2 files changed, 7 insertions(+), 7 deletions(-)