diff mbox series

HID: uhid: Fix returning EPOLLOUT from uhid_char_poll

Message ID 20191204024355.4566-1-marcel@holtmann.org (mailing list archive)
State Mainlined
Commit be54e7461ffdc5809b67d2aeefc1ddc9a91470c7
Delegated to: Jiri Kosina
Headers show
Series HID: uhid: Fix returning EPOLLOUT from uhid_char_poll | expand

Commit Message

Marcel Holtmann Dec. 4, 2019, 2:43 a.m. UTC
Always return EPOLLOUT from uhid_char_poll to allow polling /dev/uhid
for writable state.

Fixes: 1f9dec1e0164 ("HID: uhid: allow poll()'ing on uhid devices")
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Cc: stable@vger.kernel.org
---
 drivers/hid/uhid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jiri Kosina Dec. 9, 2019, 12:53 p.m. UTC | #1
On Wed, 4 Dec 2019, Marcel Holtmann wrote:

> Always return EPOLLOUT from uhid_char_poll to allow polling /dev/uhid
> for writable state.
> 
> Fixes: 1f9dec1e0164 ("HID: uhid: allow poll()'ing on uhid devices")
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> Cc: stable@vger.kernel.org

Applied, thanks.
diff mbox series

Patch

diff --git a/drivers/hid/uhid.c b/drivers/hid/uhid.c
index fa0cc0899827..935c3d0a3b63 100644
--- a/drivers/hid/uhid.c
+++ b/drivers/hid/uhid.c
@@ -772,7 +772,7 @@  static __poll_t uhid_char_poll(struct file *file, poll_table *wait)
 	if (uhid->head != uhid->tail)
 		return EPOLLIN | EPOLLRDNORM;
 
-	return 0;
+	return EPOLLOUT | EPOLLWRNORM;
 }
 
 static const struct file_operations uhid_fops = {