| Message ID | 20191207192249.8346-1-alistair@alistair23.me (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: allwinner: Enable Bluetooth and WiFi on sopine baseboard | expand |
On Sat, Dec 07, 2019 at 11:22:49AM -0800, Alistair Francis wrote: > The sopine board has an optional RTL8723BS WiFi + BT module that can be > connected to UART1. Add this to the device tree so that it will work for > users if connected. > > Signed-off-by: Alistair Francis <alistair@alistair23.me> > --- > .../dts/allwinner/sun50i-a64-sopine-baseboard.dts | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts > index 920103ec0046..0a91f9d8ed47 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts > @@ -214,6 +214,20 @@ &uart0 { > status = "okay"; > }; > > +&uart1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&uart1_pins>, <&uart1_rts_cts_pins>; > + status = "okay"; > + > + bluetooth { > + compatible = "realtek,rtl8723bs-bt"; > + reset-gpios = <&r_pio 0 4 GPIO_ACTIVE_LOW>; /* PL4 */ > + device-wake-gpios = <&r_pio 0 5 GPIO_ACTIVE_HIGH>; /* PL5 */ > + host-wake-gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; /* PL6 */ > + firmware-postfix = "pine64"; > + }; > +}; > + Output from checkpatch: total: 10 errors, 11 warnings, 0 checks, 20 lines checked More importantly, that binding isn't documented, and doesn't have a driver either. I guess you want to have a look at: https://www.spinics.net/lists/arm-kernel/msg771488.html Maxime
On Mon, Dec 9, 2019, at 11:37 AM, Maxime Ripard wrote: > On Sat, Dec 07, 2019 at 11:22:49AM -0800, Alistair Francis wrote: > > The sopine board has an optional RTL8723BS WiFi + BT module that can be > > connected to UART1. Add this to the device tree so that it will work for > > users if connected. > > > > Signed-off-by: Alistair Francis <alistair@alistair23.me> > > --- > > .../dts/allwinner/sun50i-a64-sopine-baseboard.dts | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts > > index 920103ec0046..0a91f9d8ed47 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts > > @@ -214,6 +214,20 @@ &uart0 { > > status = "okay"; > > }; > > > > +&uart1 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&uart1_pins>, <&uart1_rts_cts_pins>; > > + status = "okay"; > > + > > + bluetooth { > > + compatible = "realtek,rtl8723bs-bt"; > > + reset-gpios = <&r_pio 0 4 GPIO_ACTIVE_LOW>; /* PL4 */ > > + device-wake-gpios = <&r_pio 0 5 GPIO_ACTIVE_HIGH>; /* PL5 */ > > + host-wake-gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; /* PL6 */ > > + firmware-postfix = "pine64"; > > + }; > > +}; > > + > > Output from checkpatch: > total: 10 errors, 11 warnings, 0 checks, 20 lines checked Sorry, I should have checked that before I posted. > > More importantly, that binding isn't documented, and doesn't have a > driver either. Ah, I confused myself. I have some patches that will fix this, but from below it looks like someone else beat me to it. > > I guess you want to have a look at: > https://www.spinics.net/lists/arm-kernel/msg771488.html Thanks for pointing this out. I will just wait for this to be merged before trying again. Alistair > > Maxime >
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts index 920103ec0046..0a91f9d8ed47 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-sopine-baseboard.dts @@ -214,6 +214,20 @@ &uart0 { status = "okay"; }; +&uart1 { + pinctrl-names = "default"; + pinctrl-0 = <&uart1_pins>, <&uart1_rts_cts_pins>; + status = "okay"; + + bluetooth { + compatible = "realtek,rtl8723bs-bt"; + reset-gpios = <&r_pio 0 4 GPIO_ACTIVE_LOW>; /* PL4 */ + device-wake-gpios = <&r_pio 0 5 GPIO_ACTIVE_HIGH>; /* PL5 */ + host-wake-gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; /* PL6 */ + firmware-postfix = "pine64"; + }; +}; + /* On Pi-2 connector */ &uart2 { pinctrl-names = "default";
The sopine board has an optional RTL8723BS WiFi + BT module that can be connected to UART1. Add this to the device tree so that it will work for users if connected. Signed-off-by: Alistair Francis <alistair@alistair23.me> --- .../dts/allwinner/sun50i-a64-sopine-baseboard.dts | 14 ++++++++++++++ 1 file changed, 14 insertions(+)