| Message ID | 20191210143706.3928480-10-gregkh@linuxfoundation.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [01/10] tty: serial: samsung: allow driver to be built by anyone | expand |
On Tue, Dec 10, 2019 at 03:37:06PM +0100, Greg Kroah-Hartman wrote: > checkpatch is giving a bunch of: > WARNING: Missing a blank line after declarations > messages on this file, so fix up all instances of that issue. I would prefer to squash it with previous. These are not bugs, just minor coding style violations so there is no point to split it per patch. Too much churn. Best regards, Krzysztof
On Tue, Dec 10, 2019 at 04:13:45PM +0100, Krzysztof Kozlowski wrote: > On Tue, Dec 10, 2019 at 03:37:06PM +0100, Greg Kroah-Hartman wrote: > > checkpatch is giving a bunch of: > > WARNING: Missing a blank line after declarations > > messages on this file, so fix up all instances of that issue. > > I would prefer to squash it with previous. These are not bugs, just > minor coding style violations so there is no point to split it per > patch. Too much churn. For coding style fixes, in staging, I require "one type of change per patch" otherwise big "fix all the coding style issues" patches are impossible to review. Breaking it up into tiny pieces makes it easy/trivial to review, which makes it easier for maintainers, which is the key here. There is no "churn". thanks, greg k-h
diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index 4aebed241068..d5c75d288498 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -1543,6 +1543,7 @@ static void s3c24xx_serial_release_port(struct uart_port *port) static int s3c24xx_serial_request_port(struct uart_port *port) { const char *name = s3c24xx_serial_portname(port); + return request_mem_region(port->mapbase, MAP_SIZE, name) ? 0 : -EBUSY; } @@ -1963,6 +1964,7 @@ static inline struct s3c24xx_serial_drv_data *s3c24xx_get_driver_data( #ifdef CONFIG_OF if (pdev->dev.of_node) { const struct of_device_id *match; + match = of_match_node(s3c24xx_uart_dt_match, pdev->dev.of_node); return (struct s3c24xx_serial_drv_data *)match->data; } @@ -2109,6 +2111,7 @@ static int s3c24xx_serial_resume_noirq(struct device *dev) /* restore IRQ mask */ if (s3c24xx_serial_has_interrupt_mask(port)) { unsigned int uintm = 0xf; + if (tx_enabled(port)) uintm &= ~S3C64XX_UINTM_TXD_MSK; if (rx_enabled(port))
checkpatch is giving a bunch of: WARNING: Missing a blank line after declarations messages on this file, so fix up all instances of that issue. Cc: Kukjin Kim <kgene@kernel.org> Cc: Krzysztof Kozlowski <krzk@kernel.org> Cc: Hyunki Koo <kkoos00@naver.com> Cc: HYUN-KI KOO <hyunki00.koo@samsung.com> Cc: Shinbeom Choi <sbeom.choi@samsung.com> Cc: Jiri Slaby <jslaby@suse.com> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-samsung-soc@vger.kernel.org Cc: linux-serial@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/tty/serial/samsung_tty.c | 3 +++ 1 file changed, 3 insertions(+)