| Message ID | 1573068840-13098-2-git-send-email-agross@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1d16a9172c385e304fe4c2467d52e7f2ac301c6b |
| Headers | show |
| Series | [GIT,PULL] Qualcomm ARM64 DT updates for 5.5 | expand |
(Removing arm-soc) Hi Andy, On Thu, Nov 7, 2019 at 1:04 AM Andy Gross <agross@kernel.org> wrote: > > Arnd, Olof, and Kevin, > > I have one slight faux paux in this pull request. A drivers: soc change got > into my arm64 DTS branch and while it is innocuous, it wasn't easy to fix > without messing up a lot of people who depend on the SHAs not changing. So I'm > sorry for this inclusion. I'll scrub this better next time. > > Andy > ---------------------------------------------------------------- > Amit Kucheria (5): > arm64: dts: qcs404: thermal: Add interrupt support > arm64: dts: msm8998: thermal: Add interrupt support > arm64: dts: msm8996: thermal: Add interrupt support > arm64: dts: sdm845: thermal: Add interrupt support > arm64: dts: msm8916: thermal: Fixup HW ids for cpu sensors One of my patches to add interrupt support to msm8916 tsens is missing here. Specifically this one: https://patchwork.kernel.org/patch/11201853/ Will there be a second PR this cycle? Regards, Amit
On Thu, Nov 07, 2019 at 07:36:03PM +0530, Amit Kucheria wrote: > (Removing arm-soc) > > Hi Andy, > > On Thu, Nov 7, 2019 at 1:04 AM Andy Gross <agross@kernel.org> wrote: > > > > Arnd, Olof, and Kevin, > > > > I have one slight faux paux in this pull request. A drivers: soc change got > > into my arm64 DTS branch and while it is innocuous, it wasn't easy to fix > > without messing up a lot of people who depend on the SHAs not changing. So I'm > > sorry for this inclusion. I'll scrub this better next time. > > > > Andy > > > ---------------------------------------------------------------- > > Amit Kucheria (5): > > arm64: dts: qcs404: thermal: Add interrupt support > > arm64: dts: msm8998: thermal: Add interrupt support > > arm64: dts: msm8996: thermal: Add interrupt support > > arm64: dts: sdm845: thermal: Add interrupt support > > arm64: dts: msm8916: thermal: Fixup HW ids for cpu sensors > > One of my patches to add interrupt support to msm8916 tsens is missing > here. Specifically this one: > https://patchwork.kernel.org/patch/11201853/ > > Will there be a second PR this cycle? I can work up another and throw it on top. Andy
On Thu, Nov 07, 2019 at 09:18:54PM -0600, Andy Gross wrote: > On Thu, Nov 07, 2019 at 07:36:03PM +0530, Amit Kucheria wrote: > > (Removing arm-soc) > > > > Hi Andy, > > > > On Thu, Nov 7, 2019 at 1:04 AM Andy Gross <agross@kernel.org> wrote: > > > > > > Arnd, Olof, and Kevin, > > > > > > I have one slight faux paux in this pull request. A drivers: soc change got > > > into my arm64 DTS branch and while it is innocuous, it wasn't easy to fix > > > without messing up a lot of people who depend on the SHAs not changing. So I'm > > > sorry for this inclusion. I'll scrub this better next time. > > > > > > Andy > > > > > ---------------------------------------------------------------- > > > Amit Kucheria (5): > > > arm64: dts: qcs404: thermal: Add interrupt support > > > arm64: dts: msm8998: thermal: Add interrupt support > > > arm64: dts: msm8996: thermal: Add interrupt support > > > arm64: dts: sdm845: thermal: Add interrupt support > > > arm64: dts: msm8916: thermal: Fixup HW ids for cpu sensors > > > > One of my patches to add interrupt support to msm8916 tsens is missing > > here. Specifically this one: > > https://patchwork.kernel.org/patch/11201853/ > > > > Will there be a second PR this cycle? > > I can work up another and throw it on top. > FYI, the patch seems to be still missing in 5.5-rc1. tsens now fails to probe on MSM8916 with: qcom-tsens 4a9000.thermal-sensor: IRQ uplow not found Can you queue up the patch as fix for 5.5? Thanks, Stephan
On Tue, Dec 10, 2019 at 4:27 PM Stephan Gerhold <stephan@gerhold.net> wrote: > > On Thu, Nov 07, 2019 at 09:18:54PM -0600, Andy Gross wrote: > > On Thu, Nov 07, 2019 at 07:36:03PM +0530, Amit Kucheria wrote: > > > (Removing arm-soc) > > > > > > Hi Andy, > > > > > > On Thu, Nov 7, 2019 at 1:04 AM Andy Gross <agross@kernel.org> wrote: > > > > > > > > Arnd, Olof, and Kevin, > > > > > > > > I have one slight faux paux in this pull request. A drivers: soc change got > > > > into my arm64 DTS branch and while it is innocuous, it wasn't easy to fix > > > > without messing up a lot of people who depend on the SHAs not changing. So I'm > > > > sorry for this inclusion. I'll scrub this better next time. > > > > > > > > Andy > > > > > > > ---------------------------------------------------------------- > > > > Amit Kucheria (5): > > > > arm64: dts: qcs404: thermal: Add interrupt support > > > > arm64: dts: msm8998: thermal: Add interrupt support > > > > arm64: dts: msm8996: thermal: Add interrupt support > > > > arm64: dts: sdm845: thermal: Add interrupt support > > > > arm64: dts: msm8916: thermal: Fixup HW ids for cpu sensors > > > > > > One of my patches to add interrupt support to msm8916 tsens is missing > > > here. Specifically this one: > > > https://patchwork.kernel.org/patch/11201853/ > > > > > > Will there be a second PR this cycle? > > > > I can work up another and throw it on top. > > > > FYI, the patch seems to be still missing in 5.5-rc1. > tsens now fails to probe on MSM8916 with: > > qcom-tsens 4a9000.thermal-sensor: IRQ uplow not found > > Can you queue up the patch as fix for 5.5? Indeed. Andy/Bjorn, let me know if you need anything from me to get this into -rc2. Regards, Amit
On Tue 10 Dec 09:36 PST 2019, Amit Kucheria wrote: > On Tue, Dec 10, 2019 at 4:27 PM Stephan Gerhold <stephan@gerhold.net> wrote: > > > > On Thu, Nov 07, 2019 at 09:18:54PM -0600, Andy Gross wrote: > > > On Thu, Nov 07, 2019 at 07:36:03PM +0530, Amit Kucheria wrote: > > > > (Removing arm-soc) > > > > > > > > Hi Andy, > > > > > > > > On Thu, Nov 7, 2019 at 1:04 AM Andy Gross <agross@kernel.org> wrote: > > > > > > > > > > Arnd, Olof, and Kevin, > > > > > > > > > > I have one slight faux paux in this pull request. A drivers: soc change got > > > > > into my arm64 DTS branch and while it is innocuous, it wasn't easy to fix > > > > > without messing up a lot of people who depend on the SHAs not changing. So I'm > > > > > sorry for this inclusion. I'll scrub this better next time. > > > > > > > > > > Andy > > > > > > > > > ---------------------------------------------------------------- > > > > > Amit Kucheria (5): > > > > > arm64: dts: qcs404: thermal: Add interrupt support > > > > > arm64: dts: msm8998: thermal: Add interrupt support > > > > > arm64: dts: msm8996: thermal: Add interrupt support > > > > > arm64: dts: sdm845: thermal: Add interrupt support > > > > > arm64: dts: msm8916: thermal: Fixup HW ids for cpu sensors > > > > > > > > One of my patches to add interrupt support to msm8916 tsens is missing > > > > here. Specifically this one: > > > > https://patchwork.kernel.org/patch/11201853/ > > > > > > > > Will there be a second PR this cycle? > > > > > > I can work up another and throw it on top. > > > > > > > FYI, the patch seems to be still missing in 5.5-rc1. > > tsens now fails to probe on MSM8916 with: > > > > qcom-tsens 4a9000.thermal-sensor: IRQ uplow not found > > > > Can you queue up the patch as fix for 5.5? > > Indeed. Andy/Bjorn, let me know if you need anything from me to get > this into -rc2. > I'm pulling in some fixes for a rc-pull, so I could add it there. But why are we breaking backwards compatibility with existing dtbs to add a new (optional) feature? Shouldn't there be a rc-fix in the driver for this regression? Regards, Bjorn
On Tue, Dec 10, 2019 at 10:17 AM Bjorn Andersson <bjorn.andersson@linaro.org> wrote: > > On Tue 10 Dec 09:36 PST 2019, Amit Kucheria wrote: > > > On Tue, Dec 10, 2019 at 4:27 PM Stephan Gerhold <stephan@gerhold.net> wrote: > > > > > > On Thu, Nov 07, 2019 at 09:18:54PM -0600, Andy Gross wrote: > > > > On Thu, Nov 07, 2019 at 07:36:03PM +0530, Amit Kucheria wrote: > > > > > (Removing arm-soc) > > > > > > > > > > Hi Andy, > > > > > > > > > > On Thu, Nov 7, 2019 at 1:04 AM Andy Gross <agross@kernel.org> wrote: > > > > > > > > > > > > Arnd, Olof, and Kevin, > > > > > > > > > > > > I have one slight faux paux in this pull request. A drivers: soc change got > > > > > > into my arm64 DTS branch and while it is innocuous, it wasn't easy to fix > > > > > > without messing up a lot of people who depend on the SHAs not changing. So I'm > > > > > > sorry for this inclusion. I'll scrub this better next time. > > > > > > > > > > > > Andy > > > > > > > > > > > ---------------------------------------------------------------- > > > > > > Amit Kucheria (5): > > > > > > arm64: dts: qcs404: thermal: Add interrupt support > > > > > > arm64: dts: msm8998: thermal: Add interrupt support > > > > > > arm64: dts: msm8996: thermal: Add interrupt support > > > > > > arm64: dts: sdm845: thermal: Add interrupt support > > > > > > arm64: dts: msm8916: thermal: Fixup HW ids for cpu sensors > > > > > > > > > > One of my patches to add interrupt support to msm8916 tsens is missing > > > > > here. Specifically this one: > > > > > https://patchwork.kernel.org/patch/11201853/ > > > > > > > > > > Will there be a second PR this cycle? > > > > > > > > I can work up another and throw it on top. > > > > > > > > > > FYI, the patch seems to be still missing in 5.5-rc1. > > > tsens now fails to probe on MSM8916 with: > > > > > > qcom-tsens 4a9000.thermal-sensor: IRQ uplow not found > > > > > > Can you queue up the patch as fix for 5.5? > > > > Indeed. Andy/Bjorn, let me know if you need anything from me to get > > this into -rc2. > > > > I'm pulling in some fixes for a rc-pull, so I could add it there. > > But why are we breaking backwards compatibility with existing dtbs to > add a new (optional) feature? Shouldn't there be a rc-fix in the driver > for this regression? 100% agreed. Driver shouldn't require the DT update to continue to function. It needs to fill in the previous behavior as default. As a matter of fact, based on that I don't want to see that DT patch as a fix, please queue it up for 5.6 instead. -Olof
On Tue 10 Dec 13:00 PST 2019, Olof Johansson wrote: > On Tue, Dec 10, 2019 at 10:17 AM Bjorn Andersson > <bjorn.andersson@linaro.org> wrote: > > > > On Tue 10 Dec 09:36 PST 2019, Amit Kucheria wrote: > > > > > On Tue, Dec 10, 2019 at 4:27 PM Stephan Gerhold <stephan@gerhold.net> wrote: > > > > > > > > On Thu, Nov 07, 2019 at 09:18:54PM -0600, Andy Gross wrote: > > > > > On Thu, Nov 07, 2019 at 07:36:03PM +0530, Amit Kucheria wrote: > > > > > > (Removing arm-soc) > > > > > > > > > > > > Hi Andy, > > > > > > > > > > > > On Thu, Nov 7, 2019 at 1:04 AM Andy Gross <agross@kernel.org> wrote: > > > > > > > > > > > > > > Arnd, Olof, and Kevin, > > > > > > > > > > > > > > I have one slight faux paux in this pull request. A drivers: soc change got > > > > > > > into my arm64 DTS branch and while it is innocuous, it wasn't easy to fix > > > > > > > without messing up a lot of people who depend on the SHAs not changing. So I'm > > > > > > > sorry for this inclusion. I'll scrub this better next time. > > > > > > > > > > > > > > Andy > > > > > > > > > > > > > ---------------------------------------------------------------- > > > > > > > Amit Kucheria (5): > > > > > > > arm64: dts: qcs404: thermal: Add interrupt support > > > > > > > arm64: dts: msm8998: thermal: Add interrupt support > > > > > > > arm64: dts: msm8996: thermal: Add interrupt support > > > > > > > arm64: dts: sdm845: thermal: Add interrupt support > > > > > > > arm64: dts: msm8916: thermal: Fixup HW ids for cpu sensors > > > > > > > > > > > > One of my patches to add interrupt support to msm8916 tsens is missing > > > > > > here. Specifically this one: > > > > > > https://patchwork.kernel.org/patch/11201853/ > > > > > > > > > > > > Will there be a second PR this cycle? > > > > > > > > > > I can work up another and throw it on top. > > > > > > > > > > > > > FYI, the patch seems to be still missing in 5.5-rc1. > > > > tsens now fails to probe on MSM8916 with: > > > > > > > > qcom-tsens 4a9000.thermal-sensor: IRQ uplow not found > > > > > > > > Can you queue up the patch as fix for 5.5? > > > > > > Indeed. Andy/Bjorn, let me know if you need anything from me to get > > > this into -rc2. > > > > > > > I'm pulling in some fixes for a rc-pull, so I could add it there. > > > > But why are we breaking backwards compatibility with existing dtbs to > > add a new (optional) feature? Shouldn't there be a rc-fix in the driver > > for this regression? > > 100% agreed. > > Driver shouldn't require the DT update to continue to function. It > needs to fill in the previous behavior as default. > > As a matter of fact, based on that I don't want to see that DT patch > as a fix, please queue it up for 5.6 instead. > I've picked the patch for 5.6 Thanks, Bjorn
On Wed, Dec 11, 2019 at 2:31 AM Olof Johansson <olof@lixom.net> wrote: > > On Tue, Dec 10, 2019 at 10:17 AM Bjorn Andersson > <bjorn.andersson@linaro.org> wrote: > > > > On Tue 10 Dec 09:36 PST 2019, Amit Kucheria wrote: > > > > > On Tue, Dec 10, 2019 at 4:27 PM Stephan Gerhold <stephan@gerhold.net> wrote: > > > > > > > > On Thu, Nov 07, 2019 at 09:18:54PM -0600, Andy Gross wrote: > > > > > On Thu, Nov 07, 2019 at 07:36:03PM +0530, Amit Kucheria wrote: > > > > > > (Removing arm-soc) > > > > > > > > > > > > Hi Andy, > > > > > > > > > > > > On Thu, Nov 7, 2019 at 1:04 AM Andy Gross <agross@kernel.org> wrote: > > > > > > > > > > > > > > Arnd, Olof, and Kevin, > > > > > > > > > > > > > > I have one slight faux paux in this pull request. A drivers: soc change got > > > > > > > into my arm64 DTS branch and while it is innocuous, it wasn't easy to fix > > > > > > > without messing up a lot of people who depend on the SHAs not changing. So I'm > > > > > > > sorry for this inclusion. I'll scrub this better next time. > > > > > > > > > > > > > > Andy > > > > > > > > > > > > > ---------------------------------------------------------------- > > > > > > > Amit Kucheria (5): > > > > > > > arm64: dts: qcs404: thermal: Add interrupt support > > > > > > > arm64: dts: msm8998: thermal: Add interrupt support > > > > > > > arm64: dts: msm8996: thermal: Add interrupt support > > > > > > > arm64: dts: sdm845: thermal: Add interrupt support > > > > > > > arm64: dts: msm8916: thermal: Fixup HW ids for cpu sensors > > > > > > > > > > > > One of my patches to add interrupt support to msm8916 tsens is missing > > > > > > here. Specifically this one: > > > > > > https://patchwork.kernel.org/patch/11201853/ > > > > > > > > > > > > Will there be a second PR this cycle? > > > > > > > > > > I can work up another and throw it on top. > > > > > > > > > > > > > FYI, the patch seems to be still missing in 5.5-rc1. > > > > tsens now fails to probe on MSM8916 with: > > > > > > > > qcom-tsens 4a9000.thermal-sensor: IRQ uplow not found > > > > > > > > Can you queue up the patch as fix for 5.5? > > > > > > Indeed. Andy/Bjorn, let me know if you need anything from me to get > > > this into -rc2. > > > > > > > I'm pulling in some fixes for a rc-pull, so I could add it there. > > > > But why are we breaking backwards compatibility with existing dtbs to > > add a new (optional) feature? Shouldn't there be a rc-fix in the driver > > for this regression? > > 100% agreed. > > Driver shouldn't require the DT update to continue to function. It > needs to fill in the previous behavior as default. > > As a matter of fact, based on that I don't want to see that DT patch > as a fix, please queue it up for 5.6 instead. I've posted a fix for -rc2 to allow the driver to continue to work with old DTBs. Please consider for -rc2. Regards, Amit
Arnd, Olof, and Kevin, I have one slight faux paux in this pull request. A drivers: soc change got into my arm64 DTS branch and while it is innocuous, it wasn't easy to fix without messing up a lot of people who depend on the SHAs not changing. So I'm sorry for this inclusion. I'll scrub this better next time. Andy The following changes since commit 54ecb8f7028c5eb3d740bb82b0f1d90f2df63c5c: Linux 5.4-rc1 (2019-09-30 10:35:40 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git tags/qcom-arm64-for-5.5 for you to fetch changes up to 915603b106164f966ebc027de96e54011885bdf4: arm64: dts: qcom: db845c: Enable LVS 1 and 2 (2019-11-03 20:49:00 -0800) ---------------------------------------------------------------- Qualcomm ARM64 Updates for v5.5 * Add thermal IRQ support on MSM8916, SDM845, MSM8996, and QCS404 * Fix thermal HW ids for cpus on MSM8916 * Add blsp1 UART3 and blsp1 BAM on MSM8998 * Add volume buttons and WCNSS for Wifi and BT on MSM8916 LongCheer-l8150 * Fixup load on l21 for SD on apq8096-db820c * Enable LVS1/2, APSS watchdog, and select UFS reset gpio for SDM845 * Disable coresight by default on MSM8998 * Enable bluetooth and remove retention idle state on MSM8998-clamshell * Enable adsp, cdsp, and mpss on C630 * Enable bluetooth on MSM8998-mtp * Delete zap shader on SDM845-cheza * Add tactile buttons and hall sensor on MSM8916-Samsung-A2015 * Add Interconnect nodes, watchdog, and sleep clk on QCS404 * Override Iris compatible on MSM8916-Samsung-A5U * Enable WCNSS Wifi and bluetooth on MSM8916-Samsung-A2015 * Fixup cooling states for the aoss warming devices ---------------------------------------------------------------- Amit Kucheria (5): arm64: dts: qcs404: thermal: Add interrupt support arm64: dts: msm8998: thermal: Add interrupt support arm64: dts: msm8996: thermal: Add interrupt support arm64: dts: sdm845: thermal: Add interrupt support arm64: dts: msm8916: thermal: Fixup HW ids for cpu sensors Bjorn Andersson (3): arm64: dts: qcom: c630: Enable adsp, cdsp and mpss arm64: dts: qcom: sdm845: Add APSS watchdog node arm64: dts: qcom: db845c: Enable LVS 1 and 2 Georgi Djakov (1): arm64: dts: qcs404: Add interconnect provider DT nodes Jeffrey Hugo (5): arm64: dts: qcom: msm8998: Add blsp1 BAM arm64: dts: qcom: msm8998: Add blsp1_uart3 arm64: dts: qcom: msm8998-mtp: Enable bluetooth arm64: dts: qcom: msm8998-clamshell: Enable bluetooth arm64: dts: qcom: msm8998-clamshell: Remove retention idle state Jorge Ramirez-Ortiz (2): arm64: dts: qcom: qcs404: add sleep clk fixed rate oscillator arm64: dts: qcom: qcs404: add the watchdog node Loic Poulain (1): arm64: dts: apq8096-db820c: Increase load on l21 for SDCARD Michael Srba (1): arm64: dts: msm8916-samsung-a2015: add tactile buttons and hall sensor Nikita Travkin (2): arm64: dts: msm8916-longcheer-l8150: Enable WCNSS for WiFi and BT arm64: dts: msm8916-longcheer-l8150: Add Volume buttons Rob Clark (1): arm64: dts: qcom: sdm845-cheza: delete zap-shader Sai Prakash Ranjan (1): arm64: dts: qcom: msm8998: Disable coresight by default Stephan Gerhold (2): arm64: dts: msm8916-samsung-a2015: Enable WCNSS for WiFi and BT arm64: dts: msm8916-samsung-a5u: Override iris compatible Stephen Boyd (1): arm64: dts: qcom: sdm845: Use UFS reset gpio instead of pinctrl Thara Gopinath (1): soc: qcom: Invert the cooling states for the aoss warming devices arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 2 + .../boot/dts/qcom/msm8916-longcheer-l8150.dts | 55 ++++++++++++++ .../dts/qcom/msm8916-samsung-a2015-common.dtsi | 80 +++++++++++++++++++++ .../boot/dts/qcom/msm8916-samsung-a5u-eur.dts | 6 ++ arch/arm64/boot/dts/qcom/msm8916.dtsi | 4 +- arch/arm64/boot/dts/qcom/msm8996.dtsi | 4 ++ arch/arm64/boot/dts/qcom/msm8998-clamshell.dtsi | 54 ++++++++++++++ arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi | 82 +++++++++++++++++++++ arch/arm64/boot/dts/qcom/msm8998-pins.dtsi | 13 ++++ arch/arm64/boot/dts/qcom/msm8998.dtsi | 84 +++++++++++++++++----- arch/arm64/boot/dts/qcom/qcs404.dtsi | 41 +++++++++++ arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 53 ++------------ arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 12 ++++ arch/arm64/boot/dts/qcom/sdm845.dtsi | 12 +++- .../boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 14 ++++ drivers/soc/qcom/qcom_aoss.c | 8 +-- 16 files changed, 449 insertions(+), 75 deletions(-)