| Message ID | 20191211210204.31579-1-f.fainelli@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | watchdog: mtx-1: Relax build dependencies | expand |
Hi, Thanks for the fix. I tested the compilation with these patches. You can add my: Tested-by: Denis Efremov <efremov@linux.com> Look like this error could be fixed the same way: In file included from drivers/watchdog/ar7_wdt.c:29: ./arch/mips/include/asm/mach-ar7/ar7.h: In function ‘ar7_is_titan’: ./arch/mips/include/asm/mach-ar7/ar7.h:111:24: error: implicit declaration of function ‘KSEG1ADDR’; did you mean ‘CKSEG1ADDR’? [-Werror=implicit-function-declaration] On 12.12.2019 00:02, Florian Fainelli wrote: > Hi Wim, Guenter, > > This came up with Denis trying to fix a MIPS-related build failure: > > https://lore.kernel.org/linux-mips/20191210172739.27131-1-efremov@linux.com/ > > Florian Fainelli (2): > watchdog: mtx-1: Drop au1000.h header inclusion > watchdog: Relax dependencies for CONFIG_WDT_MTX1 > > drivers/watchdog/Kconfig | 2 +- > drivers/watchdog/mtx-1_wdt.c | 2 -- > 2 files changed, 1 insertion(+), 3 deletions(-) > Thanks, Denis
On 12/11/19 3:46 PM, Denis Efremov wrote: > Hi, > > Thanks for the fix. > I tested the compilation with these patches. > You can add my: > Tested-by: Denis Efremov <efremov@linux.com> > > Look like this error could be fixed the same way: > In file included from drivers/watchdog/ar7_wdt.c:29: > ./arch/mips/include/asm/mach-ar7/ar7.h: In function ‘ar7_is_titan’: > ./arch/mips/include/asm/mach-ar7/ar7.h:111:24: error: implicit declaration of function ‘KSEG1ADDR’; did you mean ‘CKSEG1ADDR’? [-Werror=implicit-function-declaration] > This is yet another old-style watchdog driver which should be left alone unless it has a bug that needs to be fixed. Really, if anyone out there is still using this driver, converting it to use the watchdog core would make much more sense. Guenter
On 12/11/2019 5:39 PM, Guenter Roeck wrote: > On 12/11/19 3:46 PM, Denis Efremov wrote: >> Hi, >> >> Thanks for the fix. >> I tested the compilation with these patches. >> You can add my: >> Tested-by: Denis Efremov <efremov@linux.com> >> >> Look like this error could be fixed the same way: >> In file included from drivers/watchdog/ar7_wdt.c:29: >> ./arch/mips/include/asm/mach-ar7/ar7.h: In function ‘ar7_is_titan’: >> ./arch/mips/include/asm/mach-ar7/ar7.h:111:24: error: implicit >> declaration of function ‘KSEG1ADDR’; did you mean ‘CKSEG1ADDR’? >> [-Werror=implicit-function-declaration] >> > > This is yet another old-style watchdog driver which should be left alone > unless it has a bug that needs to be fixed. Really, if anyone out there > is still using this driver, converting it to use the watchdog core > would make much more sense. AR7 is still largely available, so we might be able to get some people within the OpenWrt community to give a watchdog modernization patch a try.