| Message ID | 1563568344-1274-3-git-send-email-daidavid1@codeaurora.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Redefine interconnect provider DT nodes for SDM845 | expand |
On Fri 19 Jul 13:32 PDT 2019, David Dai wrote: > Add the DT nodes for each of the Network-On-Chip interconnect > buses found on SDM845 based platform and redefine the rsc_hlos > child node as a bcm-voter device to better represent the hardware. > > Signed-off-by: David Dai <daidavid1@codeaurora.org> > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 61 ++++++++++++++++++++++++++++++++++-- > 1 file changed, 58 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index e7d78bc..204222e 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -610,6 +610,62 @@ > #power-domain-cells = <1>; > }; > > + aggre1_noc: interconnect@16e0000 { > + compatible = "qcom,sdm845-aggre1_noc"; > + reg = <0 0x16e0000 0 0xd080>; Please pad the address to 8 digits and keep nodes sorted by address. > + #interconnect-cells = <1>; > + qcom,bcm-voter = <&apps_bcm_voter>; > + }; > + > + aggre2_noc: interconnect@1700000 { > + compatible = "qcom,sdm845-aggre2_noc"; > + reg = <0 0x1700000 0 0x3b100>; > + #interconnect-cells = <1>; > + qcom,bcm-voter = <&apps_bcm_voter>; > + }; > + > + config_noc: interconnect@1500000 { > + compatible = "qcom,sdm845-config_noc"; > + reg = <0 0x1500000 0 0x5080>; > + #interconnect-cells = <1>; > + qcom,bcm-voter = <&apps_bcm_voter>; > + }; [..] > qfprom@784000 { > compatible = "qcom,qfprom"; > reg = <0 0x00784000 0 0x8ff>; > @@ -2801,9 +2857,8 @@ > }; > }; > > - rsc_hlos: interconnect { > - compatible = "qcom,sdm845-rsc-hlos"; > - #interconnect-cells = <1>; > + apps_bcm_voter: bcm_voter { No '_' in node names, so bcm-voter. Apart from this nits this looks good. Regards, Bjorn > + compatible = "qcom,sdm845-bcm-voter"; > }; > }; > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >
Thanks for looking over this, Bjorn. On 7/21/2019 12:13 PM, Bjorn Andersson wrote: > On Fri 19 Jul 13:32 PDT 2019, David Dai wrote: > >> Add the DT nodes for each of the Network-On-Chip interconnect >> buses found on SDM845 based platform and redefine the rsc_hlos >> child node as a bcm-voter device to better represent the hardware. >> >> Signed-off-by: David Dai <daidavid1@codeaurora.org> >> --- >> arch/arm64/boot/dts/qcom/sdm845.dtsi | 61 ++++++++++++++++++++++++++++++++++-- >> 1 file changed, 58 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi >> index e7d78bc..204222e 100644 >> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi >> @@ -610,6 +610,62 @@ >> #power-domain-cells = <1>; >> }; >> >> + aggre1_noc: interconnect@16e0000 { >> + compatible = "qcom,sdm845-aggre1_noc"; >> + reg = <0 0x16e0000 0 0xd080>; > Please pad the address to 8 digits and keep nodes sorted by address. Will fix. >> + #interconnect-cells = <1>; >> + qcom,bcm-voter = <&apps_bcm_voter>; >> + }; >> + >> + aggre2_noc: interconnect@1700000 { >> + compatible = "qcom,sdm845-aggre2_noc"; >> + reg = <0 0x1700000 0 0x3b100>; >> + #interconnect-cells = <1>; >> + qcom,bcm-voter = <&apps_bcm_voter>; >> + }; >> + >> + config_noc: interconnect@1500000 { >> + compatible = "qcom,sdm845-config_noc"; >> + reg = <0 0x1500000 0 0x5080>; >> + #interconnect-cells = <1>; >> + qcom,bcm-voter = <&apps_bcm_voter>; >> + }; > [..] >> qfprom@784000 { >> compatible = "qcom,qfprom"; >> reg = <0 0x00784000 0 0x8ff>; >> @@ -2801,9 +2857,8 @@ >> }; >> }; >> >> - rsc_hlos: interconnect { >> - compatible = "qcom,sdm845-rsc-hlos"; >> - #interconnect-cells = <1>; >> + apps_bcm_voter: bcm_voter { > No '_' in node names, so bcm-voter. Ok. > > Apart from this nits this looks good. > > Regards, > Bjorn > >> + compatible = "qcom,sdm845-bcm-voter"; >> }; >> }; >> >> -- >> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, >> a Linux Foundation Collaborative Project >>
On Tue, Jul 23, 2019 at 11:24 AM David Dai <daidavid1@codeaurora.org> wrote: > > Thanks for looking over this, Bjorn. > > On 7/21/2019 12:13 PM, Bjorn Andersson wrote: > > On Fri 19 Jul 13:32 PDT 2019, David Dai wrote: > > > >> Add the DT nodes for each of the Network-On-Chip interconnect > >> buses found on SDM845 based platform and redefine the rsc_hlos > >> child node as a bcm-voter device to better represent the hardware. > >> > >> Signed-off-by: David Dai <daidavid1@codeaurora.org> > >> --- > >> arch/arm64/boot/dts/qcom/sdm845.dtsi | 61 ++++++++++++++++++++++++++++++++++-- > >> 1 file changed, 58 insertions(+), 3 deletions(-) > >> What happened to this series? Is it abandoned? -Evan
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index e7d78bc..204222e 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -610,6 +610,62 @@ #power-domain-cells = <1>; }; + aggre1_noc: interconnect@16e0000 { + compatible = "qcom,sdm845-aggre1_noc"; + reg = <0 0x16e0000 0 0xd080>; + #interconnect-cells = <1>; + qcom,bcm-voter = <&apps_bcm_voter>; + }; + + aggre2_noc: interconnect@1700000 { + compatible = "qcom,sdm845-aggre2_noc"; + reg = <0 0x1700000 0 0x3b100>; + #interconnect-cells = <1>; + qcom,bcm-voter = <&apps_bcm_voter>; + }; + + config_noc: interconnect@1500000 { + compatible = "qcom,sdm845-config_noc"; + reg = <0 0x1500000 0 0x5080>; + #interconnect-cells = <1>; + qcom,bcm-voter = <&apps_bcm_voter>; + }; + + dc_noc: interconnect@14e0000 { + compatible = "qcom,sdm845-dc_noc"; + reg = <0 0x14e0000 0 0x400>; + #interconnect-cells = <1>; + qcom,bcm-voter = <&apps_bcm_voter>; + }; + + gladiator_noc: interconnect@17900000 { + compatible = "qcom,sdm845-gladiator_noc"; + reg = <0 0x17900000 0 0xd080>; + #interconnect-cells = <1>; + qcom,bcm-voter = <&apps_bcm_voter>; + }; + + mem_noc: interconnect@1380000 { + compatible = "qcom,sdm845-mem_noc"; + reg = <0 0x1380000 0 0x27200>; + #interconnect-cells = <1>; + qcom,bcm-voter = <&apps_bcm_voter>; + }; + + mmss_noc: interconnect@1740000 { + compatible = "qcom,sdm845-mmss_noc"; + reg = <0 0x1740000 0 0x1c1000>; + #interconnect-cells = <1>; + qcom,bcm-voter = <&apps_bcm_voter>; + }; + + system_noc: interconnect@1620000 { + compatible = "qcom,sdm845-system_noc"; + reg = <0 0x1620000 0 0x18080>; + #interconnect-cells = <1>; + qcom,bcm-voter = <&apps_bcm_voter>; + }; + qfprom@784000 { compatible = "qcom,qfprom"; reg = <0 0x00784000 0 0x8ff>; @@ -2801,9 +2857,8 @@ }; }; - rsc_hlos: interconnect { - compatible = "qcom,sdm845-rsc-hlos"; - #interconnect-cells = <1>; + apps_bcm_voter: bcm_voter { + compatible = "qcom,sdm845-bcm-voter"; }; };
Add the DT nodes for each of the Network-On-Chip interconnect buses found on SDM845 based platform and redefine the rsc_hlos child node as a bcm-voter device to better represent the hardware. Signed-off-by: David Dai <daidavid1@codeaurora.org> --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 61 ++++++++++++++++++++++++++++++++++-- 1 file changed, 58 insertions(+), 3 deletions(-)