| Message ID | 459ed943fe0725200062171755bcfe5f73713d50.1575901747.git.jsarha@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/tilcdc: Remove "ti,tilcdc,tfp410" and mark "ti,tilcdc,panel" obsolete | expand |
Hi Jyri, Thank you for the patch. On Mon, Dec 09, 2019 at 04:42:15PM +0200, Jyri Sarha wrote: > The "ti,tilcdc,panel" binding should not be used anymore, since tilcdc > is fully capable of using generic drm panels like panel-simple and > panel-common binding. However, the obsolete binding is still widely > used in many mainline supported platforms that I do not have access to > and who knows how many custom platforms. So I am afraid we have to > keep the old bundled tilcdc panel driver around. But can't we drop the bindings instead of marking them as obsolete, even if we keep the driver around for some time ? Also, would it make sense to set a date for the removal of the driver, and add it to the WARN() message in patch 3/3 ? > Signed-off-by: Jyri Sarha <jsarha@ti.com> > --- > Documentation/devicetree/bindings/display/tilcdc/panel.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/tilcdc/panel.txt b/Documentation/devicetree/bindings/display/tilcdc/panel.txt > index 808216310ea2..54963f9173cc 100644 > --- a/Documentation/devicetree/bindings/display/tilcdc/panel.txt > +++ b/Documentation/devicetree/bindings/display/tilcdc/panel.txt > @@ -1,5 +1,11 @@ > Device-Tree bindings for tilcdc DRM generic panel output driver > > +NOTE: This binding (and the related driver) is obsolete and should not > + be used anymore. Please refer to drm panel-common binding (and > + to a generic drm panel driver like panel-simple). > + Documentation/devicetree/bindings/display/panel/panel-common.yaml > + (drivers/gpu/drm/panel/panel-simple.c) > + > Required properties: > - compatible: value should be "ti,tilcdc,panel". > - panel-info: configuration info to configure LCDC correctly for the panel
On 09/12/2019 16:50, Laurent Pinchart wrote: > Hi Jyri, > > Thank you for the patch. > > On Mon, Dec 09, 2019 at 04:42:15PM +0200, Jyri Sarha wrote: >> The "ti,tilcdc,panel" binding should not be used anymore, since tilcdc >> is fully capable of using generic drm panels like panel-simple and >> panel-common binding. However, the obsolete binding is still widely >> used in many mainline supported platforms that I do not have access to >> and who knows how many custom platforms. So I am afraid we have to >> keep the old bundled tilcdc panel driver around. > > But can't we drop the bindings instead of marking them as obsolete, even > if we keep the driver around for some time ? > I guess that would be alright too. > Also, would it make sense to set a date for the removal of the driver, > and add it to the WARN() message in patch 3/3 ? > Not sure about a date. I would feel quite uncomfortable of removing the driver, while there is still mainline DTSes using "ti,tilcdc,panel". I guess the next step would be putting the legacy panel driver behind a default = N config option. Then I would probably hear something if there are people actively using those DTSes. Maybe the date could be about that too. BR, Jyri >> Signed-off-by: Jyri Sarha <jsarha@ti.com> >> --- >> Documentation/devicetree/bindings/display/tilcdc/panel.txt | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/display/tilcdc/panel.txt b/Documentation/devicetree/bindings/display/tilcdc/panel.txt >> index 808216310ea2..54963f9173cc 100644 >> --- a/Documentation/devicetree/bindings/display/tilcdc/panel.txt >> +++ b/Documentation/devicetree/bindings/display/tilcdc/panel.txt >> @@ -1,5 +1,11 @@ >> Device-Tree bindings for tilcdc DRM generic panel output driver >> >> +NOTE: This binding (and the related driver) is obsolete and should not >> + be used anymore. Please refer to drm panel-common binding (and >> + to a generic drm panel driver like panel-simple). >> + Documentation/devicetree/bindings/display/panel/panel-common.yaml >> + (drivers/gpu/drm/panel/panel-simple.c) >> + >> Required properties: >> - compatible: value should be "ti,tilcdc,panel". >> - panel-info: configuration info to configure LCDC correctly for the panel >
Hi Jyri, On Fri, Dec 13, 2019 at 11:04:49AM +0200, Jyri Sarha wrote: > On 09/12/2019 16:50, Laurent Pinchart wrote: > > On Mon, Dec 09, 2019 at 04:42:15PM +0200, Jyri Sarha wrote: > >> The "ti,tilcdc,panel" binding should not be used anymore, since tilcdc > >> is fully capable of using generic drm panels like panel-simple and > >> panel-common binding. However, the obsolete binding is still widely > >> used in many mainline supported platforms that I do not have access to > >> and who knows how many custom platforms. So I am afraid we have to > >> keep the old bundled tilcdc panel driver around. > > > > But can't we drop the bindings instead of marking them as obsolete, even > > if we keep the driver around for some time ? > > > > I guess that would be alright too. > > > Also, would it make sense to set a date for the removal of the driver, > > and add it to the WARN() message in patch 3/3 ? > > > > Not sure about a date. I would feel quite uncomfortable of removing the > driver, while there is still mainline DTSes using "ti,tilcdc,panel". I > guess the next step would be putting the legacy panel driver behind a > default = N config option. Then I would probably hear something if there > are people actively using those DTSes. Maybe the date could be about > that too. The mainline DTSes are not really an issue, they should be fixed in mainline to use new bindings, and all will be good. The problem is systems using out-of-tree DTSes, or systems that will upgrade the kernel but not the DT. > >> Signed-off-by: Jyri Sarha <jsarha@ti.com> > >> --- > >> Documentation/devicetree/bindings/display/tilcdc/panel.txt | 6 ++++++ > >> 1 file changed, 6 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/display/tilcdc/panel.txt b/Documentation/devicetree/bindings/display/tilcdc/panel.txt > >> index 808216310ea2..54963f9173cc 100644 > >> --- a/Documentation/devicetree/bindings/display/tilcdc/panel.txt > >> +++ b/Documentation/devicetree/bindings/display/tilcdc/panel.txt > >> @@ -1,5 +1,11 @@ > >> Device-Tree bindings for tilcdc DRM generic panel output driver > >> > >> +NOTE: This binding (and the related driver) is obsolete and should not > >> + be used anymore. Please refer to drm panel-common binding (and > >> + to a generic drm panel driver like panel-simple). > >> + Documentation/devicetree/bindings/display/panel/panel-common.yaml > >> + (drivers/gpu/drm/panel/panel-simple.c) > >> + > >> Required properties: > >> - compatible: value should be "ti,tilcdc,panel". > >> - panel-info: configuration info to configure LCDC correctly for the panel
diff --git a/Documentation/devicetree/bindings/display/tilcdc/panel.txt b/Documentation/devicetree/bindings/display/tilcdc/panel.txt index 808216310ea2..54963f9173cc 100644 --- a/Documentation/devicetree/bindings/display/tilcdc/panel.txt +++ b/Documentation/devicetree/bindings/display/tilcdc/panel.txt @@ -1,5 +1,11 @@ Device-Tree bindings for tilcdc DRM generic panel output driver +NOTE: This binding (and the related driver) is obsolete and should not + be used anymore. Please refer to drm panel-common binding (and + to a generic drm panel driver like panel-simple). + Documentation/devicetree/bindings/display/panel/panel-common.yaml + (drivers/gpu/drm/panel/panel-simple.c) + Required properties: - compatible: value should be "ti,tilcdc,panel". - panel-info: configuration info to configure LCDC correctly for the panel
The "ti,tilcdc,panel" binding should not be used anymore, since tilcdc is fully capable of using generic drm panels like panel-simple and panel-common binding. However, the obsolete binding is still widely used in many mainline supported platforms that I do not have access to and who knows how many custom platforms. So I am afraid we have to keep the old bundled tilcdc panel driver around. Signed-off-by: Jyri Sarha <jsarha@ti.com> --- Documentation/devicetree/bindings/display/tilcdc/panel.txt | 6 ++++++ 1 file changed, 6 insertions(+)