| Message ID | 20191214181130.25808-1-tiny.windzz@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Chanwoo Choi |
| Headers | show |
| Series | [1/2] PM / devfreq: rockchip-dfi: add missing of_node_put() | expand |
2019년 12월 15일 (일) 오전 3:12, Yangtao Li <tiny.windzz@gmail.com>님이 작성: > > of_node_put needs to be called when the device node which is got > from of_parse_phandle has finished using. > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > --- > drivers/devfreq/event/rockchip-dfi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/rockchip-dfi.c > index 5d1042188727..45b190e443d8 100644 > --- a/drivers/devfreq/event/rockchip-dfi.c > +++ b/drivers/devfreq/event/rockchip-dfi.c > @@ -200,6 +200,7 @@ static int rockchip_dfi_probe(struct platform_device *pdev) > node = of_parse_phandle(np, "rockchip,pmu", 0); > if (node) { > data->regmap_pmu = syscon_node_to_regmap(node); > + of_node_put(node); > if (IS_ERR(data->regmap_pmu)) > return PTR_ERR(data->regmap_pmu); > } > -- > 2.17.1 > Applied it. Better to use the capital letter for first char of sentence.
On Sun, Dec 15, 2019 at 11:31 PM Chanwoo Choi <chanwoo@kernel.org> wrote: > > 2019년 12월 15일 (일) 오전 3:12, Yangtao Li <tiny.windzz@gmail.com>님이 작성: > > > > of_node_put needs to be called when the device node which is got > > from of_parse_phandle has finished using. > > > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > > --- > > drivers/devfreq/event/rockchip-dfi.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/rockchip-dfi.c > > index 5d1042188727..45b190e443d8 100644 > > --- a/drivers/devfreq/event/rockchip-dfi.c > > +++ b/drivers/devfreq/event/rockchip-dfi.c > > @@ -200,6 +200,7 @@ static int rockchip_dfi_probe(struct platform_device *pdev) > > node = of_parse_phandle(np, "rockchip,pmu", 0); > > if (node) { > > data->regmap_pmu = syscon_node_to_regmap(node); > > + of_node_put(node); > > if (IS_ERR(data->regmap_pmu)) > > return PTR_ERR(data->regmap_pmu); > > } > > -- > > 2.17.1 > > > > Applied it. Better to use the capital letter for first char of sentence. Thx! Yangtao > > -- > Best Regards, > Chanwoo Choi
diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/rockchip-dfi.c index 5d1042188727..45b190e443d8 100644 --- a/drivers/devfreq/event/rockchip-dfi.c +++ b/drivers/devfreq/event/rockchip-dfi.c @@ -200,6 +200,7 @@ static int rockchip_dfi_probe(struct platform_device *pdev) node = of_parse_phandle(np, "rockchip,pmu", 0); if (node) { data->regmap_pmu = syscon_node_to_regmap(node); + of_node_put(node); if (IS_ERR(data->regmap_pmu)) return PTR_ERR(data->regmap_pmu); }
of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> --- drivers/devfreq/event/rockchip-dfi.c | 1 + 1 file changed, 1 insertion(+)