| Message ID | 20191203130336.18763-1-martin.kepplinger@puri.sm (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: imx8mq-librem5-devkit: add accelerometer and gyro sensor | expand |
On 03.12.19 14:03, Martin Kepplinger wrote: > Now that there is driver support, describe the accel and gyro sensor parts > of the LSM9DS1 IMU. > > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> > --- > arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > index 683a11035643..7a92704c53ec 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > @@ -415,6 +415,13 @@ > pinctrl-0 = <&pinctrl_i2c3>; > status = "okay"; > > + accel_gyro@6a { > + compatible = "st,lsm9ds1-imu"; > + reg = <0x6a>; > + vdd-supply = <®_3v3_p>; > + vddio-supply = <®_3v3_p>; > + }; > + > magnetometer@1e { > compatible = "st,lsm9ds1-magn"; > reg = <0x1e>; > (adding / fixing people in CC) Are there any questions about this addition or the followup fix? thanks a lot, martin
Hi, On Tue, Dec 03, 2019 at 02:03:36PM +0100, Martin Kepplinger wrote: > Now that there is driver support, describe the accel and gyro sensor parts > of the LSM9DS1 IMU. > > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> > --- > arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > index 683a11035643..7a92704c53ec 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > @@ -415,6 +415,13 @@ > pinctrl-0 = <&pinctrl_i2c3>; > status = "okay"; > > + accel_gyro@6a { > + compatible = "st,lsm9ds1-imu"; > + reg = <0x6a>; > + vdd-supply = <®_3v3_p>; > + vddio-supply = <®_3v3_p>; > + }; > + Reviewed-by: Guido Günther <agx@sigxcpu.org> -- Guido > magnetometer@1e { > compatible = "st,lsm9ds1-magn"; > reg = <0x1e>; > -- > 2.20.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >
On Mon, Dec 16, 2019 at 10:32:15AM +0100, Martin Kepplinger wrote: > On 03.12.19 14:03, Martin Kepplinger wrote: > > Now that there is driver support, describe the accel and gyro sensor parts > > of the LSM9DS1 IMU. > > > > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> > > --- > > arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > > index 683a11035643..7a92704c53ec 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > > +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > > @@ -415,6 +415,13 @@ > > pinctrl-0 = <&pinctrl_i2c3>; > > status = "okay"; > > > > + accel_gyro@6a { We prefer to use hyphen than underscore in node name. Also nodes with unit-address should be sorted in the address. Shawn > > + compatible = "st,lsm9ds1-imu"; > > + reg = <0x6a>; > > + vdd-supply = <®_3v3_p>; > > + vddio-supply = <®_3v3_p>; > > + }; > > + > > magnetometer@1e { > > compatible = "st,lsm9ds1-magn"; > > reg = <0x1e>; > > > > (adding / fixing people in CC) > > Are there any questions about this addition or the followup fix? > > thanks a lot, > > martin
On 23.12.19 08:18, Shawn Guo wrote: > On Mon, Dec 16, 2019 at 10:32:15AM +0100, Martin Kepplinger wrote: >> On 03.12.19 14:03, Martin Kepplinger wrote: >>> Now that there is driver support, describe the accel and gyro sensor parts >>> of the LSM9DS1 IMU. >>> >>> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> >>> --- >>> arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts >>> index 683a11035643..7a92704c53ec 100644 >>> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts >>> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts >>> @@ -415,6 +415,13 @@ >>> pinctrl-0 = <&pinctrl_i2c3>; >>> status = "okay"; >>> >>> + accel_gyro@6a { > > We prefer to use hyphen than underscore in node name. Also nodes with > unit-address should be sorted in the address. > > Shawn thanks a lot for taking a look. resent. martin
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts index 683a11035643..7a92704c53ec 100644 --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts @@ -415,6 +415,13 @@ pinctrl-0 = <&pinctrl_i2c3>; status = "okay"; + accel_gyro@6a { + compatible = "st,lsm9ds1-imu"; + reg = <0x6a>; + vdd-supply = <®_3v3_p>; + vddio-supply = <®_3v3_p>; + }; + magnetometer@1e { compatible = "st,lsm9ds1-magn"; reg = <0x1e>;
Now that there is driver support, describe the accel and gyro sensor parts of the LSM9DS1 IMU. Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> --- arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 7 +++++++ 1 file changed, 7 insertions(+)