| Message ID | 20191111042508.12628-2-govinds@codeaurora.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | Don't call SCM interface for statically mapped msa region | expand |
On Mon, Nov 11, 2019 at 09:55:07AM +0530, Govind Singh wrote: > Add boolean context flag to disable SCM call for statically > mapped msa region. Can't this be implied by the compatible string? > > Signed-off-by: Govind Singh <govinds@codeaurora.org> > --- > .../devicetree/bindings/net/wireless/qcom,ath10k.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt > index 017128394a3e..7ba22918bab7 100644 > --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt > +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt > @@ -88,6 +88,9 @@ Optional properties: > of the host capability QMI request > - qcom,xo-cal-data: xo cal offset to be configured in xo trim register. > > +- qcom,msa_fixed_perm: Boolean context flag to disable SCM call for statically > + mapped msa region. > + s/_/-/ > Example (to supply PCI based wifi block details): > > In this example, the node is defined as child node of the PCI controller. > @@ -185,4 +188,5 @@ wifi@18000000 { > vdd-3.3-ch0-supply = <&vreg_l25a_3p3>; > memory-region = <&wifi_msa_mem>; > iommus = <&apps_smmu 0x0040 0x1>; > + qcom,msa_fixed_perm; > }; > -- > 2.22.0 >
Hi Rob, On 2019-11-15 00:46, Rob Herring wrote: > On Mon, Nov 11, 2019 at 09:55:07AM +0530, Govind Singh wrote: >> Add boolean context flag to disable SCM call for statically >> mapped msa region. > > Can't this be implied by the compatible string? > same soc compatible will be used in older TZ vs new TZ. Due to this reason I added this. >> >> Signed-off-by: Govind Singh <govinds@codeaurora.org> >> --- >> .../devicetree/bindings/net/wireless/qcom,ath10k.txt | 4 >> ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git >> a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt >> b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt >> index 017128394a3e..7ba22918bab7 100644 >> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt >> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt >> @@ -88,6 +88,9 @@ Optional properties: >> of the host capability QMI request >> - qcom,xo-cal-data: xo cal offset to be configured in xo trim >> register. >> >> +- qcom,msa_fixed_perm: Boolean context flag to disable SCM call for >> statically >> + mapped msa region. >> + > > s/_/-/ > >> Example (to supply PCI based wifi block details): >> >> In this example, the node is defined as child node of the PCI >> controller. >> @@ -185,4 +188,5 @@ wifi@18000000 { >> vdd-3.3-ch0-supply = <&vreg_l25a_3p3>; >> memory-region = <&wifi_msa_mem>; >> iommus = <&apps_smmu 0x0040 0x1>; >> + qcom,msa_fixed_perm; >> }; >> -- >> 2.22.0 >> BR, Govind
govinds@codeaurora.org writes: > On 2019-11-15 00:46, Rob Herring wrote: >> On Mon, Nov 11, 2019 at 09:55:07AM +0530, Govind Singh wrote: >>> Add boolean context flag to disable SCM call for statically >>> mapped msa region. >> >> Can't this be implied by the compatible string? >> > > same soc compatible will be used in older TZ vs new TZ. > Due to this reason I added this. So what should we do? Rob, any suggestions? Full patch here: https://patchwork.kernel.org/patch/11236535/
diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt index 017128394a3e..7ba22918bab7 100644 --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt @@ -88,6 +88,9 @@ Optional properties: of the host capability QMI request - qcom,xo-cal-data: xo cal offset to be configured in xo trim register. +- qcom,msa_fixed_perm: Boolean context flag to disable SCM call for statically + mapped msa region. + Example (to supply PCI based wifi block details): In this example, the node is defined as child node of the PCI controller. @@ -185,4 +188,5 @@ wifi@18000000 { vdd-3.3-ch0-supply = <&vreg_l25a_3p3>; memory-region = <&wifi_msa_mem>; iommus = <&apps_smmu 0x0040 0x1>; + qcom,msa_fixed_perm; };
Add boolean context flag to disable SCM call for statically mapped msa region. Signed-off-by: Govind Singh <govinds@codeaurora.org> --- .../devicetree/bindings/net/wireless/qcom,ath10k.txt | 4 ++++ 1 file changed, 4 insertions(+)