diff mbox series

[v3,2/3] dt-bindings: display: panel: Add binding document for Xinpeng XPP055C272

Message ID 20191217140703.23867-2-heiko@sntech.de (mailing list archive)
State New, archived
Headers show
Series [v3,1/3] dt-bindings: Add vendor prefix for Xinpeng Technology | expand

Commit Message

Heiko Stuebner Dec. 17, 2019, 2:07 p.m. UTC 
From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>

The XPP055C272 is a 5.5" 720x1280 DSI display.

changes in v2:
- add size info into binding title (Sam)
- add more required properties (Sam)

Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
---
 .../display/panel/xinpeng,xpp055c272.yaml     | 48 +++++++++++++++++++
 1 file changed, 48 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml

Comments

Maxime Ripard Dec. 17, 2019, 2:24 p.m. UTC | #1 
Hi,

On Tue, Dec 17, 2019 at 03:07:02PM +0100, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
>
> The XPP055C272 is a 5.5" 720x1280 DSI display.
>
> changes in v2:
> - add size info into binding title (Sam)
> - add more required properties (Sam)
>
> Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> ---
>  .../display/panel/xinpeng,xpp055c272.yaml     | 48 +++++++++++++++++++
>  1 file changed, 48 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml b/Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml
> new file mode 100644
> index 000000000000..2d0fc97d735c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/sony,acx424akp.yaml#

The ID doesn't match the file name.

Did you run dt_bindings_check?

> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Xinpeng XPP055C272 5.5in 720x1280 DSI panel
> +
> +maintainers:
> +  - Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> +
> +allOf:
> +  - $ref: panel-common.yaml#
> +
> +properties:
> +  compatible:
> +    const: xinpeng,xpp055c272
> +  reg: true
> +  backlight: true
> +  port: true

What is the port supposed to be doing?

> +  reset-gpios: true
> +  iovcc-supply:
> +     description: regulator that supplies the iovcc voltage
> +  vci-supply:
> +     description: regulator that supplies the vci voltage
> +
> +required:
> +  - compatible
> +  - reg
> +  - backlight
> +  - iovcc-supply
> +  - vci-supply
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    dsi@ff450000 {
> +        panel@0 {
> +            compatible = "xinpeng,xpp055c272";
> +            reg = <0>;
> +            backlight = <&backlight>;
> +            iovcc-supply = <&vcc_1v8>;
> +            vci-supply = <&vcc3v3_lcd>;
> +        };
> +    };
> +
> +...

Thanks!
Maxime
Heiko Stuebner Dec. 17, 2019, 3:08 p.m. UTC | #2 
Am Dienstag, 17. Dezember 2019, 15:24:46 CET schrieb Maxime Ripard:
> Hi,
> 
> On Tue, Dec 17, 2019 at 03:07:02PM +0100, Heiko Stuebner wrote:
> > From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> >
> > The XPP055C272 is a 5.5" 720x1280 DSI display.
> >
> > changes in v2:
> > - add size info into binding title (Sam)
> > - add more required properties (Sam)
> >
> > Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> > Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> > ---
> >  .../display/panel/xinpeng,xpp055c272.yaml     | 48 +++++++++++++++++++
> >  1 file changed, 48 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml b/Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml
> > new file mode 100644
> > index 000000000000..2d0fc97d735c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml
> > @@ -0,0 +1,48 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/display/panel/sony,acx424akp.yaml#
> 
> The ID doesn't match the file name.
> 
> Did you run dt_bindings_check?

Thanks for that pointer ... I did run dtbs_check on the binding and was
sooo happy to not find any panel errors in the pages of other dt errors
but till now didn't realize that there's also a dtbinding_check.

Will keep that in mind for future bindings  - and of course fix things
in the next version.


> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Xinpeng XPP055C272 5.5in 720x1280 DSI panel
> > +
> > +maintainers:
> > +  - Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> > +
> > +allOf:
> > +  - $ref: panel-common.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    const: xinpeng,xpp055c272
> > +  reg: true
> > +  backlight: true
> > +  port: true
> 
> What is the port supposed to be doing?

Hooking the display up to the dsi controller. But you're right,
works without port as well with these single-dsi displays.

I just remember needing one for the Gru-Scarlet display that needed
to connect to two dsi controllers.

So I'll drop the port node here and from my board devicetree.

Thanks for the review
Heiko


> 
> > +  reset-gpios: true
> > +  iovcc-supply:
> > +     description: regulator that supplies the iovcc voltage
> > +  vci-supply:
> > +     description: regulator that supplies the vci voltage
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - backlight
> > +  - iovcc-supply
> > +  - vci-supply
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    dsi@ff450000 {
> > +        panel@0 {
> > +            compatible = "xinpeng,xpp055c272";
> > +            reg = <0>;
> > +            backlight = <&backlight>;
> > +            iovcc-supply = <&vcc_1v8>;
> > +            vci-supply = <&vcc3v3_lcd>;
> > +        };
> > +    };
> > +
> > +...
> 
> Thanks!
> Maxime
>
Maxime Ripard Dec. 17, 2019, 4:01 p.m. UTC | #3 
On Tue, Dec 17, 2019 at 04:08:49PM +0100, Heiko Stübner wrote:
> Am Dienstag, 17. Dezember 2019, 15:24:46 CET schrieb Maxime Ripard:
> > Hi,
> >
> > On Tue, Dec 17, 2019 at 03:07:02PM +0100, Heiko Stuebner wrote:
> > > From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> > >
> > > The XPP055C272 is a 5.5" 720x1280 DSI display.
> > >
> > > changes in v2:
> > > - add size info into binding title (Sam)
> > > - add more required properties (Sam)
> > >
> > > Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> > > Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> > > ---
> > >  .../display/panel/xinpeng,xpp055c272.yaml     | 48 +++++++++++++++++++
> > >  1 file changed, 48 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml b/Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml
> > > new file mode 100644
> > > index 000000000000..2d0fc97d735c
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml
> > > @@ -0,0 +1,48 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/display/panel/sony,acx424akp.yaml#
> >
> > The ID doesn't match the file name.
> >
> > Did you run dt_bindings_check?
>
> Thanks for that pointer ... I did run dtbs_check on the binding and was
> sooo happy to not find any panel errors in the pages of other dt errors
> but till now didn't realize that there's also a dtbinding_check.

dt_bindings_check is a sanity check on the bindings
themselves. dtbs_check is using those bindings to check the device
trees.

dtbs_check used to have a dependency on dt_bindings_check, but it got
removed recently.

Maxime

>
> Will keep that in mind for future bindings  - and of course fix things
> in the next version.
>
>
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Xinpeng XPP055C272 5.5in 720x1280 DSI panel
> > > +
> > > +maintainers:
> > > +  - Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> > > +
> > > +allOf:
> > > +  - $ref: panel-common.yaml#
> > > +
> > > +properties:
> > > +  compatible:
> > > +    const: xinpeng,xpp055c272
> > > +  reg: true
> > > +  backlight: true
> > > +  port: true
> >
> > What is the port supposed to be doing?
>
> Hooking the display up to the dsi controller. But you're right,
> works without port as well with these single-dsi displays.
>
> I just remember needing one for the Gru-Scarlet display that needed
> to connect to two dsi controllers.
>
> So I'll drop the port node here and from my board devicetree.

It's not really what I meant though :)

If it's needed then we should definitely have it, but we should
document our expectations here: is it the input port ? output? in
which case do we want to use it since it's optional, etc.

Maxime
Heiko Stuebner Dec. 17, 2019, 10:53 p.m. UTC | #4 
Hi Maxime,

Am Dienstag, 17. Dezember 2019, 17:01:22 CET schrieb Maxime Ripard:
> On Tue, Dec 17, 2019 at 04:08:49PM +0100, Heiko Stübner wrote:
> > Am Dienstag, 17. Dezember 2019, 15:24:46 CET schrieb Maxime Ripard:
> > > Hi,
> > >
> > > On Tue, Dec 17, 2019 at 03:07:02PM +0100, Heiko Stuebner wrote:
> > > > From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> > > >
> > > > The XPP055C272 is a 5.5" 720x1280 DSI display.
> > > >
> > > > changes in v2:
> > > > - add size info into binding title (Sam)
> > > > - add more required properties (Sam)
> > > >
> > > > Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> > > > Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> > > > ---
> > > >  .../display/panel/xinpeng,xpp055c272.yaml     | 48 +++++++++++++++++++
> > > >  1 file changed, 48 insertions(+)
> > > >  create mode 100644 Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml b/Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml
> > > > new file mode 100644
> > > > index 000000000000..2d0fc97d735c
> > > > --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml
> > > > @@ -0,0 +1,48 @@
> > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > > +%YAML 1.2
> > > > +---
> > > > +$id: http://devicetree.org/schemas/display/panel/sony,acx424akp.yaml#
> > >
> > > The ID doesn't match the file name.
> > >
> > > Did you run dt_bindings_check?
> >
> > Thanks for that pointer ... I did run dtbs_check on the binding and was
> > sooo happy to not find any panel errors in the pages of other dt errors
> > but till now didn't realize that there's also a dtbinding_check.
> 
> dt_bindings_check is a sanity check on the bindings
> themselves. dtbs_check is using those bindings to check the device
> trees.
> 
> dtbs_check used to have a dependency on dt_bindings_check, but it got
> removed recently.
> 
> Maxime
> 
> >
> > Will keep that in mind for future bindings  - and of course fix things
> > in the next version.
> >
> >
> > > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > > +
> > > > +title: Xinpeng XPP055C272 5.5in 720x1280 DSI panel
> > > > +
> > > > +maintainers:
> > > > +  - Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
> > > > +
> > > > +allOf:
> > > > +  - $ref: panel-common.yaml#
> > > > +
> > > > +properties:
> > > > +  compatible:
> > > > +    const: xinpeng,xpp055c272
> > > > +  reg: true
> > > > +  backlight: true
> > > > +  port: true
> > >
> > > What is the port supposed to be doing?
> >
> > Hooking the display up to the dsi controller. But you're right,
> > works without port as well with these single-dsi displays.
> >
> > I just remember needing one for the Gru-Scarlet display that needed
> > to connect to two dsi controllers.
> >
> > So I'll drop the port node here and from my board devicetree.
> 
> It's not really what I meant though :)
> 
> If it's needed then we should definitely have it, but we should
> document our expectations here: is it the input port ? output? in
> which case do we want to use it since it's optional, etc.

The port was actually unnecessary. As far as I understand dsi stuff,
the common case is the panel as subnode of the dsi controller and
the controller then finding the display itself automatically.

If you look at
	"drm/bridge/synopsys: dsi: use mipi_dsi_device to find panel or bridge" [0]
I just sent, you'll see that the dw-mipi-dsi used drm_of_find_panel_or_bridge
to find its panel/bridge thus requiring port connections in all cases where
it had the dsi-device available already, so wouldn't need to use ports for it.

Or I'm completely wrong and port usage is better, we'll see :-D


Heiko


[0] https://patchwork.freedesktop.org/patch/345666/
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml b/Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml
new file mode 100644
index 000000000000..2d0fc97d735c
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/xinpeng,xpp055c272.yaml
@@ -0,0 +1,48 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/sony,acx424akp.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Xinpeng XPP055C272 5.5in 720x1280 DSI panel
+
+maintainers:
+  - Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    const: xinpeng,xpp055c272
+  reg: true
+  backlight: true
+  port: true
+  reset-gpios: true
+  iovcc-supply:
+     description: regulator that supplies the iovcc voltage
+  vci-supply:
+     description: regulator that supplies the vci voltage
+
+required:
+  - compatible
+  - reg
+  - backlight
+  - iovcc-supply
+  - vci-supply
+
+additionalProperties: false
+
+examples:
+  - |
+    dsi@ff450000 {
+        panel@0 {
+            compatible = "xinpeng,xpp055c272";
+            reg = <0>;
+            backlight = <&backlight>;
+            iovcc-supply = <&vcc_1v8>;
+            vci-supply = <&vcc3v3_lcd>;
+        };
+    };
+
+...