diff mbox series

KVM: vmx: delete meaningless nested_vmx_prepare_msr_bitmap() declaration

Message ID 1576306125-18843-1-git-send-email-linmiaohe@huawei.com (mailing list archive)
State New, archived
Headers show
Series KVM: vmx: delete meaningless nested_vmx_prepare_msr_bitmap() declaration | expand

Commit Message

Miaohe Lin Dec. 14, 2019, 6:48 a.m. UTC 
From: Miaohe Lin <linmiaohe@huawei.com>

The function nested_vmx_prepare_msr_bitmap() declaration is below its
implementation. So this is meaningless and should be removed.

Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
 arch/x86/kvm/vmx/nested.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Sean Christopherson Dec. 17, 2019, 11:25 p.m. UTC | #1 
On Sat, Dec 14, 2019 at 02:48:45PM +0800, linmiaohe wrote:
> From: Miaohe Lin <linmiaohe@huawei.com>
> 
> The function nested_vmx_prepare_msr_bitmap() declaration is below its
> implementation. So this is meaningless and should be removed.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---

Reviewed-by: Sean Christopherson <sean.j.christopherson@intel.com>
Paolo Bonzini Jan. 15, 2020, 6:08 p.m. UTC | #2 
On 14/12/19 07:48, linmiaohe wrote:
> From: Miaohe Lin <linmiaohe@huawei.com>
> 
> The function nested_vmx_prepare_msr_bitmap() declaration is below its
> implementation. So this is meaningless and should be removed.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
>  arch/x86/kvm/vmx/nested.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c
> index 63ab49de324d..e038a331583c 100644
> --- a/arch/x86/kvm/vmx/nested.c
> +++ b/arch/x86/kvm/vmx/nested.c
> @@ -3048,9 +3048,6 @@ static int nested_vmx_check_vmentry_hw(struct kvm_vcpu *vcpu)
>  	return 0;
>  }
>  
> -static inline bool nested_vmx_prepare_msr_bitmap(struct kvm_vcpu *vcpu,
> -						 struct vmcs12 *vmcs12);
> -
>  static bool nested_get_vmcs12_pages(struct kvm_vcpu *vcpu)
>  {
>  	struct vmcs12 *vmcs12 = get_vmcs12(vcpu);
> 

Queued, thanks.

Paolo
diff mbox series

Patch

diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c
index 63ab49de324d..e038a331583c 100644
--- a/arch/x86/kvm/vmx/nested.c
+++ b/arch/x86/kvm/vmx/nested.c
@@ -3048,9 +3048,6 @@  static int nested_vmx_check_vmentry_hw(struct kvm_vcpu *vcpu)
 	return 0;
 }
 
-static inline bool nested_vmx_prepare_msr_bitmap(struct kvm_vcpu *vcpu,
-						 struct vmcs12 *vmcs12);
-
 static bool nested_get_vmcs12_pages(struct kvm_vcpu *vcpu)
 {
 	struct vmcs12 *vmcs12 = get_vmcs12(vcpu);