| Message ID | 20191218034257.54535-1-natechancellor@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ALSA: usx2y: Adjust indentation in snd_usX2Y_hwdep_dsp_status | expand |
On Wed, 18 Dec 2019 04:42:57 +0100, Nathan Chancellor wrote: > > Clang warns: > > ../sound/usb/usx2y/usX2Yhwdep.c:122:3: warning: misleading indentation; > statement is not part of the previous 'if' [-Wmisleading-indentation] > info->version = USX2Y_DRIVER_VERSION; > ^ > ../sound/usb/usx2y/usX2Yhwdep.c:120:2: note: previous statement is here > if (us428->chip_status & USX2Y_STAT_CHIP_INIT) > ^ > 1 warning generated. > > This warning occurs because there is a space before the tab on this > line. Remove it so that the indentation is consistent with the Linux > kernel coding style and clang no longer warns. > > This was introduced before the beginning of git history so no fixes tag. > > Link: https://github.com/ClangBuiltLinux/linux/issues/831 > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Applied, thanks. Takashi
diff --git a/sound/usb/usx2y/usX2Yhwdep.c b/sound/usb/usx2y/usX2Yhwdep.c index d1caa8ed9e68..9985fc139487 100644 --- a/sound/usb/usx2y/usX2Yhwdep.c +++ b/sound/usb/usx2y/usX2Yhwdep.c @@ -119,7 +119,7 @@ static int snd_usX2Y_hwdep_dsp_status(struct snd_hwdep *hw, info->num_dsps = 2; // 0: Prepad Data, 1: FPGA Code if (us428->chip_status & USX2Y_STAT_CHIP_INIT) info->chip_ready = 1; - info->version = USX2Y_DRIVER_VERSION; + info->version = USX2Y_DRIVER_VERSION; return 0; }
Clang warns: ../sound/usb/usx2y/usX2Yhwdep.c:122:3: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation] info->version = USX2Y_DRIVER_VERSION; ^ ../sound/usb/usx2y/usX2Yhwdep.c:120:2: note: previous statement is here if (us428->chip_status & USX2Y_STAT_CHIP_INIT) ^ 1 warning generated. This warning occurs because there is a space before the tab on this line. Remove it so that the indentation is consistent with the Linux kernel coding style and clang no longer warns. This was introduced before the beginning of git history so no fixes tag. Link: https://github.com/ClangBuiltLinux/linux/issues/831 Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> --- sound/usb/usx2y/usX2Yhwdep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)