| Message ID | 20191218084320.312561-1-pbrobinson@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | gpu/drm/v3d: Add ARCH_BCM2835 to DRM_V3D Kconfig | expand |
Hi Peter, On Wed, 2019-12-18 at 08:43 +0000, Peter Robinson wrote: > On arm64 the config ARCH_BCM doesn't exist so to be able to > build for platforms such as the Raspberry Pi 4 we need to add > ARCH_BCM2835 similar to what has been done on vc4. > > Signed-off-by: Peter Robinson <pbrobinson@gmail.com> > --- v3d's upstream implementation doesn't support RPi4 for now. So I don't see how we could benefit from this. That said you're more than welcome to have a go at adding support for RPi4. It seems to me that the divergence betweeen us and Raspberry Pi foundation's kernel isn't that big. Maybe Eric can share some extra light on this. Regards, Nicolas > drivers/gpu/drm/v3d/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/v3d/Kconfig b/drivers/gpu/drm/v3d/Kconfig > index 9a5c44606337..b0e048697964 100644 > --- a/drivers/gpu/drm/v3d/Kconfig > +++ b/drivers/gpu/drm/v3d/Kconfig > @@ -1,7 +1,7 @@ > # SPDX-License-Identifier: GPL-2.0-only > config DRM_V3D > tristate "Broadcom V3D 3.x and newer" > - depends on ARCH_BCM || ARCH_BCMSTB || COMPILE_TEST > + depends on ARCH_BCM || ARCH_BCMSTB || ARCH_BCM2835 || COMPILE_TEST > depends on DRM > depends on COMMON_CLK > depends on MMU
On 12/18/19 6:39 AM, Nicolas Saenz Julienne wrote: > Hi Peter, > > On Wed, 2019-12-18 at 08:43 +0000, Peter Robinson wrote: >> On arm64 the config ARCH_BCM doesn't exist so to be able to >> build for platforms such as the Raspberry Pi 4 we need to add >> ARCH_BCM2835 similar to what has been done on vc4. >> >> Signed-off-by: Peter Robinson <pbrobinson@gmail.com> >> --- > > v3d's upstream implementation doesn't support RPi4 for now. So I don't see how > we could benefit from this. Right, but it should support the Pi3 running in 64-bit mode too, so maybe that would be a better justification to put in the commit message? > > That said you're more than welcome to have a go at adding support for RPi4. It > seems to me that the divergence betweeen us and Raspberry Pi foundation's > kernel isn't that big. Maybe Eric can share some extra light on this. > > Regards, > Nicolas > >> drivers/gpu/drm/v3d/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/v3d/Kconfig b/drivers/gpu/drm/v3d/Kconfig >> index 9a5c44606337..b0e048697964 100644 >> --- a/drivers/gpu/drm/v3d/Kconfig >> +++ b/drivers/gpu/drm/v3d/Kconfig >> @@ -1,7 +1,7 @@ >> # SPDX-License-Identifier: GPL-2.0-only >> config DRM_V3D >> tristate "Broadcom V3D 3.x and newer" >> - depends on ARCH_BCM || ARCH_BCMSTB || COMPILE_TEST >> + depends on ARCH_BCM || ARCH_BCMSTB || ARCH_BCM2835 || COMPILE_TEST >> depends on DRM >> depends on COMMON_CLK >> depends on MMU >
Hi Florian, On Wed, 2019-12-18 at 09:39 -0800, Florian Fainelli wrote: > On 12/18/19 6:39 AM, Nicolas Saenz Julienne wrote: > > Hi Peter, > > > > On Wed, 2019-12-18 at 08:43 +0000, Peter Robinson wrote: > > > On arm64 the config ARCH_BCM doesn't exist so to be able to > > > build for platforms such as the Raspberry Pi 4 we need to add > > > ARCH_BCM2835 similar to what has been done on vc4. > > > > > > Signed-off-by: Peter Robinson <pbrobinson@gmail.com> > > > --- > > > > v3d's upstream implementation doesn't support RPi4 for now. So I don't see > > how > > we could benefit from this. > > Right, but it should support the Pi3 running in 64-bit mode too, so > maybe that would be a better justification to put in the commit message? Correct me if I'm wrong, but this 'v3d' isn't the same as 'vc4_v3d'. From the initial commit for the driver[1] I understood this is only valid for bcm2711. Regards, Nicolas [1] https://lore.kernel.org/lkml/20180430181058.30181-3-eric@anholt.net/
On Wed, Dec 18, 2019 at 6:39 AM Nicolas Saenz Julienne <nsaenzjulienne@suse.de> wrote: > > Hi Peter, > > On Wed, 2019-12-18 at 08:43 +0000, Peter Robinson wrote: > > On arm64 the config ARCH_BCM doesn't exist so to be able to > > build for platforms such as the Raspberry Pi 4 we need to add > > ARCH_BCM2835 similar to what has been done on vc4. > > > > Signed-off-by: Peter Robinson <pbrobinson@gmail.com> > > --- > > v3d's upstream implementation doesn't support RPi4 for now. So I don't see how > we could benefit from this. All you need is a compatible string for making this driver work on pi4's v3d, so this seems like a good change to be making, to me. Peter, feel like defining the compatible string too?
diff --git a/drivers/gpu/drm/v3d/Kconfig b/drivers/gpu/drm/v3d/Kconfig index 9a5c44606337..b0e048697964 100644 --- a/drivers/gpu/drm/v3d/Kconfig +++ b/drivers/gpu/drm/v3d/Kconfig @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only config DRM_V3D tristate "Broadcom V3D 3.x and newer" - depends on ARCH_BCM || ARCH_BCMSTB || COMPILE_TEST + depends on ARCH_BCM || ARCH_BCMSTB || ARCH_BCM2835 || COMPILE_TEST depends on DRM depends on COMMON_CLK depends on MMU
On arm64 the config ARCH_BCM doesn't exist so to be able to build for platforms such as the Raspberry Pi 4 we need to add ARCH_BCM2835 similar to what has been done on vc4. Signed-off-by: Peter Robinson <pbrobinson@gmail.com> --- drivers/gpu/drm/v3d/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)