| Message ID | 20191216135834.27775-2-enric.balletbo@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/bridge: PS8640 MIPI-to-eDP bridge | expand |
On Mon, Dec 16, 2019 at 02:58:33PM +0100, Enric Balletbo i Serra wrote: > From: Jitao Shi <jitao.shi@mediatek.com> > > Add documentation for DT properties supported by > ps8640 DSI-eDP converter. > > Signed-off-by: Jitao Shi <jitao.shi@mediatek.com> > Acked-by: Rob Herring <robh@kernel.org> > Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de> > Signed-off-by: Ulrich Hecht <uli@fpond.eu> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > --- > > Changes in v21: None > Changes in v19: None > Changes in v18: None > Changes in v17: None > Changes in v16: None > Changes in v15: None > Changes in v14: None > Changes in v13: None > Changes in v12: None > Changes in v11: None > > .../bindings/display/bridge/ps8640.txt | 44 +++++++++++++++++++ > 1 file changed, 44 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/ps8640.txt > > diff --git a/Documentation/devicetree/bindings/display/bridge/ps8640.txt b/Documentation/devicetree/bindings/display/bridge/ps8640.txt > new file mode 100644 > index 000000000000..7b13f92f7359 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/ps8640.txt > @@ -0,0 +1,44 @@ > +ps8640-bridge bindings > + > +Required properties: > + - compatible: "parade,ps8640" > + - reg: first page address of the bridge. > + - sleep-gpios: OF device-tree gpio specification for PD pin. > + - reset-gpios: OF device-tree gpio specification for reset pin. > + - vdd12-supply: OF device-tree regulator specification for 1.2V power. > + - vdd33-supply: OF device-tree regulator specification for 3.3V power. > + - ports: The device node can contain video interface port nodes per > + the video-interfaces bind[1]. For port@0,set the reg = <0> as > + ps8640 dsi in and port@1,set the reg = <1> as ps8640 eDP out. > + > +Optional properties: > + - mode-sel-gpios: OF device-tree gpio specification for mode-sel pin. > +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt > + > +Example: > + edp-bridge@18 { > + compatible = "parade,ps8640"; > + reg = <0x18>; > + sleep-gpios = <&pio 116 GPIO_ACTIVE_LOW>; > + reset-gpios = <&pio 115 GPIO_ACTIVE_LOW>; > + mode-sel-gpios = <&pio 92 GPIO_ACTIVE_HIGH>; > + vdd12-supply = <&ps8640_fixed_1v2>; > + vdd33-supply = <&mt6397_vgp2_reg>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + port@0 { > + reg = <0>; > + ps8640_in: endpoint { > + remote-endpoint = <&dsi0_out>; > + }; > + }; > + port@1 { > + reg = <1>; > + ps8640_out: endpoint { > + remote-endpoint = <&panel_in>; > + }; > + }; > + }; > + }; It's not really fair to ask this after the rough history of this patchset apparently, but bindings should be submitted in the YAML format now. This wouldn't be nice to stop it from going in just because of this, so can you send a subsequent patch fixing this? Thanks! Maxime
Hi Maxime, Thanks for your comment, just preparing another version. On 17/12/19 15:28, Maxime Ripard wrote: > On Mon, Dec 16, 2019 at 02:58:33PM +0100, Enric Balletbo i Serra wrote: >> From: Jitao Shi <jitao.shi@mediatek.com> >> >> Add documentation for DT properties supported by >> ps8640 DSI-eDP converter. >> >> Signed-off-by: Jitao Shi <jitao.shi@mediatek.com> >> Acked-by: Rob Herring <robh@kernel.org> >> Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de> >> Signed-off-by: Ulrich Hecht <uli@fpond.eu> >> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> >> --- >> >> Changes in v21: None >> Changes in v19: None >> Changes in v18: None >> Changes in v17: None >> Changes in v16: None >> Changes in v15: None >> Changes in v14: None >> Changes in v13: None >> Changes in v12: None >> Changes in v11: None >> >> .../bindings/display/bridge/ps8640.txt | 44 +++++++++++++++++++ >> 1 file changed, 44 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/display/bridge/ps8640.txt >> >> diff --git a/Documentation/devicetree/bindings/display/bridge/ps8640.txt b/Documentation/devicetree/bindings/display/bridge/ps8640.txt >> new file mode 100644 >> index 000000000000..7b13f92f7359 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/bridge/ps8640.txt >> @@ -0,0 +1,44 @@ >> +ps8640-bridge bindings >> + >> +Required properties: >> + - compatible: "parade,ps8640" >> + - reg: first page address of the bridge. >> + - sleep-gpios: OF device-tree gpio specification for PD pin. >> + - reset-gpios: OF device-tree gpio specification for reset pin. >> + - vdd12-supply: OF device-tree regulator specification for 1.2V power. >> + - vdd33-supply: OF device-tree regulator specification for 3.3V power. >> + - ports: The device node can contain video interface port nodes per >> + the video-interfaces bind[1]. For port@0,set the reg = <0> as >> + ps8640 dsi in and port@1,set the reg = <1> as ps8640 eDP out. >> + >> +Optional properties: >> + - mode-sel-gpios: OF device-tree gpio specification for mode-sel pin. >> +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt >> + >> +Example: >> + edp-bridge@18 { >> + compatible = "parade,ps8640"; >> + reg = <0x18>; >> + sleep-gpios = <&pio 116 GPIO_ACTIVE_LOW>; >> + reset-gpios = <&pio 115 GPIO_ACTIVE_LOW>; >> + mode-sel-gpios = <&pio 92 GPIO_ACTIVE_HIGH>; >> + vdd12-supply = <&ps8640_fixed_1v2>; >> + vdd33-supply = <&mt6397_vgp2_reg>; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + port@0 { >> + reg = <0>; >> + ps8640_in: endpoint { >> + remote-endpoint = <&dsi0_out>; >> + }; >> + }; >> + port@1 { >> + reg = <1>; >> + ps8640_out: endpoint { >> + remote-endpoint = <&panel_in>; >> + }; >> + }; >> + }; >> + }; > > It's not really fair to ask this after the rough history of this > patchset apparently, but bindings should be submitted in the YAML > format now. > > This wouldn't be nice to stop it from going in just because of this, > so can you send a subsequent patch fixing this? > I don't mind to use YAML format for next version, in fact, I think is the best. Thanks, Enric > Thanks! > Maxime >
diff --git a/Documentation/devicetree/bindings/display/bridge/ps8640.txt b/Documentation/devicetree/bindings/display/bridge/ps8640.txt new file mode 100644 index 000000000000..7b13f92f7359 --- /dev/null +++ b/Documentation/devicetree/bindings/display/bridge/ps8640.txt @@ -0,0 +1,44 @@ +ps8640-bridge bindings + +Required properties: + - compatible: "parade,ps8640" + - reg: first page address of the bridge. + - sleep-gpios: OF device-tree gpio specification for PD pin. + - reset-gpios: OF device-tree gpio specification for reset pin. + - vdd12-supply: OF device-tree regulator specification for 1.2V power. + - vdd33-supply: OF device-tree regulator specification for 3.3V power. + - ports: The device node can contain video interface port nodes per + the video-interfaces bind[1]. For port@0,set the reg = <0> as + ps8640 dsi in and port@1,set the reg = <1> as ps8640 eDP out. + +Optional properties: + - mode-sel-gpios: OF device-tree gpio specification for mode-sel pin. +[1]: Documentation/devicetree/bindings/media/video-interfaces.txt + +Example: + edp-bridge@18 { + compatible = "parade,ps8640"; + reg = <0x18>; + sleep-gpios = <&pio 116 GPIO_ACTIVE_LOW>; + reset-gpios = <&pio 115 GPIO_ACTIVE_LOW>; + mode-sel-gpios = <&pio 92 GPIO_ACTIVE_HIGH>; + vdd12-supply = <&ps8640_fixed_1v2>; + vdd33-supply = <&mt6397_vgp2_reg>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + port@0 { + reg = <0>; + ps8640_in: endpoint { + remote-endpoint = <&dsi0_out>; + }; + }; + port@1 { + reg = <1>; + ps8640_out: endpoint { + remote-endpoint = <&panel_in>; + }; + }; + }; + };