| Message ID | 20191217212214.30722-1-pakki001@umn.edu (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 380f4589475393f343cc940a12e10c18558363d6 |
| Headers | show |
| Series | scsi: libfc: remove unnecessary assertion on ep variable | expand |
On 12/17/19 10:22 PM, Aditya Pakki wrote: > In ft_recv_write_data(), the pointer ep is dereferenced first and > then asserts for NULL. The patch removes the unnecessary assertion. > > Signed-off-by: Aditya Pakki <pakki001@umn.edu> > --- > drivers/target/tcm_fc/tfc_io.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/target/tcm_fc/tfc_io.c b/drivers/target/tcm_fc/tfc_io.c > index 1354a157e9af..6a38ff936389 100644 > --- a/drivers/target/tcm_fc/tfc_io.c > +++ b/drivers/target/tcm_fc/tfc_io.c > @@ -221,7 +221,6 @@ void ft_recv_write_data(struct ft_cmd *cmd, struct fc_frame *fp) > ep = fc_seq_exch(seq); > lport = ep->lp; > if (cmd->was_ddp_setup) { > - BUG_ON(!ep); > BUG_ON(!lport); > /* > * Since DDP (Large Rx offload) was setup for this request, > Reviewed-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes
Aditya, > In ft_recv_write_data(), the pointer ep is dereferenced first and > then asserts for NULL. The patch removes the unnecessary assertion. Applied to 5.6/scsi-queue, thanks!
diff --git a/drivers/target/tcm_fc/tfc_io.c b/drivers/target/tcm_fc/tfc_io.c index 1354a157e9af..6a38ff936389 100644 --- a/drivers/target/tcm_fc/tfc_io.c +++ b/drivers/target/tcm_fc/tfc_io.c @@ -221,7 +221,6 @@ void ft_recv_write_data(struct ft_cmd *cmd, struct fc_frame *fp) ep = fc_seq_exch(seq); lport = ep->lp; if (cmd->was_ddp_setup) { - BUG_ON(!ep); BUG_ON(!lport); /* * Since DDP (Large Rx offload) was setup for this request,
In ft_recv_write_data(), the pointer ep is dereferenced first and then asserts for NULL. The patch removes the unnecessary assertion. Signed-off-by: Aditya Pakki <pakki001@umn.edu> --- drivers/target/tcm_fc/tfc_io.c | 1 - 1 file changed, 1 deletion(-)