diff mbox series

usb: cdns3: gadget: Remove unneeded variable ret

Message ID 1576826378-4387-1-git-send-email-vulab@iscas.ac.cn (mailing list archive)
State Mainlined
Commit 8e1a20096bfbc1fc05f68abcb8cf20fc07dca8a1
Headers show
Series usb: cdns3: gadget: Remove unneeded variable ret | expand

Commit Message

Wentao Liang Dec. 20, 2019, 7:19 a.m. UTC 
Remove unneeded variable ret used to store return value,just return 0.

Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
 drivers/usb/cdns3/gadget.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Roger Quadros Dec. 23, 2019, 8:53 a.m. UTC | #1 
On 20/12/2019 09:19, Xu Wang wrote:
> Remove unneeded variable ret used to store return value,just return 0.
> 
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>

Acked-by: Roger Quadros <rogerq@ti.com>

> ---
>   drivers/usb/cdns3/gadget.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c
> index 4c1e755..73b75a3 100644
> --- a/drivers/usb/cdns3/gadget.c
> +++ b/drivers/usb/cdns3/gadget.c
> @@ -2389,7 +2389,6 @@ static int cdns3_gadget_udc_stop(struct usb_gadget *gadget)
>   	struct cdns3_endpoint *priv_ep;
>   	u32 bEndpointAddress;
>   	struct usb_ep *ep;
> -	int ret = 0;
>   	int val;
>   
>   	priv_dev->gadget_driver = NULL;
> @@ -2413,7 +2412,7 @@ static int cdns3_gadget_udc_stop(struct usb_gadget *gadget)
>   	writel(0, &priv_dev->regs->usb_ien);
>   	writel(USB_CONF_DEVDS, &priv_dev->regs->usb_conf);
>   
> -	return ret;
> +	return 0;
>   }
>   
>   static const struct usb_gadget_ops cdns3_gadget_ops = {
>
diff mbox series

Patch

diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c
index 4c1e755..73b75a3 100644
--- a/drivers/usb/cdns3/gadget.c
+++ b/drivers/usb/cdns3/gadget.c
@@ -2389,7 +2389,6 @@  static int cdns3_gadget_udc_stop(struct usb_gadget *gadget)
 	struct cdns3_endpoint *priv_ep;
 	u32 bEndpointAddress;
 	struct usb_ep *ep;
-	int ret = 0;
 	int val;
 
 	priv_dev->gadget_driver = NULL;
@@ -2413,7 +2412,7 @@  static int cdns3_gadget_udc_stop(struct usb_gadget *gadget)
 	writel(0, &priv_dev->regs->usb_ien);
 	writel(USB_CONF_DEVDS, &priv_dev->regs->usb_conf);
 
-	return ret;
+	return 0;
 }
 
 static const struct usb_gadget_ops cdns3_gadget_ops = {