| Message ID | 1577149107-30670-5-git-send-email-hayashi.kunihiko@socionext.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | spi: uniphier: Introduce DMA transfer mode | expand |
On Tue, Dec 24, 2019 at 09:58:26AM +0900, Kunihiko Hayashi wrote: > Add SPI_LOOP to the capabilities to support loopback mode. > master->min_speed_hz = DIV_ROUND_UP(clk_rate, SSI_MAX_CLK_DIVIDER); > - master->mode_bits = SPI_CPOL | SPI_CPHA | SPI_CS_HIGH | SPI_LSB_FIRST; > + master->mode_bits = SPI_CPOL | SPI_CPHA | SPI_CS_HIGH | SPI_LSB_FIRST | > + SPI_LOOP; I'd expect to see a matching change that configures the hardware in loopback mode when the driver is in SPI_MODE? There's nothing in the existing driver.
Hi Mark, Thanks for your comment. On Wed, 25 Dec 2019 18:01:42 +0000 <broonie@kernel.org> wrote: > On Tue, Dec 24, 2019 at 09:58:26AM +0900, Kunihiko Hayashi wrote: > > Add SPI_LOOP to the capabilities to support loopback mode. > > > master->min_speed_hz = DIV_ROUND_UP(clk_rate, SSI_MAX_CLK_DIVIDER); > > - master->mode_bits = SPI_CPOL | SPI_CPHA | SPI_CS_HIGH | SPI_LSB_FIRST; > > + master->mode_bits = SPI_CPOL | SPI_CPHA | SPI_CS_HIGH | SPI_LSB_FIRST | > > + SPI_LOOP; > > I'd expect to see a matching change that configures the hardware > in loopback mode when the driver is in SPI_MODE? There's nothing > in the existing driver. I see. When doing loopback test using spi-loopback-test.c, I thought 'loop_req=1' option was needed, however, the controller doesn't need it. We can ignore this patch. Thank you, --- Best Regards, Kunihiko Hayashi
diff --git a/drivers/spi/spi-uniphier.c b/drivers/spi/spi-uniphier.c index c4e3b96..caf0446 100644 --- a/drivers/spi/spi-uniphier.c +++ b/drivers/spi/spi-uniphier.c @@ -543,7 +543,8 @@ static int uniphier_spi_probe(struct platform_device *pdev) master->max_speed_hz = DIV_ROUND_UP(clk_rate, SSI_MIN_CLK_DIVIDER); master->min_speed_hz = DIV_ROUND_UP(clk_rate, SSI_MAX_CLK_DIVIDER); - master->mode_bits = SPI_CPOL | SPI_CPHA | SPI_CS_HIGH | SPI_LSB_FIRST; + master->mode_bits = SPI_CPOL | SPI_CPHA | SPI_CS_HIGH | SPI_LSB_FIRST | + SPI_LOOP; master->dev.of_node = pdev->dev.of_node; master->bus_num = pdev->id; master->bits_per_word_mask = SPI_BPW_RANGE_MASK(1, 32);
Add SPI_LOOP to the capabilities to support loopback mode. Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> --- drivers/spi/spi-uniphier.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)