| Message ID | 20191228040927.4800-1-redhairer.li@intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ca5d576620ebdc410869bedd56241981a2c28cb0 |
| Headers | show |
| Series | [1/1] ndctl, test: add UUID_LIBS for blk_namespaces/pmem_namespaces/device_dax | expand |
On Fri, Dec 27, 2019 at 8:09 PM redhairer <redhairer.li@intel.com> wrote: > > Some environments automatically include the missing library dependency, > and others need it to be explicitly included. > > Signed-off-by: Redhairer Li <redhairer.li@intel.com> Looks good, applied. > test/Makefile.am | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/test/Makefile.am b/test/Makefile.am > index 829146d..a13440e 100644 > --- a/test/Makefile.am > +++ b/test/Makefile.am > @@ -98,10 +98,10 @@ ack_shutdown_count_set_SOURCES =\ > ack_shutdown_count_set_LDADD = $(LIBNDCTL_LIB) $(KMOD_LIBS) > > blk_ns_SOURCES = blk_namespaces.c $(testcore) > -blk_ns_LDADD = $(LIBNDCTL_LIB) $(KMOD_LIBS) > +blk_ns_LDADD = $(LIBNDCTL_LIB) $(KMOD_LIBS) $(UUID_LIBS) > > pmem_ns_SOURCES = pmem_namespaces.c $(testcore) > -pmem_ns_LDADD = $(LIBNDCTL_LIB) $(KMOD_LIBS) > +pmem_ns_LDADD = $(LIBNDCTL_LIB) $(KMOD_LIBS) $(UUID_LIBS) > > dpa_alloc_SOURCES = dpa-alloc.c $(testcore) > dpa_alloc_LDADD = $(LIBNDCTL_LIB) $(UUID_LIBS) $(KMOD_LIBS) > @@ -143,6 +143,7 @@ device_dax_LDADD = \ > $(LIBNDCTL_LIB) \ > $(KMOD_LIBS) \ > $(JSON_LIBS) \ > + $(UUID_LIBS) \ > ../libutil.a > > smart_notify_SOURCES = smart-notify.c > -- > 2.20.1.windows.1 >
diff --git a/test/Makefile.am b/test/Makefile.am index 829146d..a13440e 100644 --- a/test/Makefile.am +++ b/test/Makefile.am @@ -98,10 +98,10 @@ ack_shutdown_count_set_SOURCES =\ ack_shutdown_count_set_LDADD = $(LIBNDCTL_LIB) $(KMOD_LIBS) blk_ns_SOURCES = blk_namespaces.c $(testcore) -blk_ns_LDADD = $(LIBNDCTL_LIB) $(KMOD_LIBS) +blk_ns_LDADD = $(LIBNDCTL_LIB) $(KMOD_LIBS) $(UUID_LIBS) pmem_ns_SOURCES = pmem_namespaces.c $(testcore) -pmem_ns_LDADD = $(LIBNDCTL_LIB) $(KMOD_LIBS) +pmem_ns_LDADD = $(LIBNDCTL_LIB) $(KMOD_LIBS) $(UUID_LIBS) dpa_alloc_SOURCES = dpa-alloc.c $(testcore) dpa_alloc_LDADD = $(LIBNDCTL_LIB) $(UUID_LIBS) $(KMOD_LIBS) @@ -143,6 +143,7 @@ device_dax_LDADD = \ $(LIBNDCTL_LIB) \ $(KMOD_LIBS) \ $(JSON_LIBS) \ + $(UUID_LIBS) \ ../libutil.a smart_notify_SOURCES = smart-notify.c
Some environments automatically include the missing library dependency, and others need it to be explicitly included. Signed-off-by: Redhairer Li <redhairer.li@intel.com> --- test/Makefile.am | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)