| Message ID | 20200103055608.22491-1-nramas@linux.microsoft.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | IMA: Deferred measurement of keys | expand |
Hi Lakshmi, Instead of loosing the cover letter, Jonathan Corbet suggested including it as the merge comment. I'd like to do that with this cover letter. On Thu, 2020-01-02 at 21:56 -0800, Lakshmi Ramasubramanian wrote: > This patchset extends the previous version[1] by adding support for > deferred processing of keys. > > With the patchset referenced above, the IMA subsystem supports > measuring asymmetric keys when the key is created or updated. The first sentence and the clause of the next sentence are unnecessary. I would begin the cover letter with "The IMA subsystem supports" and add the reference afterwards. > But keys created or updated before a custom IMA policy is loaded > are currently not measured. This includes keys added to, for instance, > .builtin_trusted_keys which happens early in the boot process. Let's not limit the example to just the .builtin_trusted_keys keyring. Please update it as: This includes keys added, for instance, to either the .ima or .builtin_trusted_keys keyrings, which happens early in the boot process. > > This change adds support for queuing keys created or updated before > a custom IMA policy is loaded. The queued keys are processed when > a custom policy is loaded. Keys created or updated after a custom policy > is loaded are measured immediately (not queued). > > If the kernel is built with both CONFIG_IMA and > CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE enabled then the IMA policy > must be applied as a custom policy for the keys to be measured. > If a custom IMA policy is not provided within 5 minutes after > IMA is initialized, any queued keys will be freed. As the merge message, this is too much information. I would extend the previous paragraph and drop this one, like: "... (not queued). In the case when a custom policy is not loaded within 5 minutes of IMA initialization, the queued keys are freed." > This is by design. It's unclear what "is by design" refers to. Perhaps expand this sentence like: "Measuring the early boot keys, by design, requires loading a custom policy. > > [1] https://lore.kernel.org/linux-integrity/20191211164707.4698-1-nramas@linux.microsoft.com/ thanks, Mimi
On Fri, 2020-01-03 at 10:08 -0500, Mimi Zohar wrote: > > This change adds support for queuing keys created or updated before > > a custom IMA policy is loaded. The queued keys are processed when > > a custom policy is loaded. Keys created or updated after a custom policy > > is loaded are measured immediately (not queued). > > > > If the kernel is built with both CONFIG_IMA and > > CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE enabled then the IMA policy > > must be applied as a custom policy for the keys to be measured. > > If a custom IMA policy is not provided within 5 minutes after > > IMA is initialized, any queued keys will be freed. > > As the merge message, this is too much information. I would extend > the previous paragraph and drop this one, like: > "... (not queued). In the case when a custom policy is not loaded > within 5 minutes of IMA initialization, the queued keys are freed." > > > This is by design. > > It's unclear what "is by design" refers to. Perhaps expand this > sentence like: "Measuring the early boot keys, by design, requires > loading a custom policy. Instead of including this comment as the last sentence of the cover letter, it would make a good opening sentence for the second paragraph. Mimi
This patchset extends the previous version[1] by adding support for deferred processing of keys. With the patchset referenced above, the IMA subsystem supports measuring asymmetric keys when the key is created or updated. But keys created or updated before a custom IMA policy is loaded are currently not measured. This includes keys added to, for instance, .builtin_trusted_keys which happens early in the boot process. This change adds support for queuing keys created or updated before a custom IMA policy is loaded. The queued keys are processed when a custom policy is loaded. Keys created or updated after a custom policy is loaded are measured immediately (not queued). If the kernel is built with both CONFIG_IMA and CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE enabled then the IMA policy must be applied as a custom policy for the keys to be measured. If a custom IMA policy is not provided within 5 minutes after IMA is initialized, any queued keys will be freed. This is by design. [1] https://lore.kernel.org/linux-integrity/20191211164707.4698-1-nramas@linux.microsoft.com/ Testing performed: * Ran kernel self-test following the instructions given in https://www.kernel.org/doc/Documentation/kselftest.txt * Ran the lkp-tests using the job script provided by kernel test robot <rong.a.chen@intel.com> * Booted the kernel with this change. * Added .builtin_trusted_keys in "keyrings=" option in the IMA policy and verified the keys added to this keyring are measured. * Specified only func=KEY_CHECK and not "keyrings=" option, and verified the keys added to builtin_trusted_keys keyring are processed. * Added keys at runtime and verified they are measured if the IMA policy permitted. => For example, added keys to .ima keyring and verified. Changelog: v6 => Replaced mutex with a spinlock to sychronize access to queued keys. This fixes the problem reported by "kernel test robot <rong.a.chen@intel.com>" https://lore.kernel.org/linux-integrity/2a831fe9-30e5-63b4-af10-a69f327f7fb7@linux.microsoft.com/T/#t => Changed ima_queue_key() to a static function. This fixes the issue reported by "kbuild test robot <lkp@intel.com>" https://lore.kernel.org/linux-integrity/1577370464.4487.10.camel@linux.ibm.com/ => Added the patch to free the queued keys if a custom IMA policy was not loaded to this patch set. v5 => Removed temp keys list in ima_process_queued_keys() v4 => Check and set ima_process_keys flag with mutex held. v3 => Defined ima_process_keys flag to be static. => Set ima_process_keys with ima_keys_mutex held. => Added a comment in ima_process_queued_keys() function to state the use of temporary list for keys. v2 => Rebased the changes to v5.5-rc1 => Updated function names, variable names, and code comments to be less verbose. v1 => Code cleanup v0 => Based changes on v5.4-rc8 => The following patchsets should be applied in that order https://lore.kernel.org/linux-integrity/1572492694-6520-1-git-send-email-zohar@linux.ibm.com https://lore.kernel.org/linux-integrity/20191204224131.3384-1-nramas@linux.microsoft.com/ => Added functions to queue and dequeue keys, and process the queued keys when custom IMA policies are applied. Lakshmi Ramasubramanian (3): IMA: Define workqueue for early boot key measurements IMA: Call workqueue functions to measure queued keys IMA: Defined timer to free queued keys security/integrity/ima/ima.h | 17 ++ security/integrity/ima/ima_asymmetric_keys.c | 159 +++++++++++++++++++ security/integrity/ima/ima_init.c | 8 +- security/integrity/ima/ima_policy.c | 3 + 4 files changed, 186 insertions(+), 1 deletion(-)