[v1,0/3] scsi: ufs: pass device information to apply_dev_quirks

Message

Stanley Chu Jan. 5, 2020, 4:55 a.m. UTC

Currently UFS driver has "global" device quirk scheme to allow driver applying
special handling for certain UFS devive models.

However some special device handlings are required for specific UFS hosts only
so it is better to make it happen in vendor's callbacks only to not "pollute"
common driver and common device quirks.

We already have apply_dev_quirks variant callback for vendors but lack of device
information for handling specific UFS device models. This series provides such
information to apply_dev_quirks callbacks, and applies related modifications.

Stanley Chu (3):
  scsi: ufs: pass device information to apply_dev_quirks
  scsi: ufs-qcom: modify apply_dev_quirks interface
  scsi: ufs-mediatek: add apply_dev_quirks variant operation

 drivers/scsi/ufs/ufs-mediatek.c | 11 +++++++++++
 drivers/scsi/ufs/ufs-qcom.c     |  3 ++-
 drivers/scsi/ufs/ufshcd.c       |  5 +++--
 drivers/scsi/ufs/ufshcd.h       |  7 ++++---
 4 files changed, 20 insertions(+), 6 deletions(-)

Comments

Avri Altman Jan. 5, 2020, 5:51 a.m. UTC | #1

You have to squash patch 1 & 2, otherwise your patch 1 won't compile.
Other than that: looks good to me.
Thanks,
Avri

Stanley Chu Jan. 5, 2020, 1:10 p.m. UTC | #2

Hi Avri,

On Sun, 2020-01-05 at 05:51 +0000, Avri Altman wrote:
> You have to squash patch 1 & 2, otherwise your patch 1 won't compile.
> Other than that: looks good to me.
> Thanks,
> Avri

Sorry because I sent 2 series in these two days.

Would you mean patch 1 is series: "scsi: ufs: fix error history and
complete device reset history" and patch 2 is series "scsi: ufs: pass
device information to apply_dev_quirks"?

Or patch 1 & 2 mean the first 2 commits in this series: "scsi: ufs: pass
device information to apply_dev_quirks"?

Thanks a lot.
Stanley

Avri Altman Jan. 5, 2020, 4:40 p.m. UTC | #3

> Hi Avri,
> 
> On Sun, 2020-01-05 at 05:51 +0000, Avri Altman wrote:
> > You have to squash patch 1 & 2, otherwise your patch 1 won't compile.
> > Other than that: looks good to me.
> > Thanks,
> > Avri
> 
> Sorry because I sent 2 series in these two days.
> 
> Would you mean patch 1 is series: "scsi: ufs: fix error history and complete
> device reset history" and patch 2 is series "scsi: ufs: pass device information to
> apply_dev_quirks"?
> 
> Or patch 1 & 2 mean the first 2 commits in this series: "scsi: ufs: pass device
> information to apply_dev_quirks"?
This one.

> 
> Thanks a lot.
> Stanley

Stanley Chu Jan. 6, 2020, 12:26 a.m. UTC | #4

Hi Avri,

On Sun, 2020-01-05 at 16:40 +0000, Avri Altman wrote:
> > Hi Avri,
> > 
> > On Sun, 2020-01-05 at 05:51 +0000, Avri Altman wrote:
> > > You have to squash patch 1 & 2, otherwise your patch 1 won't compile.
> > > Other than that: looks good to me.
> > > Thanks,
> > > Avri
> > 
> > Sorry because I sent 2 series in these two days.
> > 
> > Would you mean patch 1 is series: "scsi: ufs: fix error history and complete
> > device reset history" and patch 2 is series "scsi: ufs: pass device information to
> > apply_dev_quirks"?
> > 
> > Or patch 1 & 2 mean the first 2 commits in this series: "scsi: ufs: pass device
> > information to apply_dev_quirks"?
> This one.

OK! I will send the updated v2.

> 
> > 
> > Thanks a lot.
> > Stanley

Thanks,
Stanley