| Message ID | 20200106110133.13791-9-faiz_abbas@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Port am335x and am437x devices to sdhci-omap | expand |
On Mon, Jan 06, 2020 at 04:31:30PM +0530, Faiz Abbas wrote: > Some controllers need a special software reset sequence. Document the > ti,needs-special-reset binding to indicate that a controller needs this. > > Signed-off-by: Faiz Abbas <faiz_abbas@ti.com> > --- > Documentation/devicetree/bindings/mmc/sdhci-omap.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-omap.txt b/Documentation/devicetree/bindings/mmc/sdhci-omap.txt > index 97efb01617dd..0f5389c72bda 100644 > --- a/Documentation/devicetree/bindings/mmc/sdhci-omap.txt > +++ b/Documentation/devicetree/bindings/mmc/sdhci-omap.txt > @@ -21,6 +21,7 @@ Optional properties: > - dma-names: List of DMA request names. These strings correspond 1:1 with the > DMA specifiers listed in dmas. The string naming is to be "tx" > and "rx" for TX and RX DMA requests, respectively. > +- ti,needs-special-reset: Requires a special softreset sequence Why can't this be implied by the compatible string? Rob
Hi Rob, On 07/01/20 3:33 am, Rob Herring wrote: > On Mon, Jan 06, 2020 at 04:31:30PM +0530, Faiz Abbas wrote: >> Some controllers need a special software reset sequence. Document the >> ti,needs-special-reset binding to indicate that a controller needs this. >> >> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com> >> --- >> Documentation/devicetree/bindings/mmc/sdhci-omap.txt | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-omap.txt b/Documentation/devicetree/bindings/mmc/sdhci-omap.txt >> index 97efb01617dd..0f5389c72bda 100644 >> --- a/Documentation/devicetree/bindings/mmc/sdhci-omap.txt >> +++ b/Documentation/devicetree/bindings/mmc/sdhci-omap.txt >> @@ -21,6 +21,7 @@ Optional properties: >> - dma-names: List of DMA request names. These strings correspond 1:1 with the >> DMA specifiers listed in dmas. The string naming is to be "tx" >> and "rx" for TX and RX DMA requests, respectively. >> +- ti,needs-special-reset: Requires a special softreset sequence > > Why can't this be implied by the compatible string? > You are right. We can assign the special_reset flag in the next patch using compatible as well. Will drop this patch in next version. Thanks, Faiz
diff --git a/Documentation/devicetree/bindings/mmc/sdhci-omap.txt b/Documentation/devicetree/bindings/mmc/sdhci-omap.txt index 97efb01617dd..0f5389c72bda 100644 --- a/Documentation/devicetree/bindings/mmc/sdhci-omap.txt +++ b/Documentation/devicetree/bindings/mmc/sdhci-omap.txt @@ -21,6 +21,7 @@ Optional properties: - dma-names: List of DMA request names. These strings correspond 1:1 with the DMA specifiers listed in dmas. The string naming is to be "tx" and "rx" for TX and RX DMA requests, respectively. +- ti,needs-special-reset: Requires a special softreset sequence Example: mmc1: mmc@4809c000 {
Some controllers need a special software reset sequence. Document the ti,needs-special-reset binding to indicate that a controller needs this. Signed-off-by: Faiz Abbas <faiz_abbas@ti.com> --- Documentation/devicetree/bindings/mmc/sdhci-omap.txt | 1 + 1 file changed, 1 insertion(+)