| Message ID | 20191219103153.14875-9-srinivas.kandagatla@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ASoC: Add support to WCD9340/WCD9341 codec | expand |
On Thu, Dec 19, 2019 at 11:33 AM Srinivas Kandagatla <srinivas.kandagatla@linaro.org> wrote: > Qualcomm Technologies Inc WCD9340/WCD9341 Audio Codec has integrated > gpio controller to control 5 gpios on the chip. This patch adds > required device tree bindings for it. > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > Reviewed-by: Rob Herring <robh@kernel.org> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Tell me if you want me to merge this patch through the GPIO tree. Yours, Linus Walleij
On 07/01/2020 09:47, Linus Walleij wrote: > On Thu, Dec 19, 2019 at 11:33 AM Srinivas Kandagatla > <srinivas.kandagatla@linaro.org> wrote: > >> Qualcomm Technologies Inc WCD9340/WCD9341 Audio Codec has integrated >> gpio controller to control 5 gpios on the chip. This patch adds >> required device tree bindings for it. >> >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> >> Reviewed-by: Rob Herring <robh@kernel.org> > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > Tell me if you want me to merge this patch through the GPIO tree. > Yes that would be great!. gpio bindings and gpio driver can go via gpio tree as there is no compile time dependency. Also Mark has already merged the audio codec side of it. I will address the comments on the driver and send new version of these 2 patches. Thanks, srini > Yours, > Linus Walleij >
On Tue, Jan 7, 2020 at 4:17 AM Srinivas Kandagatla <srinivas.kandagatla@linaro.org> wrote: > > > > On 07/01/2020 09:47, Linus Walleij wrote: > > On Thu, Dec 19, 2019 at 11:33 AM Srinivas Kandagatla > > <srinivas.kandagatla@linaro.org> wrote: > > > >> Qualcomm Technologies Inc WCD9340/WCD9341 Audio Codec has integrated > >> gpio controller to control 5 gpios on the chip. This patch adds > >> required device tree bindings for it. > >> > >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > >> Reviewed-by: Rob Herring <robh@kernel.org> > > > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > > > Tell me if you want me to merge this patch through the GPIO tree. > > > Yes that would be great!. gpio bindings and gpio driver can go via gpio > tree as there is no compile time dependency. Also Mark has already > merged the audio codec side of it. But there is a dependency because dt_binding_check is now broken as the codec schema references this GPIO schema. Not much to do about this now other than get the GPIO schema into -next. Rob
diff --git a/Documentation/devicetree/bindings/gpio/qcom,wcd934x-gpio.yaml b/Documentation/devicetree/bindings/gpio/qcom,wcd934x-gpio.yaml new file mode 100644 index 000000000000..32a566ec3558 --- /dev/null +++ b/Documentation/devicetree/bindings/gpio/qcom,wcd934x-gpio.yaml @@ -0,0 +1,47 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/gpio/qcom,wcd934x-gpio.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: WCD9340/WCD9341 GPIO controller + +maintainers: + - Srinivas Kandagatla <srinivas.kandagatla@linaro.org> + +description: | + Qualcomm Technologies Inc WCD9340/WCD9341 Audio Codec has integrated + gpio controller to control 5 gpios on the chip. + +properties: + compatible: + enum: + - qcom,wcd9340-gpio + - qcom,wcd9341-gpio + + reg: + maxItems: 1 + + gpio-controller: true + + '#gpio-cells': + const: 2 + +required: + - compatible + - reg + - gpio-controller + - "#gpio-cells" + +additionalProperties: false + +examples: + - | + wcdgpio: gpio@42 { + compatible = "qcom,wcd9340-gpio"; + reg = <0x042 0x2>; + gpio-controller; + #gpio-cells = <2>; + }; + +...