| Message ID | 20200103215039.27471-1-giulio.benetti@benettiengineering.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | silence some warning in rpcgen | expand |
On 1/3/20 4:50 PM, Giulio Benetti wrote: > Since I'm trying to bump version of nfs-utils to latest in Buildroot, I've > noticed some warning in rpcgen, so I've decided to clean them up by fixing > code or #pragma ignoring them. Hope this is useful. Other warnings are > still there waiting to be fixed and if you find these patches useful I'm > going to complete all warning correction. > > Giulio Benetti (7): > rpcgen: rpc_cout: silence unused def parameter > rpcgen: rpc_util: add storeval args to prototype > rpcgen: rpc_util: add findval args to prototype > rpcgen: rpc_parse: add get_definition() void argument > rpcgen: rpc_cout: fix potential -Wformat-nonliteral warning > rpcgen: rpc_hout: fix potential -Wformat-security warning > rpcgen: rpc_hout: fix indentation on f_print() argument separator > > tools/rpcgen/rpc_cout.c | 8 ++++---- > tools/rpcgen/rpc_hout.c | 4 +++- > tools/rpcgen/rpc_parse.h | 2 +- > tools/rpcgen/rpc_util.h | 4 ++-- > 4 files changed, 10 insertions(+), 8 deletions(-) > Committed (tag: nfs-utils-2-4-3-rc5) I must admit this code is actually being used... I assume they do the right thing... The rpcgen we been using is the old one that came out of the glibc code at https://github.com/thkukuk/rpcsvc-proto I wonder what the difference is.... steved.
On 1/7/20 8:06 PM, Steve Dickson wrote: > > > On 1/3/20 4:50 PM, Giulio Benetti wrote: >> Since I'm trying to bump version of nfs-utils to latest in Buildroot, I've >> noticed some warning in rpcgen, so I've decided to clean them up by fixing >> code or #pragma ignoring them. Hope this is useful. Other warnings are >> still there waiting to be fixed and if you find these patches useful I'm >> going to complete all warning correction. >> >> Giulio Benetti (7): >> rpcgen: rpc_cout: silence unused def parameter >> rpcgen: rpc_util: add storeval args to prototype >> rpcgen: rpc_util: add findval args to prototype >> rpcgen: rpc_parse: add get_definition() void argument >> rpcgen: rpc_cout: fix potential -Wformat-nonliteral warning >> rpcgen: rpc_hout: fix potential -Wformat-security warning >> rpcgen: rpc_hout: fix indentation on f_print() argument separator >> >> tools/rpcgen/rpc_cout.c | 8 ++++---- >> tools/rpcgen/rpc_hout.c | 4 +++- >> tools/rpcgen/rpc_parse.h | 2 +- >> tools/rpcgen/rpc_util.h | 4 ++-- >> 4 files changed, 10 insertions(+), 8 deletions(-) >> > Committed (tag: nfs-utils-2-4-3-rc5) > > I must admit this code is actually being used... I assume they do the right thing... > > The rpcgen we been using is the old one that came out > of the glibc code at https://github.com/thkukuk/rpcsvc-proto > > I wonder what the difference is.... I can check it and use that one as upstream maybe and update it here in nfs-utils if you see that it makes sense. Best regards
On 1/9/20 9:00 AM, Giulio Benetti wrote: > On 1/7/20 8:06 PM, Steve Dickson wrote: >> >> >> On 1/3/20 4:50 PM, Giulio Benetti wrote: >>> Since I'm trying to bump version of nfs-utils to latest in Buildroot, I've >>> noticed some warning in rpcgen, so I've decided to clean them up by fixing >>> code or #pragma ignoring them. Hope this is useful. Other warnings are >>> still there waiting to be fixed and if you find these patches useful I'm >>> going to complete all warning correction. >>> >>> Giulio Benetti (7): >>> rpcgen: rpc_cout: silence unused def parameter >>> rpcgen: rpc_util: add storeval args to prototype >>> rpcgen: rpc_util: add findval args to prototype >>> rpcgen: rpc_parse: add get_definition() void argument >>> rpcgen: rpc_cout: fix potential -Wformat-nonliteral warning >>> rpcgen: rpc_hout: fix potential -Wformat-security warning >>> rpcgen: rpc_hout: fix indentation on f_print() argument separator >>> >>> tools/rpcgen/rpc_cout.c | 8 ++++---- >>> tools/rpcgen/rpc_hout.c | 4 +++- >>> tools/rpcgen/rpc_parse.h | 2 +- >>> tools/rpcgen/rpc_util.h | 4 ++-- >>> 4 files changed, 10 insertions(+), 8 deletions(-) >>> >> Committed (tag: nfs-utils-2-4-3-rc5) >> >> I must admit this code is actually being used... I assume they do the right thing... >> >> The rpcgen we been using is the old one that came out >> of the glibc code at https://github.com/thkukuk/rpcsvc-proto >> >> I wonder what the difference is.... > > I can check it and use that one as upstream maybe and update it here in nfs-utils if you see that it makes sense. That would be interest... If they both generate the same code... two are probably not needed... but I bet either code base as not changed in 40 yrs ;-) steved. > > Best regards