mbox series

[v2,0/3] usb: dwc3: gadget: Improve END_TRANSFER handling

Message ID cover.1576715470.git.thinhn@synopsys.com (mailing list archive)
Headers show
Series usb: dwc3: gadget: Improve END_TRANSFER handling | expand

Message

Thinh Nguyen Dec. 19, 2019, 2:14 a.m. UTC 
This patch series improves the handling of the END_TRANSFER command:

1) Don't issue multiple END_TRANSFER commands while the previous hasn't
   completed
2) Don't issue START_TRANSFER command while END_TRANSFER hasn't completed
3) Remove arbitrary 100us delay

Changes in v2:
 - Remove unused variable


Thinh Nguyen (3):
  usb: dwc3: gadget: Check END_TRANSFER completion
  usb: dwc3: gadget: Delay starting transfer
  usb: dwc3: gadget: Remove END_TRANSFER delay

 drivers/usb/dwc3/core.h   |  2 ++
 drivers/usb/dwc3/ep0.c    |  4 +++-
 drivers/usb/dwc3/gadget.c | 35 +++++++++++++++++++++--------------
 3 files changed, 26 insertions(+), 15 deletions(-)

Comments

Felipe Balbi Jan. 9, 2020, 11:30 a.m. UTC | #1 
Hi,

Thinh Nguyen <Thinh.Nguyen@synopsys.com> writes:
> This patch series improves the handling of the END_TRANSFER command:
>
> 1) Don't issue multiple END_TRANSFER commands while the previous hasn't
>    completed
> 2) Don't issue START_TRANSFER command while END_TRANSFER hasn't completed
> 3) Remove arbitrary 100us delay
>
> Changes in v2:
>  - Remove unused variable

Tried applying these, but it failed on patch 1.
Thinh Nguyen Jan. 9, 2020, 7:31 p.m. UTC | #2 
Hi Felipe,

Felipe Balbi wrote:
> Hi,
>
> Thinh Nguyen <Thinh.Nguyen@synopsys.com> writes:
>> This patch series improves the handling of the END_TRANSFER command:
>>
>> 1) Don't issue multiple END_TRANSFER commands while the previous hasn't
>>     completed
>> 2) Don't issue START_TRANSFER command while END_TRANSFER hasn't completed
>> 3) Remove arbitrary 100us delay
>>
>> Changes in v2:
>>   - Remove unused variable
> Tried applying these, but it failed on patch 1.
>

Your next branch doesn't have these prerequisite patches from mainline:
d3abda5a98a1 ("usb: dwc3: gadget: Clear started flag for non-IOC")
2d7b78f59e02 ("usb: dwc3: ep0: Clear started flag on completion")

Will you rebase on v5.5 rc-x? Let me know how we can proceed to resolve 
the conflict.

Also, have you a chance to take a look at these patches:
https://patchwork.kernel.org/project/linux-usb/list/?series=214669
* usb: dwc3: gadget: Properly set maxpacket limit
* usb: dwc3: Fix GTXFIFOSIZ.TXFDEP macro name


Thanks!
Thinh
Felipe Balbi Jan. 15, 2020, 8:52 a.m. UTC | #3 
Hi,

Thinh Nguyen <Thinh.Nguyen@synopsys.com> writes:
>> Thinh Nguyen <Thinh.Nguyen@synopsys.com> writes:
>>> This patch series improves the handling of the END_TRANSFER command:
>>>
>>> 1) Don't issue multiple END_TRANSFER commands while the previous hasn't
>>>     completed
>>> 2) Don't issue START_TRANSFER command while END_TRANSFER hasn't completed
>>> 3) Remove arbitrary 100us delay
>>>
>>> Changes in v2:
>>>   - Remove unused variable
>> Tried applying these, but it failed on patch 1.
>>
>
> Your next branch doesn't have these prerequisite patches from mainline:
> d3abda5a98a1 ("usb: dwc3: gadget: Clear started flag for non-IOC")
> 2d7b78f59e02 ("usb: dwc3: ep0: Clear started flag on completion")
>
> Will you rebase on v5.5 rc-x? Let me know how we can proceed to resolve 
> the conflict.
>
> Also, have you a chance to take a look at these patches:
> https://patchwork.kernel.org/project/linux-usb/list/?series=214669
> * usb: dwc3: gadget: Properly set maxpacket limit
> * usb: dwc3: Fix GTXFIFOSIZ.TXFDEP macro name

indeed, now they've applied cleanly. Thanks