| Message ID | 20191219121905.26905-1-cristian.marussi@arm.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Unify SMP stop generic logic to common code | expand |
On Thu, Dec 19, 2019 at 12:18:53PM +0000, Cristian Marussi wrote: > the logic underlying SMP stop and kexec crash procedures, beside containing > some arch-specific bits, is mostly generic and common across all archs: > despite this fact, such logic is now scattered across all architectures and > on some of them is flawed, in such a way that, under some specific > conditions, you can end up with a CPU left still running after a panic and > possibly lost across a subsequent kexec crash reboot. [1] Is this still the case even after 20bb759a66be ("panic: ensure preemption is disabled during panic()")? Will
Hi Will On 13/01/2020 16:40, Will Deacon wrote: > On Thu, Dec 19, 2019 at 12:18:53PM +0000, Cristian Marussi wrote: >> the logic underlying SMP stop and kexec crash procedures, beside containing >> some arch-specific bits, is mostly generic and common across all archs: >> despite this fact, such logic is now scattered across all architectures and >> on some of them is flawed, in such a way that, under some specific >> conditions, you can end up with a CPU left still running after a panic and >> possibly lost across a subsequent kexec crash reboot. [1] > > Is this still the case even after 20bb759a66be ("panic: ensure preemption is > disabled during panic()")? > v3 is based on 5.5-rc2 which seems to include 20bb759a66be, and when I tested before re-posting a few weeks ago it was still failing as usual, i.e. kernel still alive after panic. [but please be aware that to reproduce it, you need to have only one core online and another one panicing while starting up (while still marked offline)] Thanks Cristian
Hi all, the logic underlying SMP stop and kexec crash procedures, beside containing some arch-specific bits, is mostly generic and common across all archs: despite this fact, such logic is now scattered across all architectures and on some of them is flawed, in such a way that, under some specific conditions, you can end up with a CPU left still running after a panic and possibly lost across a subsequent kexec crash reboot. [1] Beside the flaws on some archs, there is anyway lots of code duplication, so this patch series attempts to move into common code all the generic SMP stop and crash logic, fixing observed issues, and leaving only the arch specific bits inside properly provided arch-specific helpers. An architecture willing to rely on this SMP common logic has to define its own helpers and set CONFIG_ARCH_USE_COMMON_SMP_STOP=y. This series initially wires this up for arm64, x86, arm, sparc64. Behaviour is not changed for architectures not adopting this new common logic. In v2/v3 the SMP common stop/crash code is generalized a bit more to address the needs of the newly ported architectures (x86, arm, sparc64). Tested as follows: - arm64 (FVP/JUNO 4-cpus): 1. boot/reboot -f 2. emergency reboot - sysrq(b) 3. kcrash - sysrq(c) 4. kcrash - sysrq(c) with a loaded crashkernel (kdump reboot) 5. panic on a starting CPU on a 2 CPUs only system (freezing properly) 6. kdump reboot after a panic like 5. (not losing any CPU on reboot) 7. kdump reboot after a panic like 5. plus a simultaneous reboot (instrumenting code to delay the stop messages transmission to have time to inject a reboot -f -- not losing any CPU on reboot) 8. kexec reboot (4 cpus on reboot) - x86 (QEMU virt 4-cpus): 1. boot/reboot -f 2. emergency reboot - sysrq(b) 3. kcrash - sysrq(c) 4. kcrash - sysrq(c) with a loaded crashkernel (kdump reboot) 5. panic on a starting CPU on a 2 CPUs only system (freezing properly) 6. kdump reboot after a panic like 5. (maxcpus=1 on x86-crashkernel) 7. kdump reboot after a panic like 5. plus a simultaneous reboot (instrumenting code to delay the stop messages transmission to have time to inject a reboot -f - maxcpus=1 anyway on x86 on crashkernel) 8. kexec reboot (4 cpus on reboot) 9. emergency reboot - sysrq(b) with VMX enabled - arm (QEMU virt 4-cpus): 1. boot/reboot -f 2. emergency reboot - sysrq(b) 3. kcrash - sysrq(c) 4. kcrash - sysrq(c) with a loaded crashkernel (kdump reboot) 5. panic on a starting CPU on a 2 CPUs only system (freezing properly) 6. kdump reboot after a panic like 5. (1-cpus on crashkernel reboot) 7. kexec reboot (4 cpus on reboot) - sparc64: 1. build & boot Any thoughts ? Thanks, Cristian Changes: -------- v2-->v3: - rebased on v5.5-rc2 - fixed get/set helpers introduced broken in v2 - x86: reviewed orce reboot handling - x86: simplified SMPSTOP arch helpers - arm: added missing barriers in SMP stop new helper - arm: fixed missing preemption enable/disable v1-->v2: - rebased on v5.3-rc8 - moved common Kconfig bits to arch/Kconfig - extended SMP common stop/crash generic code to address new architectures needs: custom wait/timeouts, max_retries, attempt numbers. - ported x86 to SMP common stop/crash code - ported arm to SMP common stop/crash code - ported sparc64 to SMP common stop code [1] [root@arch ~]# echo 1 > /sys/devices/system/cpu/cpu1/online [root@arch ~]# [ 152.583368] ------------[ cut here ]------------ [ 152.583872] kernel BUG at arch/arm64/kernel/cpufeature.c:852! [ 152.584693] Internal error: Oops - BUG: 0 [#1] PREEMPT SMP [ 152.585228] Modules linked in: [ 152.586040] CPU: 1 PID: 0 Comm: swapper/1 Not tainted 5.3.0-rc5-00001-gcabd12118c4a-dirty #2 [ 152.586218] Hardware name: Foundation-v8A (DT) [ 152.586478] pstate: 000001c5 (nzcv dAIF -PAN -UAO) [ 152.587260] pc : has_cpuid_feature+0x35c/0x360 [ 152.587398] lr : verify_local_elf_hwcaps+0x6c/0xf0 [ 152.587520] sp : ffff0000118bbf60 [ 152.587605] x29: ffff0000118bbf60 x28: 0000000000000000 [ 152.587784] x27: 0000000000000000 x26: 0000000000000000 [ 152.587882] x25: ffff00001167a010 x24: ffff0000112f59f8 [ 152.587992] x23: 0000000000000000 x22: 0000000000000000 [ 152.588085] x21: ffff0000112ea018 x20: ffff000010fe5518 [ 152.588180] x19: ffff000010ba3f30 x18: 0000000000000036 [ 152.588285] x17: 0000000000000000 x16: 0000000000000000 [ 152.588380] x15: 0000000000000000 x14: ffff80087a821210 [ 152.588481] x13: 0000000000000000 x12: 0000000000000000 [ 152.588599] x11: 0000000000000080 x10: 00400032b5503510 [ 152.588709] x9 : 0000000000000000 x8 : ffff000010b93204 [ 152.588810] x7 : 00000000800001d8 x6 : 0000000000000005 [ 152.588910] x5 : 0000000000000000 x4 : 0000000000000000 [ 152.589021] x3 : 0000000000000000 x2 : 0000000000008000 [ 152.589121] x1 : 0000000000180480 x0 : 0000000000180480 [ 152.589379] Call trace: [ 152.589646] has_cpuid_feature+0x35c/0x360 [ 152.589763] verify_local_elf_hwcaps+0x6c/0xf0 [ 152.589858] check_local_cpu_capabilities+0x88/0x118 [ 152.589968] secondary_start_kernel+0xc4/0x168 [ 152.590530] Code: d53801e0 17ffff58 d5380600 17ffff56 (d4210000) [ 152.592215] ---[ end trace 80ea98416149c87e ]--- [ 152.592734] Kernel panic - not syncing: Attempted to kill the idle task! [ 152.593173] Kernel Offset: disabled [ 152.593501] CPU features: 0x0004,20c02008 [ 152.593678] Memory Limit: none [ 152.594208] ---[ end Kernel panic - not syncing: Attempted to kill the idle task! ]--- [root@arch ~]# bash: echo: write error: Input/output error [root@arch ~]# [root@arch ~]# [root@arch ~]# echo HELO HELO Cristian Marussi (12): smp: add generic SMP-stop support to common code smp: unify crash_ and smp_send_stop() logic smp: coordinate concurrent crash/smp stop calls smp: address races of starting CPUs while stopping arm64: smp: use generic SMP stop common code arm64: smp: use SMP crash-stop common code arm64: smp: add arch specific cpu parking helper x86: smp: use generic SMP stop common code x86: smp: use SMP crash-stop common code arm: smp: use generic SMP stop common code arm: smp: use SMP crash-stop common code sparc64: smp: use generic SMP stop common code arch/Kconfig | 7 ++ arch/arm/Kconfig | 1 + arch/arm/kernel/machine_kexec.c | 29 ++--- arch/arm/kernel/smp.c | 22 +--- arch/arm64/Kconfig | 1 + arch/arm64/include/asm/smp.h | 2 - arch/arm64/kernel/smp.c | 127 ++++++------------- arch/sparc/Kconfig | 1 + arch/sparc/kernel/smp_64.c | 15 +-- arch/x86/Kconfig | 1 + arch/x86/include/asm/reboot.h | 2 + arch/x86/include/asm/smp.h | 6 - arch/x86/kernel/crash.c | 27 +---- arch/x86/kernel/reboot.c | 58 +++++---- arch/x86/kernel/smp.c | 91 +++++++------- include/linux/smp.h | 83 +++++++++++++ kernel/panic.c | 26 ---- kernel/smp.c | 208 ++++++++++++++++++++++++++++++++ 18 files changed, 444 insertions(+), 263 deletions(-)