| Message ID | 20191217101506.18910-2-peter.ujfalusi@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/bridge: Support for Toshiba tc358768 RGB to DSI bridge | expand |
On Tue, Dec 17, 2019 at 12:15:05PM +0200, Peter Ujfalusi wrote: > TC358768/TC358778 is a Parallel RGB to MIPI DSI bridge. > > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> > --- > .../display/bridge/toshiba,tc358768.yaml | 158 ++++++++++++++++++ > 1 file changed, 158 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > > diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > new file mode 100644 > index 000000000000..8f96867caca0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > @@ -0,0 +1,158 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/bridge/toshiba,tc358768.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Toschiba TC358768/TC358778 Parallel RGB to MIPI DSI bridge > + > +maintainers: > + - Peter Ujfalusi <peter.ujfalusi@ti.com> > + > +description: | > + The TC358768/TC358778 is bridge device which converts RGB to DSI. > + > +properties: > + compatible: > + enum: > + - toshiba,tc358768 > + - toshiba,tc358778 > + > + reg: > + maxItems: 1 > + description: base I2C address of the device > + > + reset-gpios: > + maxItems: 1 > + description: GPIO connected to active low RESX pin > + > + vddc-supply: > + maxItems: 1 Drop this. Not an array. *-supply doesn't need further constraints. > + description: Regulator for 1.2V internal core power. > + > + vddmipi-supply: > + maxItems: 1 > + description: Regulator for 1.2V for the MIPI. > + > + vddio-supply: > + maxItems: 1 > + description: Regulator for 1.8V - 3.3V IO power. Blank line here. > + clocks: > + maxItems: 1 > + > + clock-names: > + const: refclk > + > + ports: > + type: object > + > + properties: > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > + port@0: > + type: object > + additionalProperties: false > + > + description: | > + Video port for RGB input > + > + properties: > + reg: > + const: 0 > + > + patternProperties: > + endpoint: > + type: object > + additionalProperties: false > + > + properties: > + data-lines: > + enum: [ 16, 18, 24 ] > + > + remote-endpoint: true > + > + required: > + - reg > + > + port@1: > + type: object > + description: | > + Video port for DSI output (panel or connector). > + > + properties: > + reg: > + const: 1 > + > + patternProperties: > + endpoint: > + type: object > + additionalProperties: false > + > + properties: > + remote-endpoint: true > + > + required: > + - reg No additionalProperties on this one? > + > + required: > + - "#address-cells" > + - "#size-cells" > + - port@0 > + - port@1 > + > +required: > + - compatible > + - reg > + - vddc-supply > + - vddmipi-supply > + - vddio-supply > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + i2c1 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + dsi_bridge: tc358768@0e { > + compatible = "toshiba,tc358768"; > + reg = <0x0e>; > + > + clocks = <&tc358768_refclk>; > + clock-names = "refclk"; > + > + /* GPIO line is inverted before going to the bridge */ > + reset-gpios = <&pcf_display_board 0 1 /* GPIO_ACTIVE_LOW */>; > + > + vddc-supply = <&v1_2d>; > + vddmipi-supply = <&v1_2d>; > + vddio-supply = <&v3_3d>; > + > + dsi_bridge_ports: ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + rgb_in: endpoint { > + remote-endpoint = <&dpi_out>; > + data-lines = <24>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + dsi_out: endpoint { > + remote-endpoint = <&lcd_in>; > + }; > + }; > + }; > + }; > + }; > + > -- > Peter > > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki >
On 27/12/2019 0.24, Rob Herring wrote: > On Tue, Dec 17, 2019 at 12:15:05PM +0200, Peter Ujfalusi wrote: >> TC358768/TC358778 is a Parallel RGB to MIPI DSI bridge. >> >> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> >> --- >> .../display/bridge/toshiba,tc358768.yaml | 158 ++++++++++++++++++ >> 1 file changed, 158 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml >> >> diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml >> new file mode 100644 >> index 000000000000..8f96867caca0 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml >> @@ -0,0 +1,158 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/display/bridge/toshiba,tc358768.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Toschiba TC358768/TC358778 Parallel RGB to MIPI DSI bridge >> + >> +maintainers: >> + - Peter Ujfalusi <peter.ujfalusi@ti.com> >> + >> +description: | >> + The TC358768/TC358778 is bridge device which converts RGB to DSI. >> + >> +properties: >> + compatible: >> + enum: >> + - toshiba,tc358768 >> + - toshiba,tc358778 >> + >> + reg: >> + maxItems: 1 >> + description: base I2C address of the device >> + >> + reset-gpios: >> + maxItems: 1 >> + description: GPIO connected to active low RESX pin >> + >> + vddc-supply: >> + maxItems: 1 > > Drop this. Not an array. *-supply doesn't need further constraints. OK. > >> + description: Regulator for 1.2V internal core power. >> + >> + vddmipi-supply: >> + maxItems: 1 >> + description: Regulator for 1.2V for the MIPI. >> + >> + vddio-supply: >> + maxItems: 1 >> + description: Regulator for 1.8V - 3.3V IO power. > > Blank line here. Oops, I'll fix it. > >> + clocks: >> + maxItems: 1 >> + >> + clock-names: >> + const: refclk >> + >> + ports: >> + type: object >> + >> + properties: >> + "#address-cells": >> + const: 1 >> + >> + "#size-cells": >> + const: 0 >> + >> + port@0: >> + type: object >> + additionalProperties: false >> + >> + description: | >> + Video port for RGB input >> + >> + properties: >> + reg: >> + const: 0 >> + >> + patternProperties: >> + endpoint: >> + type: object >> + additionalProperties: false >> + >> + properties: >> + data-lines: >> + enum: [ 16, 18, 24 ] >> + >> + remote-endpoint: true >> + >> + required: >> + - reg >> + >> + port@1: >> + type: object >> + description: | >> + Video port for DSI output (panel or connector). >> + >> + properties: >> + reg: >> + const: 1 >> + >> + patternProperties: >> + endpoint: >> + type: object >> + additionalProperties: false >> + >> + properties: >> + remote-endpoint: true >> + >> + required: >> + - reg > > No additionalProperties on this one? Correct, I have missed the additionalProperties: false I'll update the binding documents when I get comments for the driver. Thank you, - Péter > >> + >> + required: >> + - "#address-cells" >> + - "#size-cells" >> + - port@0 >> + - port@1 >> + >> +required: >> + - compatible >> + - reg >> + - vddc-supply >> + - vddmipi-supply >> + - vddio-supply >> + - ports >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + i2c1 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + dsi_bridge: tc358768@0e { >> + compatible = "toshiba,tc358768"; >> + reg = <0x0e>; >> + >> + clocks = <&tc358768_refclk>; >> + clock-names = "refclk"; >> + >> + /* GPIO line is inverted before going to the bridge */ >> + reset-gpios = <&pcf_display_board 0 1 /* GPIO_ACTIVE_LOW */>; >> + >> + vddc-supply = <&v1_2d>; >> + vddmipi-supply = <&v1_2d>; >> + vddio-supply = <&v3_3d>; >> + >> + dsi_bridge_ports: ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + reg = <0>; >> + rgb_in: endpoint { >> + remote-endpoint = <&dpi_out>; >> + data-lines = <24>; >> + }; >> + }; >> + >> + port@1 { >> + reg = <1>; >> + dsi_out: endpoint { >> + remote-endpoint = <&lcd_in>; >> + }; >> + }; >> + }; >> + }; >> + }; >> + >> -- >> Peter >> >> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. >> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki >> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml new file mode 100644 index 000000000000..8f96867caca0 --- /dev/null +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml @@ -0,0 +1,158 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/bridge/toshiba,tc358768.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Toschiba TC358768/TC358778 Parallel RGB to MIPI DSI bridge + +maintainers: + - Peter Ujfalusi <peter.ujfalusi@ti.com> + +description: | + The TC358768/TC358778 is bridge device which converts RGB to DSI. + +properties: + compatible: + enum: + - toshiba,tc358768 + - toshiba,tc358778 + + reg: + maxItems: 1 + description: base I2C address of the device + + reset-gpios: + maxItems: 1 + description: GPIO connected to active low RESX pin + + vddc-supply: + maxItems: 1 + description: Regulator for 1.2V internal core power. + + vddmipi-supply: + maxItems: 1 + description: Regulator for 1.2V for the MIPI. + + vddio-supply: + maxItems: 1 + description: Regulator for 1.8V - 3.3V IO power. + clocks: + maxItems: 1 + + clock-names: + const: refclk + + ports: + type: object + + properties: + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + + port@0: + type: object + additionalProperties: false + + description: | + Video port for RGB input + + properties: + reg: + const: 0 + + patternProperties: + endpoint: + type: object + additionalProperties: false + + properties: + data-lines: + enum: [ 16, 18, 24 ] + + remote-endpoint: true + + required: + - reg + + port@1: + type: object + description: | + Video port for DSI output (panel or connector). + + properties: + reg: + const: 1 + + patternProperties: + endpoint: + type: object + additionalProperties: false + + properties: + remote-endpoint: true + + required: + - reg + + required: + - "#address-cells" + - "#size-cells" + - port@0 + - port@1 + +required: + - compatible + - reg + - vddc-supply + - vddmipi-supply + - vddio-supply + - ports + +additionalProperties: false + +examples: + - | + i2c1 { + #address-cells = <1>; + #size-cells = <0>; + + dsi_bridge: tc358768@0e { + compatible = "toshiba,tc358768"; + reg = <0x0e>; + + clocks = <&tc358768_refclk>; + clock-names = "refclk"; + + /* GPIO line is inverted before going to the bridge */ + reset-gpios = <&pcf_display_board 0 1 /* GPIO_ACTIVE_LOW */>; + + vddc-supply = <&v1_2d>; + vddmipi-supply = <&v1_2d>; + vddio-supply = <&v3_3d>; + + dsi_bridge_ports: ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + rgb_in: endpoint { + remote-endpoint = <&dpi_out>; + data-lines = <24>; + }; + }; + + port@1 { + reg = <1>; + dsi_out: endpoint { + remote-endpoint = <&lcd_in>; + }; + }; + }; + }; + }; +
TC358768/TC358778 is a Parallel RGB to MIPI DSI bridge. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> --- .../display/bridge/toshiba,tc358768.yaml | 158 ++++++++++++++++++ 1 file changed, 158 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml