| Message ID | 878sm96pzf.fsf@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [GIT,PULL] USB: changes for v5.6 merge window | expand |
On Wed, Jan 15, 2020 at 11:14:28AM +0200, Felipe Balbi wrote: > > Hi Greg, > > here's my pull request for v5.6 merge window. If you want anything to be > changed, let me know. Did you send this twice? Any difference?
On Wed, Jan 15, 2020 at 10:28:13AM +0100, Greg Kroah-Hartman wrote: > On Wed, Jan 15, 2020 at 11:14:28AM +0200, Felipe Balbi wrote: > > > > Hi Greg, > > > > here's my pull request for v5.6 merge window. If you want anything to be > > changed, let me know. > > Did you send this twice? Any difference? > I did a pull, and get this problem when checking the patches: Commit: 6a6ae4e8e926 ("usb: gadget: f_ncm: Use atomic_t to track in-flight request") Fixes tag: Fixes: 40d133d7f5426 ("usb: gadget: f_ncm: convert to new function interface Has these problem(s): - Subject has leading but no trailing parentheses - Subject has leading but no trailing quotes I'll go fix it up, but that will break your tree if you try to merge as I will have to rebase :( thanks, greg k-h
Hi, Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes: > On Wed, Jan 15, 2020 at 10:28:13AM +0100, Greg Kroah-Hartman wrote: >> On Wed, Jan 15, 2020 at 11:14:28AM +0200, Felipe Balbi wrote: >> > >> > Hi Greg, >> > >> > here's my pull request for v5.6 merge window. If you want anything to be >> > changed, let me know. >> >> Did you send this twice? Any difference? >> > > I did a pull, and get this problem when checking the patches: > > Commit: 6a6ae4e8e926 ("usb: gadget: f_ncm: Use atomic_t to track in-flight request") > Fixes tag: Fixes: 40d133d7f5426 ("usb: gadget: f_ncm: convert to new function interface > Has these problem(s): > - Subject has leading but no trailing parentheses > - Subject has leading but no trailing quotes Oh, I missed those. > I'll go fix it up, but that will break your tree if you try to merge as Thanks for fixing. I'll reset my tree to yours. > I will have to rebase :( no worries. Out of curiosity, what are you using to flag those? Is checkpatch doing that now?
On Wed, Jan 15, 2020 at 12:33:41PM +0200, Felipe Balbi wrote: > > Hi, > > Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes: > > On Wed, Jan 15, 2020 at 10:28:13AM +0100, Greg Kroah-Hartman wrote: > >> On Wed, Jan 15, 2020 at 11:14:28AM +0200, Felipe Balbi wrote: > >> > > >> > Hi Greg, > >> > > >> > here's my pull request for v5.6 merge window. If you want anything to be > >> > changed, let me know. > >> > >> Did you send this twice? Any difference? > >> > > > > I did a pull, and get this problem when checking the patches: > > > > Commit: 6a6ae4e8e926 ("usb: gadget: f_ncm: Use atomic_t to track in-flight request") > > Fixes tag: Fixes: 40d133d7f5426 ("usb: gadget: f_ncm: convert to new function interface > > Has these problem(s): > > - Subject has leading but no trailing parentheses > > - Subject has leading but no trailing quotes > > Oh, I missed those. > > > I'll go fix it up, but that will break your tree if you try to merge as > > Thanks for fixing. I'll reset my tree to yours. > > > I will have to rebase :( > > no worries. > > Out of curiosity, what are you using to flag those? Is checkpatch doing > that now? No, I'm using some scripts originally based on code that Stephen uses for linux-next (you would have got the same report from him when he merges in your tree.) I published them on the workflows@vger.k.o mailing list a while back if you are interested in them. thanks, greg k-h
Hi, Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes: >> Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes: >> > On Wed, Jan 15, 2020 at 10:28:13AM +0100, Greg Kroah-Hartman wrote: >> >> On Wed, Jan 15, 2020 at 11:14:28AM +0200, Felipe Balbi wrote: >> >> > >> >> > Hi Greg, >> >> > >> >> > here's my pull request for v5.6 merge window. If you want anything to be >> >> > changed, let me know. >> >> >> >> Did you send this twice? Any difference? >> >> >> > >> > I did a pull, and get this problem when checking the patches: >> > >> > Commit: 6a6ae4e8e926 ("usb: gadget: f_ncm: Use atomic_t to track in-flight request") >> > Fixes tag: Fixes: 40d133d7f5426 ("usb: gadget: f_ncm: convert to new function interface >> > Has these problem(s): >> > - Subject has leading but no trailing parentheses >> > - Subject has leading but no trailing quotes >> >> Oh, I missed those. >> >> > I'll go fix it up, but that will break your tree if you try to merge as >> >> Thanks for fixing. I'll reset my tree to yours. >> >> > I will have to rebase :( >> >> no worries. >> >> Out of curiosity, what are you using to flag those? Is checkpatch doing >> that now? > > No, I'm using some scripts originally based on code that Stephen uses > for linux-next (you would have got the same report from him when he > merges in your tree.) I published them on the workflows@vger.k.o > mailing list a while back if you are interested in them. Cool, I'll look for them. Thanks
Hi again, Felipe Balbi <balbi@kernel.org> writes: >>> Out of curiosity, what are you using to flag those? Is checkpatch doing >>> that now? >> >> No, I'm using some scripts originally based on code that Stephen uses >> for linux-next (you would have got the same report from him when he >> merges in your tree.) I published them on the workflows@vger.k.o >> mailing list a while back if you are interested in them. > > Cool, I'll look for them. Thanks For anyone interested: https://lore.kernel.org/workflows/20190926195143.GA1742392@kroah.com/
Hi Greg, here's my pull request for v5.6 merge window. If you want anything to be changed, let me know. cheers The following changes since commit 845f081002eebd7a1216fc0a5ef2c862dc6d093e: Merge 5.5-rc6 into usb-next (2020-01-13 12:11:40 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git tags/usb-for-v5.6 for you to fetch changes up to 8d891e324f4452ff1a0b324a2474b44ef04b491c: usb: gadget: f_ecm: Use atomic_t to track in-flight request (2020-01-15 10:58:58 +0200) ---------------------------------------------------------------- USB: changes for v5.6 merge window A few important, albeit non-critical, fixes on dwc3 done by Thinh Nguyen. The cdns3 driver got ported to NXP, while also learning about streams. Other than these highlights, we also have the usual set of non-critical fixes all over the place. Signed-off-by: Felipe Balbi <balbi@kernel.org> ---------------------------------------------------------------- Alexandru M Stan (1): usb: dwc2: Fix NULL qh in dwc2_queue_transaction Bin Liu (1): usb: dwc3: turn off VBUS when leaving host mode Bryan O'Donoghue (2): usb: gadget: f_ncm: Use atomic_t to track in-flight request usb: gadget: f_ecm: Use atomic_t to track in-flight request Dejin Zheng (1): usb: gadget: udc: core: Warn about failed to find udc Jayshri Pawar (1): usb: cdns3: Add streams support to cadence USB3 DRD driver Jia-Ju Bai (1): usb: gadget: udc: fix possible sleep-in-atomic-context bugs in gr_probe() John Keeping (3): usb: dwc2: Fix IN FIFO allocation usb: dwc2: fix debugfs FIFO count usb: gadget: f_uac2: fix packet size calculation Linus Walleij (1): usb: phy-generic: Delete unused platform data Minas Harutyunyan (1): usb: dwc2: Fix Stalling a Non-Isochronous OUT EP Peter Chen (2): usb: gadget: f_fs: set req->num_sgs as 0 for non-sg transfer usb: cdns3: add NXP imx8qm glue layer Roger Quadros (1): usb: gadget: legacy: set max_speed to super-speed Thinh Nguyen (7): usb: dwc3: gadget: Don't send unintended link state change usb: dwc3: gadget: Set link state to RX_Detect on disconnect usb: dwc3: gadget: Clear DCTL.ULSTCHNGREQ before set usb: gadget: configfs: Add max_speed setting usb: dwc3: gadget: Check END_TRANSFER completion usb: dwc3: gadget: Delay starting transfer usb: dwc3: gadget: Remove END_TRANSFER delay Documentation/ABI/testing/configfs-usb-gadget | 4 + drivers/usb/cdns3/Kconfig | 10 + drivers/usb/cdns3/Makefile | 1 + drivers/usb/cdns3/cdns3-imx.c | 216 +++++++++++ drivers/usb/cdns3/gadget.c | 533 +++++++++++++++++++++++--- drivers/usb/cdns3/gadget.h | 26 +- drivers/usb/cdns3/trace.h | 93 ++++- drivers/usb/dwc2/debugfs.c | 3 +- drivers/usb/dwc2/gadget.c | 25 +- drivers/usb/dwc2/hcd.c | 2 +- drivers/usb/dwc3/core.c | 3 + drivers/usb/dwc3/core.h | 2 + drivers/usb/dwc3/ep0.c | 4 +- drivers/usb/dwc3/gadget.c | 56 +-- drivers/usb/dwc3/gadget.h | 14 + drivers/usb/gadget/configfs.c | 43 +++ drivers/usb/gadget/function/f_ecm.c | 16 +- drivers/usb/gadget/function/f_fs.c | 2 + drivers/usb/gadget/function/f_ncm.c | 17 +- drivers/usb/gadget/function/u_audio.c | 10 +- drivers/usb/gadget/legacy/cdc2.c | 2 +- drivers/usb/gadget/legacy/g_ffs.c | 2 +- drivers/usb/gadget/legacy/multi.c | 2 +- drivers/usb/gadget/legacy/ncm.c | 2 +- drivers/usb/gadget/udc/core.c | 2 + drivers/usb/gadget/udc/gr_udc.c | 16 +- drivers/usb/phy/phy-am335x.c | 2 +- drivers/usb/phy/phy-generic.c | 39 +- drivers/usb/phy/phy-generic.h | 3 +- drivers/usb/phy/phy-keystone.c | 2 +- include/linux/usb/usb_phy_generic.h | 12 - 31 files changed, 1010 insertions(+), 154 deletions(-) create mode 100644 drivers/usb/cdns3/cdns3-imx.c