| Message ID | 1576045585-8536-1-git-send-email-linmiaohe@huawei.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Fix various comment errors | expand |
On Wed, Dec 11, 2019 at 02:26:19PM +0800, linmiaohe wrote: > From: Miaohe Lin <linmiaohe@huawei.com> > > Fix various comment mistakes, such as typo, grammar mistake, out-dated > function name, writing error and so on. It is a bit tedious and many > thanks for review in advance. > > Miaohe Lin (6): > KVM: Fix some wrong function names in comment > KVM: Fix some out-dated function names in comment > KVM: Fix some comment typos and missing parentheses > KVM: Fix some grammar mistakes > KVM: hyperv: Fix some typos in vcpu unimpl info > KVM: Fix some writing mistakes Regarding the patch organizing, I'd probably group the comment changes based on what files they touch as opposed to what type of comment issue they're fixing. E.g. three patches for the comments KVM: VMX: Fix comment blah blah blah KVM: x86: Fix comment blah blah blah KVM: Fix comment blah blah blah and one patch for the print typo in hyperv KVM: hyperv: Fix some typos in vcpu unimpl info For KVM, the splits don't matter _that_ much since they more or less all get routed through the maintainers/reviewers, but it is nice when patches can be contained to specific subsystems/areas as it allows people to easily skip over patches that aren't relevant to them. > arch/x86/include/asm/kvm_host.h | 2 +- > arch/x86/kvm/hyperv.c | 6 +++--- > arch/x86/kvm/ioapic.c | 2 +- > arch/x86/kvm/lapic.c | 4 ++-- > arch/x86/kvm/vmx/nested.c | 2 +- > arch/x86/kvm/vmx/vmcs_shadow_fields.h | 4 ++-- > arch/x86/kvm/vmx/vmx.c | 8 ++++---- > virt/kvm/kvm_main.c | 6 +++--- > 8 files changed, 17 insertions(+), 17 deletions(-) > > -- > 2.19.1 >
On 11/12/19 07:26, linmiaohe wrote: > From: Miaohe Lin <linmiaohe@huawei.com> > > Fix various comment mistakes, such as typo, grammar mistake, out-dated > function name, writing error and so on. It is a bit tedious and many > thanks for review in advance. > > Miaohe Lin (6): > KVM: Fix some wrong function names in comment > KVM: Fix some out-dated function names in comment > KVM: Fix some comment typos and missing parentheses > KVM: Fix some grammar mistakes > KVM: hyperv: Fix some typos in vcpu unimpl info > KVM: Fix some writing mistakes > > arch/x86/include/asm/kvm_host.h | 2 +- > arch/x86/kvm/hyperv.c | 6 +++--- > arch/x86/kvm/ioapic.c | 2 +- > arch/x86/kvm/lapic.c | 4 ++-- > arch/x86/kvm/vmx/nested.c | 2 +- > arch/x86/kvm/vmx/vmcs_shadow_fields.h | 4 ++-- > arch/x86/kvm/vmx/vmx.c | 8 ++++---- > virt/kvm/kvm_main.c | 6 +++--- > 8 files changed, 17 insertions(+), 17 deletions(-) > Queued, thanks. Paolo
From: Miaohe Lin <linmiaohe@huawei.com> Fix various comment mistakes, such as typo, grammar mistake, out-dated function name, writing error and so on. It is a bit tedious and many thanks for review in advance. Miaohe Lin (6): KVM: Fix some wrong function names in comment KVM: Fix some out-dated function names in comment KVM: Fix some comment typos and missing parentheses KVM: Fix some grammar mistakes KVM: hyperv: Fix some typos in vcpu unimpl info KVM: Fix some writing mistakes arch/x86/include/asm/kvm_host.h | 2 +- arch/x86/kvm/hyperv.c | 6 +++--- arch/x86/kvm/ioapic.c | 2 +- arch/x86/kvm/lapic.c | 4 ++-- arch/x86/kvm/vmx/nested.c | 2 +- arch/x86/kvm/vmx/vmcs_shadow_fields.h | 4 ++-- arch/x86/kvm/vmx/vmx.c | 8 ++++---- virt/kvm/kvm_main.c | 6 +++--- 8 files changed, 17 insertions(+), 17 deletions(-)