crypto: sun8i-ce: remove dead code

Commit Message

Corentin Labbe Jan. 6, 2020, 7:32 p.m. UTC

Some code were left in the final driver but without any use.

Signed-off-by: Corentin Labbe <[e-mail]>
---
 drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c | 5 -----
 drivers/crypto/allwinner/sun8i-ce/sun8i-ce.h        | 8 --------
 2 files changed, 13 deletions(-)

Comments

Herbert Xu Jan. 16, 2020, 7:28 a.m. UTC | #1

On Mon, Jan 06, 2020 at 08:32:08PM +0100, Corentin Labbe wrote:
> Some code were left in the final driver but without any use.
> 
> Signed-off-by: Corentin Labbe <[e-mail]>
> ---
>  drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c | 5 -----
>  drivers/crypto/allwinner/sun8i-ce/sun8i-ce.h        | 8 --------
>  2 files changed, 13 deletions(-)

Patch applied.  Thanks.

Patch

diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c
index 37d0b6c386a0..75e2bef2b363 100644
--- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c
+++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c
@@ -144,11 +144,6 @@  static int sun8i_ce_cipher(struct skcipher_request *areq)
 	cet->t_sym_ctl = cpu_to_le32(sym);
 	cet->t_asym_ctl = 0;
 
-	chan->op_mode = ce->variant->op_mode[algt->ce_blockmode];
-	chan->op_dir = rctx->op_dir;
-	chan->method = ce->variant->alg_cipher[algt->ce_algo_id];
-	chan->keylen = op->keylen;
-
 	addr_key = dma_map_single(ce->dev, op->key, op->keylen, DMA_TO_DEVICE);
 	cet->t_key = cpu_to_le32(addr_key);
 	if (dma_mapping_error(ce->dev, addr_key)) {
diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce.h b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce.h
index 43db49ceafe4..8f8404c84a4d 100644
--- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce.h
+++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce.h
@@ -131,12 +131,8 @@  struct ce_task {
  * @engine:	ptr to the crypto_engine for this flow
  * @bounce_iv:	buffer which contain the IV
  * @ivlen:	size of bounce_iv
- * @keylen:	keylen for this flow operation
  * @complete:	completion for the current task on this flow
  * @status:	set to 1 by interrupt if task is done
- * @method:	current method for flow
- * @op_dir:	direction (encrypt vs decrypt) of this flow
- * @op_mode:	op_mode for this flow
  * @t_phy:	Physical address of task
  * @tl:		pointer to the current ce_task for this flow
  * @stat_req:	number of request done by this flow
@@ -145,12 +141,8 @@  struct sun8i_ce_flow {
 	struct crypto_engine *engine;
 	void *bounce_iv;
 	unsigned int ivlen;
-	unsigned int keylen;
 	struct completion complete;
 	int status;
-	u32 method;
-	u32 op_dir;
-	u32 op_mode;
 	dma_addr_t t_phy;
 	int timeout;
 	struct ce_task *tl;