[v22,9/9] MAINTAINERS: Add ACPI/HEST/GHES entries

Commit Message

Dongjiu Geng Jan. 8, 2020, 11:32 a.m. UTC

I and Xiang are willing to review the APEI-related patches and
volunteer as the reviewers for the HEST/GHES part.

Signed-off-by: Dongjiu Geng <[e-mail]>
Signed-off-by: Xiang Zheng <[e-mail]>
---
 MAINTAINERS | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Peter Maydell Jan. 16, 2020, 4:46 p.m. UTC | #1

On Wed, 8 Jan 2020 at 11:32, Dongjiu Geng <[e-mail]> wrote:
>
> I and Xiang are willing to review the APEI-related patches and
> volunteer as the reviewers for the HEST/GHES part.
>
> Signed-off-by: Dongjiu Geng <[e-mail]>
> Signed-off-by: Xiang Zheng <[e-mail]>
> ---
>  MAINTAINERS | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 387879a..5af70a5 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1423,6 +1423,15 @@ F: tests/bios-tables-test.c
>  F: tests/acpi-utils.[hc]
>  F: tests/data/acpi/
>
> +ACPI/HEST/GHES
> +R: Dongjiu Geng <[e-mail]>
> +R: Xiang Zheng <[e-mail]>
> +L: [e-mail]
> +S: Maintained
> +F: hw/acpi/ghes.c
> +F: include/hw/acpi/ghes.h
> +F: docs/specs/acpi_hest_ghes.rst
> +
>  ppc4xx
>  M: David Gibson <[e-mail]>
>  L: [e-mail]
> --

Michael, Igor: since this new MAINTAINERS section is
moving files out of the 'ACPI/SMBIOS' section that you're
currently responsible for, do you want to provide an
acked-by: that you think this division of files makes sense?

thanks
-- PMM

Philippe Mathieu-Daudé Jan. 17, 2020, 7:22 a.m. UTC | #2

Hi Peter,

On 1/16/20 5:46 PM, Peter Maydell wrote:
> On Wed, 8 Jan 2020 at 11:32, Dongjiu Geng <[e-mail]> wrote:
>>
>> I and Xiang are willing to review the APEI-related patches and
>> volunteer as the reviewers for the HEST/GHES part.
>>
>> Signed-off-by: Dongjiu Geng <[e-mail]>
>> Signed-off-by: Xiang Zheng <[e-mail]>
>> ---
>>   MAINTAINERS | 9 +++++++++
>>   1 file changed, 9 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 387879a..5af70a5 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1423,6 +1423,15 @@ F: tests/bios-tables-test.c
>>   F: tests/acpi-utils.[hc]
>>   F: tests/data/acpi/
>>
>> +ACPI/HEST/GHES
>> +R: Dongjiu Geng <[e-mail]>
>> +R: Xiang Zheng <[e-mail]>
>> +L: [e-mail]
>> +S: Maintained
>> +F: hw/acpi/ghes.c
>> +F: include/hw/acpi/ghes.h
>> +F: docs/specs/acpi_hest_ghes.rst
>> +
>>   ppc4xx
>>   M: David Gibson <[e-mail]>
>>   L: [e-mail]
>> --
> 
> Michael, Igor: since this new MAINTAINERS section is
> moving files out of the 'ACPI/SMBIOS' section that you're
> currently responsible for, do you want to provide an
> acked-by: that you think this division of files makes sense?

The files are not 'moved out', Michael and Igor are still the 
maintainers of the supported ACPI/SMBIOS subsystem:

ACPI/SMBIOS
M: Michael S. Tsirkin <[e-mail]>
M: Igor Mammedov <[e-mail]>
S: Supported
F: include/hw/acpi/*
F: hw/acpi/*

Dongjiu and Xiang only add themselves as reviewers to get notified on 
changes on these specific files. The more eyes the better :)

The docs/specs/acpi_hest_ghes.rst document has no maintainer, as these 
others too:

- docs/specs/acpi_cpu_hotplug.txt
- docs/specs/acpi_hw_reduced_hotplug.rst
- docs/specs/acpi_mem_hotplug.txt
- docs/specs/acpi_nvdimm.txt

The only ACPI file reported as maintained in docs/specs/ is 
acpi_pci_hotplug.txt, from this entry:

PCI
M: Michael S. Tsirkin <[e-mail]>
M: Marcel Apfelbaum <[e-mail]>
S: Supported
F: docs/specs/*pci*

FWIW:
Reviewed-by: Philippe Mathieu-Daudé <[e-mail]>

Dongjiu Geng Jan. 17, 2020, 10:16 a.m. UTC | #3

On 2020/1/17 15:22, Philippe Mathieu-Daudé wrote:
> Hi Peter,
> 
> On 1/16/20 5:46 PM, Peter Maydell wrote:
>> On Wed, 8 Jan 2020 at 11:32, Dongjiu Geng <[e-mail]> wrote:
>>>
>>> I and Xiang are willing to review the APEI-related patches and
>>> volunteer as the reviewers for the HEST/GHES part.
>>>
>>> Signed-off-by: Dongjiu Geng <[e-mail]>
>>> Signed-off-by: Xiang Zheng <[e-mail]>
>>> ---
>>>   MAINTAINERS | 9 +++++++++
>>>   1 file changed, 9 insertions(+)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index 387879a..5af70a5 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -1423,6 +1423,15 @@ F: tests/bios-tables-test.c
>>>   F: tests/acpi-utils.[hc]
>>>   F: tests/data/acpi/
>>>
>>> +ACPI/HEST/GHES
>>> +R: Dongjiu Geng <[e-mail]>
>>> +R: Xiang Zheng <[e-mail]>
>>> +L: [e-mail]
>>> +S: Maintained
>>> +F: hw/acpi/ghes.c
>>> +F: include/hw/acpi/ghes.h
>>> +F: docs/specs/acpi_hest_ghes.rst
>>> +
>>>   ppc4xx
>>>   M: David Gibson <[e-mail]>
>>>   L: [e-mail]
>>> -- 
>>
>> Michael, Igor: since this new MAINTAINERS section is
>> moving files out of the 'ACPI/SMBIOS' section that you're
>> currently responsible for, do you want to provide an
>> acked-by: that you think this division of files makes sense?
> 
> The files are not 'moved out', Michael and Igor are still the maintainers of the supported ACPI/SMBIOS subsystem:
> 
> ACPI/SMBIOS
> M: Michael S. Tsirkin <[e-mail]>
> M: Igor Mammedov <[e-mail]>
> S: Supported
> F: include/hw/acpi/*
> F: hw/acpi/*
> 
> Dongjiu and Xiang only add themselves as reviewers to get notified on changes on these specific files. The more eyes the better :)
> 
> The docs/specs/acpi_hest_ghes.rst document has no maintainer, as these others too:
If this file has no maintainer, may be it needs a M tag for this file, otherwise when people change this file, and use "./scripts/get_maintainer.pl xxxxx" to get maintainer, it will be empty.

> 
> - docs/specs/acpi_cpu_hotplug.txt
> - docs/specs/acpi_hw_reduced_hotplug.rst
> - docs/specs/acpi_mem_hotplug.txt
> - docs/specs/acpi_nvdimm.txt
> 
> The only ACPI file reported as maintained in docs/specs/ is acpi_pci_hotplug.txt, from this entry:
> 
> PCI
> M: Michael S. Tsirkin <[e-mail]>
> M: Marcel Apfelbaum <[e-mail]>
> S: Supported
> F: docs/specs/*pci*
> 
> FWIW:
> Reviewed-by: Philippe Mathieu-Daudé <[e-mail]>
> 
> .
>

Peter Maydell Jan. 17, 2020, 11:09 a.m. UTC | #4

On Fri, 17 Jan 2020 at 07:22, Philippe Mathieu-Daudé <[e-mail]> wrote:
>
> Hi Peter,
>
> On 1/16/20 5:46 PM, Peter Maydell wrote:
> > On Wed, 8 Jan 2020 at 11:32, Dongjiu Geng <[e-mail]> wrote:
> >>
> >> I and Xiang are willing to review the APEI-related patches and
> >> volunteer as the reviewers for the HEST/GHES part.
> >>
> >> Signed-off-by: Dongjiu Geng <[e-mail]>
> >> Signed-off-by: Xiang Zheng <[e-mail]>
> >> ---
> >>   MAINTAINERS | 9 +++++++++
> >>   1 file changed, 9 insertions(+)
> >>
> >> diff --git a/MAINTAINERS b/MAINTAINERS
> >> index 387879a..5af70a5 100644
> >> --- a/MAINTAINERS
> >> +++ b/MAINTAINERS
> >> @@ -1423,6 +1423,15 @@ F: tests/bios-tables-test.c
> >>   F: tests/acpi-utils.[hc]
> >>   F: tests/data/acpi/
> >>
> >> +ACPI/HEST/GHES
> >> +R: Dongjiu Geng <[e-mail]>
> >> +R: Xiang Zheng <[e-mail]>
> >> +L: [e-mail]
> >> +S: Maintained
> >> +F: hw/acpi/ghes.c
> >> +F: include/hw/acpi/ghes.h
> >> +F: docs/specs/acpi_hest_ghes.rst
> >> +
> >>   ppc4xx
> >>   M: David Gibson <[e-mail]>
> >>   L: [e-mail]
> >> --
> >
> > Michael, Igor: since this new MAINTAINERS section is
> > moving files out of the 'ACPI/SMBIOS' section that you're
> > currently responsible for, do you want to provide an
> > acked-by: that you think this division of files makes sense?
>
> The files are not 'moved out', Michael and Igor are still the
> maintainers of the supported ACPI/SMBIOS subsystem:

Does get_maintainer.pl print the answers for all matching
sections, rather than just the most specific, then?

In any case, I'd still like an acked-by from them.

thanks
-- PMM

Philippe Mathieu-Daudé Jan. 17, 2020, 11:22 a.m. UTC | #5

On 1/17/20 12:09 PM, Peter Maydell wrote:
> On Fri, 17 Jan 2020 at 07:22, Philippe Mathieu-Daudé <[e-mail]> wrote:
>>
>> Hi Peter,
>>
>> On 1/16/20 5:46 PM, Peter Maydell wrote:
>>> On Wed, 8 Jan 2020 at 11:32, Dongjiu Geng <[e-mail]> wrote:
>>>>
>>>> I and Xiang are willing to review the APEI-related patches and
>>>> volunteer as the reviewers for the HEST/GHES part.
>>>>
>>>> Signed-off-by: Dongjiu Geng <[e-mail]>
>>>> Signed-off-by: Xiang Zheng <[e-mail]>
>>>> ---
>>>>    MAINTAINERS | 9 +++++++++
>>>>    1 file changed, 9 insertions(+)
>>>>
>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>> index 387879a..5af70a5 100644
>>>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -1423,6 +1423,15 @@ F: tests/bios-tables-test.c
>>>>    F: tests/acpi-utils.[hc]
>>>>    F: tests/data/acpi/
>>>>
>>>> +ACPI/HEST/GHES
>>>> +R: Dongjiu Geng <[e-mail]>
>>>> +R: Xiang Zheng <[e-mail]>
>>>> +L: [e-mail]
>>>> +S: Maintained
>>>> +F: hw/acpi/ghes.c
>>>> +F: include/hw/acpi/ghes.h
>>>> +F: docs/specs/acpi_hest_ghes.rst
>>>> +
>>>>    ppc4xx
>>>>    M: David Gibson <[e-mail]>
>>>>    L: [e-mail]
>>>> --
>>>
>>> Michael, Igor: since this new MAINTAINERS section is
>>> moving files out of the 'ACPI/SMBIOS' section that you're
>>> currently responsible for, do you want to provide an
>>> acked-by: that you think this division of files makes sense?
>>
>> The files are not 'moved out', Michael and Igor are still the
>> maintainers of the supported ACPI/SMBIOS subsystem:
> 
> Does get_maintainer.pl print the answers for all matching
> sections, rather than just the most specific, then?

Yes:

$ ./scripts/get_maintainer.pl -f hw/acpi/ghes.c
Dongjiu Geng <[e-mail]> (reviewer:ACPI/HEST/GHES)
Xiang Zheng <[e-mail]> (reviewer:ACPI/HEST/GHES)
"Michael S. Tsirkin" <[e-mail]> (supporter:ACPI/SMBIOS)
Igor Mammedov <[e-mail]> (supporter:ACPI/SMBIOS)
[e-mail] (open list:ACPI/HEST/GHES)
[e-mail] (open list:All patches CC here)

> In any case, I'd still like an acked-by from them.

Sure :)

Michael S. Tsirkin Jan. 17, 2020, 12:19 p.m. UTC | #6

On Fri, Jan 17, 2020 at 11:09:07AM +0000, Peter Maydell wrote:
> On Fri, 17 Jan 2020 at 07:22, Philippe Mathieu-Daudé <[e-mail]> wrote:
> >
> > Hi Peter,
> >
> > On 1/16/20 5:46 PM, Peter Maydell wrote:
> > > On Wed, 8 Jan 2020 at 11:32, Dongjiu Geng <[e-mail]> wrote:
> > >>
> > >> I and Xiang are willing to review the APEI-related patches and
> > >> volunteer as the reviewers for the HEST/GHES part.
> > >>
> > >> Signed-off-by: Dongjiu Geng <[e-mail]>
> > >> Signed-off-by: Xiang Zheng <[e-mail]>
> > >> ---
> > >>   MAINTAINERS | 9 +++++++++
> > >>   1 file changed, 9 insertions(+)
> > >>
> > >> diff --git a/MAINTAINERS b/MAINTAINERS
> > >> index 387879a..5af70a5 100644
> > >> --- a/MAINTAINERS
> > >> +++ b/MAINTAINERS
> > >> @@ -1423,6 +1423,15 @@ F: tests/bios-tables-test.c
> > >>   F: tests/acpi-utils.[hc]
> > >>   F: tests/data/acpi/
> > >>
> > >> +ACPI/HEST/GHES
> > >> +R: Dongjiu Geng <[e-mail]>
> > >> +R: Xiang Zheng <[e-mail]>
> > >> +L: [e-mail]
> > >> +S: Maintained
> > >> +F: hw/acpi/ghes.c
> > >> +F: include/hw/acpi/ghes.h
> > >> +F: docs/specs/acpi_hest_ghes.rst
> > >> +
> > >>   ppc4xx
> > >>   M: David Gibson <[e-mail]>
> > >>   L: [e-mail]
> > >> --
> > >
> > > Michael, Igor: since this new MAINTAINERS section is
> > > moving files out of the 'ACPI/SMBIOS' section that you're
> > > currently responsible for, do you want to provide an
> > > acked-by: that you think this division of files makes sense?
> >
> > The files are not 'moved out', Michael and Igor are still the
> > maintainers of the supported ACPI/SMBIOS subsystem:
> 
> Does get_maintainer.pl print the answers for all matching
> sections, rather than just the most specific, then?
> 
> In any case, I'd still like an acked-by from them.
> 
> thanks
> -- PMM

Acked-by: Michael S. Tsirkin <[e-mail]>

Dongjiu Geng Jan. 19, 2020, 8:19 a.m. UTC | #7

On 2020/1/17 19:22, Philippe Mathieu-Daudé wrote:
> On 1/17/20 12:09 PM, Peter Maydell wrote:
>> On Fri, 17 Jan 2020 at 07:22, Philippe Mathieu-Daudé <[e-mail]> wrote:
>>>
>>> Hi Peter,
>>>
>>> On 1/16/20 5:46 PM, Peter Maydell wrote:
>>>> On Wed, 8 Jan 2020 at 11:32, Dongjiu Geng <[e-mail]> wrote:
>>>>>
>>>>> I and Xiang are willing to review the APEI-related patches and
>>>>> volunteer as the reviewers for the HEST/GHES part.
>>>>>
>>>>> Signed-off-by: Dongjiu Geng <[e-mail]>
>>>>> Signed-off-by: Xiang Zheng <[e-mail]>
>>>>> ---
>>>>>    MAINTAINERS | 9 +++++++++
>>>>>    1 file changed, 9 insertions(+)
>>>>>
>>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>>> index 387879a..5af70a5 100644
>>>>> --- a/MAINTAINERS
>>>>> +++ b/MAINTAINERS
>>>>> @@ -1423,6 +1423,15 @@ F: tests/bios-tables-test.c
>>>>>    F: tests/acpi-utils.[hc]
>>>>>    F: tests/data/acpi/
>>>>>
>>>>> +ACPI/HEST/GHES
>>>>> +R: Dongjiu Geng <[e-mail]>
>>>>> +R: Xiang Zheng <[e-mail]>
>>>>> +L: [e-mail]
>>>>> +S: Maintained
>>>>> +F: hw/acpi/ghes.c
>>>>> +F: include/hw/acpi/ghes.h
>>>>> +F: docs/specs/acpi_hest_ghes.rst
>>>>> +
>>>>>    ppc4xx
>>>>>    M: David Gibson <[e-mail]>
>>>>>    L: [e-mail]
>>>>> -- 
>>>>
>>>> Michael, Igor: since this new MAINTAINERS section is
>>>> moving files out of the 'ACPI/SMBIOS' section that you're
>>>> currently responsible for, do you want to provide an
>>>> acked-by: that you think this division of files makes sense?
>>>
>>> The files are not 'moved out', Michael and Igor are still the
>>> maintainers of the supported ACPI/SMBIOS subsystem: 

In fact, I am willing to maintain with others to the new added files , I see some new added files in "hw/acpi" folders are moved out, such as NVDIMM/vmgenid.

NVDIMM
M: Xiao Guangrong <[e-mail]>
S: Maintained
F: hw/acpi/nvdimm.c
F: hw/mem/nvdimm.c
F: include/hw/mem/nvdimm.h
F: docs/nvdimm.txt

VM Generation ID
M: Ben Warren <[e-mail]>
S: Maintained
F: hw/acpi/vmgenid.c
F: include/hw/acpi/vmgenid.h
F: docs/specs/vmgenid.txt
F: tests/vmgenid-test.c
F: stubs/vmgenid.c

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 387879a..5af70a5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1423,6 +1423,15 @@  F: tests/bios-tables-test.c
 F: tests/acpi-utils.[hc]
 F: tests/data/acpi/
 
+ACPI/HEST/GHES
+R: Dongjiu Geng <[e-mail]>
+R: Xiang Zheng <[e-mail]>
+L: [e-mail]
+S: Maintained
+F: hw/acpi/ghes.c
+F: include/hw/acpi/ghes.h
+F: docs/specs/acpi_hest_ghes.rst
+
 ppc4xx
 M: David Gibson <[e-mail]>
 L: [e-mail]