mbox series

[RFC,v4,0/6] ASoC: Add Multi CPU DAI support

Message ID 20200120132928.25257-1-yung-chuan.liao@linux.intel.com (mailing list archive)
Headers show
Series ASoC: Add Multi CPU DAI support | expand

Message

Bard Liao Jan. 20, 2020, 1:29 p.m. UTC 
As discussed in [1], ASoC core supports multi codec DAIs
on a DAI link. However it does not do so for CPU DAIs.

So, add support for multi CPU DAIs on a DAI Link by adding
multi CPU DAI in Card instantiation, suspend and resume
functions, PCM ops, stream handling functions and DAPM.

[1]: https://www.spinics.net/lists/alsa-devel/msg71369.html

changes in v4:
 - fix "rtd->num_codecs > 1" error in ASoC: Add Multi CPU DAI support
 - split "ASoC: pcm: check if cpu DAI support the given stream" from
   "ASoC: Add multiple CPU DAI support for PCM ops"
 - add helper "ASoC: Add dapm_add_valid_dai_widget helper" for
   "ASoC: Add multiple CPU DAI support in DAPM" 

Bard Liao (2):
  ASoC: return error if the function is not support multi cpu yet.
  ASoC: pcm: check if cpu DAI support the given stream

Shreyas NC (4):
  ASoC: Add initial support for multiple CPU DAIs
  ASoC: Add multiple CPU DAI support for PCM ops
  ASoC: Add dapm_add_valid_dai_widget helper
  ASoC: Add multiple CPU DAI support in DAPM

 include/sound/soc.h                   |  15 +
 sound/soc/soc-compress.c              |   5 +-
 sound/soc/soc-core.c                  | 205 +++++-----
 sound/soc/soc-dapm.c                  | 133 ++++---
 sound/soc/soc-generic-dmaengine-pcm.c |  18 +
 sound/soc/soc-pcm.c                   | 554 ++++++++++++++++++--------
 6 files changed, 615 insertions(+), 315 deletions(-)

Comments

Mark Brown Jan. 22, 2020, 4:57 p.m. UTC | #1 
On Mon, Jan 20, 2020 at 09:29:22PM +0800, Bard Liao wrote:
> As discussed in [1], ASoC core supports multi codec DAIs
> on a DAI link. However it does not do so for CPU DAIs.

On a first, very high level, read through this makes sense to me (as did
the earlier version I looked at) but it's quite late in the release
cycle so I'll hold off actually doing anything until after the merge
window, I'll try to look through it properly before then so it gets
applied at -rc1 - hopefully other people will get a chance to too.
Thanks for picking this work up!
Mark Brown Feb. 25, 2020, 1:56 a.m. UTC | #2 
On Mon, Jan 20, 2020 at 09:29:22PM +0800, Bard Liao wrote:
> As discussed in [1], ASoC core supports multi codec DAIs
> on a DAI link. However it does not do so for CPU DAIs.

Sorry, I didn't apply this at -rc1 like I intended to and now it
needs some rebasing - can you resend please?  My mistake, sorry.
Liao, Bard Feb. 25, 2020, 2:54 a.m. UTC | #3 
> -----Original Message-----
> From: Mark Brown <broonie@kernel.org>
> Sent: Tuesday, February 25, 2020 9:57 AM
> To: Bard Liao <yung-chuan.liao@linux.intel.com>
> Cc: tiwai@suse.de; alsa-devel@alsa-project.org;
> liam.r.girdwood@linux.intel.com; pierre-louis.bossart@linux.intel.com;
> kuninori.morimoto.gx@renesas.com; Liao, Bard <bard.liao@intel.com>
> Subject: Re: [PATCH RFC v4 0/6] ASoC: Add Multi CPU DAI support
> 
> On Mon, Jan 20, 2020 at 09:29:22PM +0800, Bard Liao wrote:
> > As discussed in [1], ASoC core supports multi codec DAIs on a DAI
> > link. However it does not do so for CPU DAIs.
> 
> Sorry, I didn't apply this at -rc1 like I intended to and now it needs some rebasing
> - can you resend please?  My mistake, sorry.

Sure, I will do it soon.