| Message ID | 20200110134823.14882-1-ludovic.barre@st.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | mmc: mmci: sdmmc: add sdr104 support | expand |
hi Ulf Just a "gentleman ping" on this series https://lkml.org/lkml/2020/1/10/392 Regards Ludo Le 1/10/20 à 2:48 PM, Ludovic Barre a écrit : > To support the sdr104 mode, sdmmc variant needs: > -Hardware delay block support for sdmmc variant > with tuning procedure > -Voltage switch callbacks > -sdmmc revision 2.0 > > Ludovic Barre (9): > mmc: mmci: sdmmc: replace sg_dma_xxx macros > mmc: mmci: sdmmc: rename sdmmc_priv struct to sdmmc_idma > mmc: mmci: add a reference at mmc_host_ops in mmci struct > mmc: mmci: add private pointer for variant > dt-bindings: mmc: mmci: add delay block base register for sdmmc > mmc: mmci: sdmmc: add execute tuning with delay block > mmc: mmci: add volt_switch callbacks > mmc: mmci: sdmmc: add voltage switch functions > mmc: mmci: add sdmmc variant revision 2.0 > > .../devicetree/bindings/mmc/mmci.txt | 2 + > drivers/mmc/host/mmci.c | 39 ++++ > drivers/mmc/host/mmci.h | 8 + > drivers/mmc/host/mmci_stm32_sdmmc.c | 199 +++++++++++++++++- > 4 files changed, 241 insertions(+), 7 deletions(-) >
On Fri, 24 Jan 2020 at 13:55, Ludovic BARRE <ludovic.barre@st.com> wrote: > > hi Ulf > > Just a "gentleman ping" on this series > https://lkml.org/lkml/2020/1/10/392 I was just reviewing :-) Thanks for pinging! One overall comment is that I think you can try to work a bit on the changelogs. In some cases you described what the patch does, which is good, but it may lack information about *why* the change is wanted. Overall, the series looks nice. Kind regards Uffe
hi Ulf Le 1/24/20 à 2:19 PM, Ulf Hansson a écrit : > On Fri, 24 Jan 2020 at 13:55, Ludovic BARRE <ludovic.barre@st.com> wrote: >> >> hi Ulf >> >> Just a "gentleman ping" on this series >> https://lkml.org/lkml/2020/1/10/392 > > I was just reviewing :-) Thanks for pinging! > > One overall comment is that I think you can try to work a bit on the > changelogs. In some cases you described what the patch does, which is > good, but it may lack information about *why* the change is wanted. Ok, I try to add a comment to *why* > > Overall, the series looks nice. > > Kind regards > Uffe >