Message ID | 20200125050256.107404-1-drinkcat@chromium.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | drm/panel: Fix boe,tv101wum-n53 htotal timing | expand |
Hi Nicolas. On Sat, Jan 25, 2020 at 01:02:56PM +0800, Nicolas Boichat wrote: > The datasheet suggests 60 for tHFP, so let's adjust the number > accordingly. > > This also makes the framerate be 60Hz as intended: > 159916.0 * 1000 / ((1200 + 80 + 24 + 60)*(1920 + 20 + 4 + 10)) > => 60.00 Hz > > Signed-off-by: Nicolas Boichat <drinkcat@chromium.org> Thanks. Added Fixes: tag and applied to drm-misc-next. Sam > > --- > > This also matches the values that we use in our chromeos-4.19 > vendor kernel. > > Applies on top or drm-misc/drm-misc-next. > > drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c > index 01faf8597700005..48a164257d18c35 100644 > --- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c > +++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c > @@ -645,7 +645,7 @@ static const struct drm_display_mode boe_tv101wum_n53_default_mode = { > .hdisplay = 1200, > .hsync_start = 1200 + 80, > .hsync_end = 1200 + 80 + 24, > - .htotal = 1200 + 80 + 24 + 40, > + .htotal = 1200 + 80 + 24 + 60, > .vdisplay = 1920, > .vsync_start = 1920 + 20, > .vsync_end = 1920 + 20 + 4, > -- > 2.25.0.341.g760bfbb309-goog
diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c index 01faf8597700005..48a164257d18c35 100644 --- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c +++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c @@ -645,7 +645,7 @@ static const struct drm_display_mode boe_tv101wum_n53_default_mode = { .hdisplay = 1200, .hsync_start = 1200 + 80, .hsync_end = 1200 + 80 + 24, - .htotal = 1200 + 80 + 24 + 40, + .htotal = 1200 + 80 + 24 + 60, .vdisplay = 1920, .vsync_start = 1920 + 20, .vsync_end = 1920 + 20 + 4,
The datasheet suggests 60 for tHFP, so let's adjust the number accordingly. This also makes the framerate be 60Hz as intended: 159916.0 * 1000 / ((1200 + 80 + 24 + 60)*(1920 + 20 + 4 + 10)) => 60.00 Hz Signed-off-by: Nicolas Boichat <drinkcat@chromium.org> --- This also matches the values that we use in our chromeos-4.19 vendor kernel. Applies on top or drm-misc/drm-misc-next. drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)