| Message ID | 20200126154257.41336-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 878508aed4776a5b08dcc000d33a01a42e3fd07d |
| Headers | show |
| Series | [next] i2c: xiic: fix indentation issue | expand |
On 26. 01. 20 16:42, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > There is a statment that is indented one level too deeply, remove typo ^ > the extraneous tab. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/i2c/busses/i2c-xiic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c > index b17d30c9ab40..90c1c362394d 100644 > --- a/drivers/i2c/busses/i2c-xiic.c > +++ b/drivers/i2c/busses/i2c-xiic.c > @@ -261,7 +261,7 @@ static int xiic_clear_rx_fifo(struct xiic_i2c *i2c) > xiic_getreg8(i2c, XIIC_DRR_REG_OFFSET); > if (time_after(jiffies, timeout)) { > dev_err(i2c->dev, "Failed to clear rx fifo\n"); > - return -ETIMEDOUT; > + return -ETIMEDOUT; > } > } When fixed. Acked-by: Michal Simek <michal.simek@xilinx.com> Thanks, Michal
On 27/01/2020 07:43, Michal Simek wrote: > On 26. 01. 20 16:42, Colin King wrote: >> From: Colin Ian King <colin.king@canonical.com> >> >> There is a statment that is indented one level too deeply, remove > > typo ^ Can this be fixed when the patch is applied rather than sending a V2? Colin > >> the extraneous tab. >> >> Signed-off-by: Colin Ian King <colin.king@canonical.com> >> --- >> drivers/i2c/busses/i2c-xiic.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c >> index b17d30c9ab40..90c1c362394d 100644 >> --- a/drivers/i2c/busses/i2c-xiic.c >> +++ b/drivers/i2c/busses/i2c-xiic.c >> @@ -261,7 +261,7 @@ static int xiic_clear_rx_fifo(struct xiic_i2c *i2c) >> xiic_getreg8(i2c, XIIC_DRR_REG_OFFSET); >> if (time_after(jiffies, timeout)) { >> dev_err(i2c->dev, "Failed to clear rx fifo\n"); >> - return -ETIMEDOUT; >> + return -ETIMEDOUT; >> } >> } > > When fixed. > > Acked-by: Michal Simek <michal.simek@xilinx.com> > > Thanks, > Michal > > > > > >
On 2020-01-27 10:26, Colin Ian King wrote: > On 27/01/2020 07:43, Michal Simek wrote: >> On 26. 01. 20 16:42, Colin King wrote: >>> From: Colin Ian King <colin.king@canonical.com> >>> >>> There is a statment that is indented one level too deeply, remove >> >> typo ^ > > Can this be fixed when the patch is applied rather than sending a V2? It can, but I think you will make it easier for Wolfram if you send a v2. Which is the right thing to do anyway since you are missing a Fixes tag. I think you should have one, since it is borderline if this patch is going to make it before 5.6. Cheers, Peter > Colin > >> >>> the extraneous tab. >>> >>> Signed-off-by: Colin Ian King <colin.king@canonical.com> >>> --- >>> drivers/i2c/busses/i2c-xiic.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c >>> index b17d30c9ab40..90c1c362394d 100644 >>> --- a/drivers/i2c/busses/i2c-xiic.c >>> +++ b/drivers/i2c/busses/i2c-xiic.c >>> @@ -261,7 +261,7 @@ static int xiic_clear_rx_fifo(struct xiic_i2c *i2c) >>> xiic_getreg8(i2c, XIIC_DRR_REG_OFFSET); >>> if (time_after(jiffies, timeout)) { >>> dev_err(i2c->dev, "Failed to clear rx fifo\n"); >>> - return -ETIMEDOUT; >>> + return -ETIMEDOUT; >>> } >>> } >> >> When fixed. >> >> Acked-by: Michal Simek <michal.simek@xilinx.com> >> >> Thanks, >> Michal >> >> >> >> >> >> >
diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index b17d30c9ab40..90c1c362394d 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -261,7 +261,7 @@ static int xiic_clear_rx_fifo(struct xiic_i2c *i2c) xiic_getreg8(i2c, XIIC_DRR_REG_OFFSET); if (time_after(jiffies, timeout)) { dev_err(i2c->dev, "Failed to clear rx fifo\n"); - return -ETIMEDOUT; + return -ETIMEDOUT; } }