[V6,0/3] firmware: arm_scmi: Make scmi core independent of the transport type

Message

Viresh Kumar Jan. 31, 2020, 5:28 a.m. UTC

Hello,

This patchset makes the scmi core (driver.c) independent of mailbox
transport.

V5->V6:
- Divide the patchset into multiple logical patches.
- Create shmem.c to separate out shared mem related helpers.
- Make mark_txdone() optional.
- Drop inclusion of stddef.h.

V4->V5:
- struct scmi_shared_mem is moved to mailbox.c and it is completely
  handled by transport layer now.
- And so lots of ops change due to this.
- Fixed a bug from previous version where wrong dev structure was
  getting passed to devm_kzalloc().

V3->V4:
- Rebased on top of linux-next.

V2->V3:
- Added more ops to the structure to read/write/memcpy data
- Payload is moved to mailbox.c and is handled in transport specific way
  now. This resulted in lots of changes.

V1->V2:
- Dropped __iomem from payload data.
- Moved transport ops to scmi_desc, and that has a per transport
  instance now which is differentiated using the compatible string.
- Converted IS_ERR_OR_NULL to IS_ERR.

Viresh Kumar (3):
  firmware: arm_scmi: Update doc style comments
  firmware: arm_scmi: Move macros and helpers to common.h
  firmware: arm_scmi: Make scmi core independent of the transport type

 drivers/firmware/arm_scmi/Makefile  |   3 +-
 drivers/firmware/arm_scmi/common.h  | 112 ++++++++++-
 drivers/firmware/arm_scmi/driver.c  | 293 ++++------------------------
 drivers/firmware/arm_scmi/mailbox.c | 184 +++++++++++++++++
 drivers/firmware/arm_scmi/shmem.c   |  82 ++++++++
 5 files changed, 412 insertions(+), 262 deletions(-)
 create mode 100644 drivers/firmware/arm_scmi/mailbox.c
 create mode 100644 drivers/firmware/arm_scmi/shmem.c

Comments

Sudeep Holla Jan. 31, 2020, 3:28 p.m. UTC | #1

On Fri, Jan 31, 2020 at 10:58:10AM +0530, Viresh Kumar wrote:
> Hello,
>
> This patchset makes the scmi core (driver.c) independent of mailbox
> transport.
>

This version looks all good to me. I will apply for v5.7 once the merge
window is closed and v5.6-rc1 is tagged. Thanks for doing this.

--
Regards,
Sudeep