| Message ID | 20200131143650.4149-2-linux@weissschuh.net (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | platform/x86: thinkpad_acpi: use standard charge control attribute names | expand |
On Fri, Jan 31, 2020 at 03:36:48PM +0100, Thomas Weißschuh wrote: > They were never used. Thanks for the series. Unfortunately I may not proceed it since it misses our patchwork [1] for some reason. Besides that, this patch is okay, but the rest two must be: - unified together to avoid regression in the middle - done other way around, simple add aliases to *old* ones Don't forget to update any documentation if needed. [1]: https://patchwork.kernel.org/project/platform-driver-x86/list/ > > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> > --- > drivers/platform/x86/thinkpad_acpi.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c > index da794dcfdd92..2d3a99e3efb7 100644 > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -9323,9 +9323,6 @@ static struct ibm_struct mute_led_driver_data = { > #define GET_STOP "BCSG" > #define SET_STOP "BCSS" > > -#define START_ATTR "charge_start_threshold" > -#define STOP_ATTR "charge_stop_threshold" > - > enum { > BAT_ANY = 0, > BAT_PRIMARY = 1,
On Mon, Feb 03, 2020 at 12:00:43PM +0200, Andy Shevchenko wrote: > On Fri, Jan 31, 2020 at 03:36:48PM +0100, Thomas Weißschuh wrote: > > They were never used. > > Thanks for the series. > > Unfortunately I may not proceed it since it misses our patchwork [1] > for some reason. Oh, sorry! It misses our *mailing list* while patchwork is good. > Besides that, this patch is okay, but the rest two must be: > - unified together to avoid regression in the middle > - done other way around, simple add aliases to *old* ones > > Don't forget to update any documentation if needed. > > [1]: https://patchwork.kernel.org/project/platform-driver-x86/list/
On Mon, Feb 03, 2020 at 12:02:11PM +0200, Andy Shevchenko wrote: > On Mon, Feb 03, 2020 at 12:00:43PM +0200, Andy Shevchenko wrote: > > On Fri, Jan 31, 2020 at 03:36:48PM +0100, Thomas Weißschuh wrote: > > > They were never used. > > > > Thanks for the series. > > > > Unfortunately I may not proceed it since it misses our patchwork [1] > > for some reason. > > Oh, sorry! It misses our *mailing list* while patchwork is good. Found your mails in archive (on the Web), so, it seems Google (gmail) doesn't like them. It seems no issue on your side. Anyway, I'm waiting for v3 as commented previously. > > Besides that, this patch is okay, but the rest two must be: > > - unified together to avoid regression in the middle > > - done other way around, simple add aliases to *old* ones > > > > Don't forget to update any documentation if needed. > > > > [1]: https://patchwork.kernel.org/project/platform-driver-x86/list/
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index da794dcfdd92..2d3a99e3efb7 100644 --- a/drivers/platform/x86/thinkpad_acpi.c +++ b/drivers/platform/x86/thinkpad_acpi.c @@ -9323,9 +9323,6 @@ static struct ibm_struct mute_led_driver_data = { #define GET_STOP "BCSG" #define SET_STOP "BCSS" -#define START_ATTR "charge_start_threshold" -#define STOP_ATTR "charge_stop_threshold" - enum { BAT_ANY = 0, BAT_PRIMARY = 1,
They were never used. Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> --- drivers/platform/x86/thinkpad_acpi.c | 3 --- 1 file changed, 3 deletions(-)