| Message ID | 20200204062312.19913-11-sj38.park@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Introduce Data Access MONitor (DAMON) | expand |
Hi,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.5]
[cannot apply to next-20200205]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/sj38-park-gmail-com/Introduce-Data-Access-MONitor-DAMON/20200204-143127
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 322bf2d3446aabdaf5e8887775bd9ced80dbc0f0
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.5.0-3) 7.5.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
In file included from include/linux/list.h:9:0,
from include/linux/random.h:10,
from include/linux/damon.h:13,
from mm/damon.c:14:
mm/damon-test.h: In function 'damon_test_str_to_pids':
include/linux/kernel.h:835:29: warning: comparison of distinct pointer types lacks a cast
(!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
^
>> include/kunit/test.h:510:9: note: in expansion of macro '__typecheck'
((void)__typecheck(__left, __right)); \
^~~~~~~~~~~
>> include/kunit/test.h:534:2: note: in expansion of macro 'KUNIT_BASE_BINARY_ASSERTION'
KUNIT_BASE_BINARY_ASSERTION(test, \
^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> include/kunit/test.h:623:2: note: in expansion of macro 'KUNIT_BASE_EQ_MSG_ASSERTION'
KUNIT_BASE_EQ_MSG_ASSERTION(test, \
^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> include/kunit/test.h:633:2: note: in expansion of macro 'KUNIT_BINARY_EQ_MSG_ASSERTION'
KUNIT_BINARY_EQ_MSG_ASSERTION(test, \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> include/kunit/test.h:996:2: note: in expansion of macro 'KUNIT_BINARY_EQ_ASSERTION'
KUNIT_BINARY_EQ_ASSERTION(test, KUNIT_EXPECTATION, left, right)
^~~~~~~~~~~~~~~~~~~~~~~~~
>> mm/damon-test.h:26:2: note: in expansion of macro 'KUNIT_EXPECT_EQ'
KUNIT_EXPECT_EQ(test, 1l, nr_integers);
^~~~~~~~~~~~~~~
include/linux/kernel.h:835:29: warning: comparison of distinct pointer types lacks a cast
(!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
^
>> include/kunit/test.h:510:9: note: in expansion of macro '__typecheck'
((void)__typecheck(__left, __right)); \
^~~~~~~~~~~
>> include/kunit/test.h:534:2: note: in expansion of macro 'KUNIT_BASE_BINARY_ASSERTION'
KUNIT_BASE_BINARY_ASSERTION(test, \
^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> include/kunit/test.h:623:2: note: in expansion of macro 'KUNIT_BASE_EQ_MSG_ASSERTION'
KUNIT_BASE_EQ_MSG_ASSERTION(test, \
^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> include/kunit/test.h:633:2: note: in expansion of macro 'KUNIT_BINARY_EQ_MSG_ASSERTION'
KUNIT_BINARY_EQ_MSG_ASSERTION(test, \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> include/kunit/test.h:996:2: note: in expansion of macro 'KUNIT_BINARY_EQ_ASSERTION'
KUNIT_BINARY_EQ_ASSERTION(test, KUNIT_EXPECTATION, left, right)
^~~~~~~~~~~~~~~~~~~~~~~~~
mm/damon-test.h:32:2: note: in expansion of macro 'KUNIT_EXPECT_EQ'
KUNIT_EXPECT_EQ(test, 1l, nr_integers);
^~~~~~~~~~~~~~~
include/linux/kernel.h:835:29: warning: comparison of distinct pointer types lacks a cast
(!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
^
>> include/kunit/test.h:510:9: note: in expansion of macro '__typecheck'
((void)__typecheck(__left, __right)); \
^~~~~~~~~~~
>> include/kunit/test.h:534:2: note: in expansion of macro 'KUNIT_BASE_BINARY_ASSERTION'
KUNIT_BASE_BINARY_ASSERTION(test, \
^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> include/kunit/test.h:623:2: note: in expansion of macro 'KUNIT_BASE_EQ_MSG_ASSERTION'
KUNIT_BASE_EQ_MSG_ASSERTION(test, \
^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> include/kunit/test.h:633:2: note: in expansion of macro 'KUNIT_BINARY_EQ_MSG_ASSERTION'
KUNIT_BINARY_EQ_MSG_ASSERTION(test, \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> include/kunit/test.h:996:2: note: in expansion of macro 'KUNIT_BINARY_EQ_ASSERTION'
KUNIT_BINARY_EQ_ASSERTION(test, KUNIT_EXPECTATION, left, right)
^~~~~~~~~~~~~~~~~~~~~~~~~
mm/damon-test.h:38:2: note: in expansion of macro 'KUNIT_EXPECT_EQ'
KUNIT_EXPECT_EQ(test, 0l, nr_integers);
^~~~~~~~~~~~~~~
include/linux/kernel.h:835:29: warning: comparison of distinct pointer types lacks a cast
(!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
^
>> include/kunit/test.h:510:9: note: in expansion of macro '__typecheck'
((void)__typecheck(__left, __right)); \
^~~~~~~~~~~
>> include/kunit/test.h:534:2: note: in expansion of macro 'KUNIT_BASE_BINARY_ASSERTION'
KUNIT_BASE_BINARY_ASSERTION(test, \
^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> include/kunit/test.h:623:2: note: in expansion of macro 'KUNIT_BASE_EQ_MSG_ASSERTION'
KUNIT_BASE_EQ_MSG_ASSERTION(test, \
^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> include/kunit/test.h:633:2: note: in expansion of macro 'KUNIT_BINARY_EQ_MSG_ASSERTION'
KUNIT_BINARY_EQ_MSG_ASSERTION(test, \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/__typecheck +510 include/kunit/test.h
73cda7bb8bfb1d Brendan Higgins 2019-09-23 419
73cda7bb8bfb1d Brendan Higgins 2019-09-23 420
73cda7bb8bfb1d Brendan Higgins 2019-09-23 421 #define KUNIT_FAIL_ASSERTION(test, assert_type, fmt, ...) \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 422 KUNIT_ASSERTION(test, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 423 false, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 424 kunit_fail_assert, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 425 KUNIT_INIT_FAIL_ASSERT_STRUCT(test, assert_type), \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 426 fmt, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 427 ##__VA_ARGS__)
73cda7bb8bfb1d Brendan Higgins 2019-09-23 428
73cda7bb8bfb1d Brendan Higgins 2019-09-23 429 /**
73cda7bb8bfb1d Brendan Higgins 2019-09-23 430 * KUNIT_FAIL() - Always causes a test to fail when evaluated.
73cda7bb8bfb1d Brendan Higgins 2019-09-23 431 * @test: The test context object.
73cda7bb8bfb1d Brendan Higgins 2019-09-23 432 * @fmt: an informational message to be printed when the assertion is made.
73cda7bb8bfb1d Brendan Higgins 2019-09-23 433 * @...: string format arguments.
73cda7bb8bfb1d Brendan Higgins 2019-09-23 434 *
73cda7bb8bfb1d Brendan Higgins 2019-09-23 435 * The opposite of KUNIT_SUCCEED(), it is an expectation that always fails. In
73cda7bb8bfb1d Brendan Higgins 2019-09-23 436 * other words, it always results in a failed expectation, and consequently
73cda7bb8bfb1d Brendan Higgins 2019-09-23 437 * always causes the test case to fail when evaluated. See KUNIT_EXPECT_TRUE()
73cda7bb8bfb1d Brendan Higgins 2019-09-23 438 * for more information.
73cda7bb8bfb1d Brendan Higgins 2019-09-23 439 */
73cda7bb8bfb1d Brendan Higgins 2019-09-23 440 #define KUNIT_FAIL(test, fmt, ...) \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 441 KUNIT_FAIL_ASSERTION(test, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 442 KUNIT_EXPECTATION, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 443 fmt, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 444 ##__VA_ARGS__)
73cda7bb8bfb1d Brendan Higgins 2019-09-23 445
73cda7bb8bfb1d Brendan Higgins 2019-09-23 446 #define KUNIT_UNARY_ASSERTION(test, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 447 assert_type, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 448 condition, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 449 expected_true, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 450 fmt, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 451 ...) \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 452 KUNIT_ASSERTION(test, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 453 !!(condition) == !!expected_true, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 454 kunit_unary_assert, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 455 KUNIT_INIT_UNARY_ASSERT_STRUCT(test, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 456 assert_type, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 457 #condition, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 458 expected_true), \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 459 fmt, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 460 ##__VA_ARGS__)
73cda7bb8bfb1d Brendan Higgins 2019-09-23 461
73cda7bb8bfb1d Brendan Higgins 2019-09-23 462 #define KUNIT_TRUE_MSG_ASSERTION(test, assert_type, condition, fmt, ...) \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 463 KUNIT_UNARY_ASSERTION(test, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 464 assert_type, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 465 condition, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 466 true, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 467 fmt, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 468 ##__VA_ARGS__)
73cda7bb8bfb1d Brendan Higgins 2019-09-23 469
73cda7bb8bfb1d Brendan Higgins 2019-09-23 470 #define KUNIT_TRUE_ASSERTION(test, assert_type, condition) \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 471 KUNIT_TRUE_MSG_ASSERTION(test, assert_type, condition, NULL)
73cda7bb8bfb1d Brendan Higgins 2019-09-23 472
73cda7bb8bfb1d Brendan Higgins 2019-09-23 473 #define KUNIT_FALSE_MSG_ASSERTION(test, assert_type, condition, fmt, ...) \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 474 KUNIT_UNARY_ASSERTION(test, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 475 assert_type, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 476 condition, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 477 false, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 478 fmt, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 479 ##__VA_ARGS__)
73cda7bb8bfb1d Brendan Higgins 2019-09-23 480
73cda7bb8bfb1d Brendan Higgins 2019-09-23 481 #define KUNIT_FALSE_ASSERTION(test, assert_type, condition) \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 482 KUNIT_FALSE_MSG_ASSERTION(test, assert_type, condition, NULL)
73cda7bb8bfb1d Brendan Higgins 2019-09-23 483
73cda7bb8bfb1d Brendan Higgins 2019-09-23 484 /*
73cda7bb8bfb1d Brendan Higgins 2019-09-23 485 * A factory macro for defining the assertions and expectations for the basic
73cda7bb8bfb1d Brendan Higgins 2019-09-23 486 * comparisons defined for the built in types.
73cda7bb8bfb1d Brendan Higgins 2019-09-23 487 *
73cda7bb8bfb1d Brendan Higgins 2019-09-23 488 * Unfortunately, there is no common type that all types can be promoted to for
73cda7bb8bfb1d Brendan Higgins 2019-09-23 489 * which all the binary operators behave the same way as for the actual types
73cda7bb8bfb1d Brendan Higgins 2019-09-23 490 * (for example, there is no type that long long and unsigned long long can
73cda7bb8bfb1d Brendan Higgins 2019-09-23 491 * both be cast to where the comparison result is preserved for all values). So
73cda7bb8bfb1d Brendan Higgins 2019-09-23 492 * the best we can do is do the comparison in the original types and then coerce
73cda7bb8bfb1d Brendan Higgins 2019-09-23 493 * everything to long long for printing; this way, the comparison behaves
73cda7bb8bfb1d Brendan Higgins 2019-09-23 494 * correctly and the printed out value usually makes sense without
73cda7bb8bfb1d Brendan Higgins 2019-09-23 495 * interpretation, but can always be interpreted to figure out the actual
73cda7bb8bfb1d Brendan Higgins 2019-09-23 496 * value.
73cda7bb8bfb1d Brendan Higgins 2019-09-23 497 */
73cda7bb8bfb1d Brendan Higgins 2019-09-23 498 #define KUNIT_BASE_BINARY_ASSERTION(test, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 499 assert_class, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 500 ASSERT_CLASS_INIT, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 501 assert_type, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 502 left, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 503 op, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 504 right, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 505 fmt, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 506 ...) \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 507 do { \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 508 typeof(left) __left = (left); \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 509 typeof(right) __right = (right); \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 @510 ((void)__typecheck(__left, __right)); \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 511 \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 512 KUNIT_ASSERTION(test, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 513 __left op __right, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 514 assert_class, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 515 ASSERT_CLASS_INIT(test, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 516 assert_type, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 517 #op, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 518 #left, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 519 __left, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 520 #right, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 521 __right), \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 522 fmt, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 523 ##__VA_ARGS__); \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 524 } while (0)
73cda7bb8bfb1d Brendan Higgins 2019-09-23 525
73cda7bb8bfb1d Brendan Higgins 2019-09-23 526 #define KUNIT_BASE_EQ_MSG_ASSERTION(test, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 527 assert_class, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 528 ASSERT_CLASS_INIT, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 529 assert_type, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 530 left, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 531 right, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 532 fmt, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 533 ...) \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 @534 KUNIT_BASE_BINARY_ASSERTION(test, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 535 assert_class, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 536 ASSERT_CLASS_INIT, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 537 assert_type, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 538 left, ==, right, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 539 fmt, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 540 ##__VA_ARGS__)
73cda7bb8bfb1d Brendan Higgins 2019-09-23 541
73cda7bb8bfb1d Brendan Higgins 2019-09-23 542 #define KUNIT_BASE_NE_MSG_ASSERTION(test, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 543 assert_class, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 544 ASSERT_CLASS_INIT, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 545 assert_type, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 546 left, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 547 right, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 548 fmt, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 549 ...) \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 550 KUNIT_BASE_BINARY_ASSERTION(test, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 551 assert_class, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 552 ASSERT_CLASS_INIT, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 553 assert_type, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 554 left, !=, right, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 555 fmt, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 556 ##__VA_ARGS__)
73cda7bb8bfb1d Brendan Higgins 2019-09-23 557
73cda7bb8bfb1d Brendan Higgins 2019-09-23 558 #define KUNIT_BASE_LT_MSG_ASSERTION(test, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 559 assert_class, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 560 ASSERT_CLASS_INIT, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 561 assert_type, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 562 left, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 563 right, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 564 fmt, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 565 ...) \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 566 KUNIT_BASE_BINARY_ASSERTION(test, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 567 assert_class, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 568 ASSERT_CLASS_INIT, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 569 assert_type, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 570 left, <, right, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 571 fmt, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 572 ##__VA_ARGS__)
73cda7bb8bfb1d Brendan Higgins 2019-09-23 573
73cda7bb8bfb1d Brendan Higgins 2019-09-23 574 #define KUNIT_BASE_LE_MSG_ASSERTION(test, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 575 assert_class, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 576 ASSERT_CLASS_INIT, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 577 assert_type, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 578 left, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 579 right, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 580 fmt, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 581 ...) \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 582 KUNIT_BASE_BINARY_ASSERTION(test, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 583 assert_class, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 584 ASSERT_CLASS_INIT, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 585 assert_type, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 586 left, <=, right, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 587 fmt, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 588 ##__VA_ARGS__)
73cda7bb8bfb1d Brendan Higgins 2019-09-23 589
73cda7bb8bfb1d Brendan Higgins 2019-09-23 590 #define KUNIT_BASE_GT_MSG_ASSERTION(test, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 591 assert_class, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 592 ASSERT_CLASS_INIT, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 593 assert_type, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 594 left, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 595 right, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 596 fmt, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 597 ...) \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 598 KUNIT_BASE_BINARY_ASSERTION(test, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 599 assert_class, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 600 ASSERT_CLASS_INIT, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 601 assert_type, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 602 left, >, right, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 603 fmt, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 604 ##__VA_ARGS__)
73cda7bb8bfb1d Brendan Higgins 2019-09-23 605
73cda7bb8bfb1d Brendan Higgins 2019-09-23 606 #define KUNIT_BASE_GE_MSG_ASSERTION(test, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 607 assert_class, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 608 ASSERT_CLASS_INIT, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 609 assert_type, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 610 left, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 611 right, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 612 fmt, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 613 ...) \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 614 KUNIT_BASE_BINARY_ASSERTION(test, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 615 assert_class, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 616 ASSERT_CLASS_INIT, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 617 assert_type, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 618 left, >=, right, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 619 fmt, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 620 ##__VA_ARGS__)
73cda7bb8bfb1d Brendan Higgins 2019-09-23 621
73cda7bb8bfb1d Brendan Higgins 2019-09-23 622 #define KUNIT_BINARY_EQ_MSG_ASSERTION(test, assert_type, left, right, fmt, ...)\
73cda7bb8bfb1d Brendan Higgins 2019-09-23 @623 KUNIT_BASE_EQ_MSG_ASSERTION(test, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 624 kunit_binary_assert, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 625 KUNIT_INIT_BINARY_ASSERT_STRUCT, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 626 assert_type, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 627 left, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 628 right, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 629 fmt, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 630 ##__VA_ARGS__)
73cda7bb8bfb1d Brendan Higgins 2019-09-23 631
73cda7bb8bfb1d Brendan Higgins 2019-09-23 632 #define KUNIT_BINARY_EQ_ASSERTION(test, assert_type, left, right) \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 @633 KUNIT_BINARY_EQ_MSG_ASSERTION(test, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 634 assert_type, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 635 left, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 636 right, \
73cda7bb8bfb1d Brendan Higgins 2019-09-23 637 NULL)
73cda7bb8bfb1d Brendan Higgins 2019-09-23 638
:::::: The code at line 510 was first introduced by commit
:::::: 73cda7bb8bfb1d4be0325d76172950ede1a65fd0 kunit: test: add the concept of expectations
:::::: TO: Brendan Higgins <brendanhiggins@google.com>
:::::: CC: Shuah Khan <skhan@linuxfoundation.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
diff --git a/mm/Kconfig b/mm/Kconfig index 387d469f40ec..b279ab9c78d0 100644 --- a/mm/Kconfig +++ b/mm/Kconfig @@ -751,4 +751,15 @@ config DAMON be 1) accurate enough to be useful for performance-centric domains, and 2) sufficiently light-weight so that it can be applied online. +config DAMON_KUNIT_TEST + bool "Test for damon" + depends on DAMON && KUNIT + help + This builds the DAMON Kunit test suite. + + For more information on KUnit and unit tests in general, please refer + to the KUnit documentation. + + If unsure, say N. + endmenu diff --git a/mm/damon-test.h b/mm/damon-test.h new file mode 100644 index 000000000000..ad3ffd1c20e2 --- /dev/null +++ b/mm/damon-test.h @@ -0,0 +1,604 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Data Access Monitor Unit Tests + * + * Copyright 2019 Amazon.com, Inc. or its affiliates. All rights reserved. + * + * Author: SeongJae Park <sjpark@amazon.de> + */ + +#ifdef CONFIG_DAMON_KUNIT_TEST + +#ifndef _DAMON_TEST_H +#define _DAMON_TEST_H + +#include <kunit/test.h> + +static void damon_test_str_to_pids(struct kunit *test) +{ + char *question; + unsigned long *answers; + unsigned long expected[] = {12, 35, 46}; + ssize_t nr_integers = 0, i; + + question = "123"; + answers = str_to_pids(question, strnlen(question, 128), &nr_integers); + KUNIT_EXPECT_EQ(test, 1l, nr_integers); + KUNIT_EXPECT_EQ(test, 123ul, answers[0]); + kfree(answers); + + question = "123abc"; + answers = str_to_pids(question, strnlen(question, 128), &nr_integers); + KUNIT_EXPECT_EQ(test, 1l, nr_integers); + KUNIT_EXPECT_EQ(test, 123ul, answers[0]); + kfree(answers); + + question = "a123"; + answers = str_to_pids(question, strnlen(question, 128), &nr_integers); + KUNIT_EXPECT_EQ(test, 0l, nr_integers); + KUNIT_EXPECT_PTR_EQ(test, answers, (unsigned long *)NULL); + + question = "12 35"; + answers = str_to_pids(question, strnlen(question, 128), &nr_integers); + KUNIT_EXPECT_EQ(test, 2l, nr_integers); + for (i = 0; i < nr_integers; i++) + KUNIT_EXPECT_EQ(test, expected[i], answers[i]); + kfree(answers); + + question = "12 35 46"; + answers = str_to_pids(question, strnlen(question, 128), &nr_integers); + KUNIT_EXPECT_EQ(test, 3l, nr_integers); + for (i = 0; i < nr_integers; i++) + KUNIT_EXPECT_EQ(test, expected[i], answers[i]); + kfree(answers); + + question = "12 35 abc 46"; + answers = str_to_pids(question, strnlen(question, 128), &nr_integers); + KUNIT_EXPECT_EQ(test, 2l, nr_integers); + for (i = 0; i < 2; i++) + KUNIT_EXPECT_EQ(test, expected[i], answers[i]); + kfree(answers); + + question = ""; + answers = str_to_pids(question, strnlen(question, 128), &nr_integers); + KUNIT_EXPECT_EQ(test, 0l, nr_integers); + KUNIT_EXPECT_PTR_EQ(test, (unsigned long *)NULL, answers); + kfree(answers); + + question = "\n"; + answers = str_to_pids(question, strnlen(question, 128), &nr_integers); + KUNIT_EXPECT_EQ(test, 0l, nr_integers); + KUNIT_EXPECT_PTR_EQ(test, (unsigned long *)NULL, answers); + kfree(answers); +} + +static void damon_test_regions(struct kunit *test) +{ + struct damon_region *r; + struct damon_task *t; + + r = damon_new_region(&damon_user_ctx, 1, 2); + KUNIT_EXPECT_EQ(test, 1ul, r->vm_start); + KUNIT_EXPECT_EQ(test, 2ul, r->vm_end); + KUNIT_EXPECT_EQ(test, 0u, r->nr_accesses); + KUNIT_EXPECT_TRUE(test, r->sampling_addr >= r->vm_start); + KUNIT_EXPECT_TRUE(test, r->sampling_addr < r->vm_end); + + t = damon_new_task(42); + KUNIT_EXPECT_EQ(test, 0u, nr_damon_regions(t)); + + damon_add_region_tail(r, t); + KUNIT_EXPECT_EQ(test, 1u, nr_damon_regions(t)); + + damon_del_region(r); + KUNIT_EXPECT_EQ(test, 0u, nr_damon_regions(t)); + + damon_free_task(t); +} + +static void damon_test_tasks(struct kunit *test) +{ + struct damon_ctx *c = &damon_user_ctx; + struct damon_task *t; + + t = damon_new_task(42); + KUNIT_EXPECT_EQ(test, 42ul, t->pid); + KUNIT_EXPECT_EQ(test, 0u, nr_damon_tasks(c)); + + damon_add_task_tail(&damon_user_ctx, t); + KUNIT_EXPECT_EQ(test, 1u, nr_damon_tasks(c)); + + damon_destroy_task(t); + KUNIT_EXPECT_EQ(test, 0u, nr_damon_tasks(c)); +} + +static void damon_test_set_pids(struct kunit *test) +{ + struct damon_ctx *ctx = &damon_user_ctx; + unsigned long pids[] = {1, 2, 3}; + char buf[64]; + + damon_set_pids(ctx, pids, 3); + damon_sprint_pids(ctx, buf, 64); + KUNIT_EXPECT_STREQ(test, (char *)buf, "1 2 3\n"); + + damon_set_pids(ctx, NULL, 0); + damon_sprint_pids(ctx, buf, 64); + KUNIT_EXPECT_STREQ(test, (char *)buf, "\n"); + + damon_set_pids(ctx, (unsigned long []){1, 2}, 2); + damon_sprint_pids(ctx, buf, 64); + KUNIT_EXPECT_STREQ(test, (char *)buf, "1 2\n"); + + damon_set_pids(ctx, (unsigned long []){2}, 1); + damon_sprint_pids(ctx, buf, 64); + KUNIT_EXPECT_STREQ(test, (char *)buf, "2\n"); + + damon_set_pids(ctx, NULL, 0); + damon_sprint_pids(ctx, buf, 64); + KUNIT_EXPECT_STREQ(test, (char *)buf, "\n"); +} + +/* + * Test damon_three_regions_in_vmas() function + * + * DAMON converts the complex and dynamic memory mappings of each target task + * to three discontiguous regions which cover every mapped areas. However, the + * three regions should not include the two biggest unmapped areas in the + * original mapping, because the two biggest areas are normally the areas + * between 1) heap and the mmap()-ed regions, and 2) the mmap()-ed regions and + * stack. Because these two unmapped areas are very huge but obviously never + * accessed, covering the region is just a waste. + * + * 'damon_three_regions_in_vmas() receives an address space of a process. It + * first identifies the start of mappings, end of mappings, and the two biggest + * unmapped areas. After that, based on the information, it constructs the + * three regions and returns. For more detail, refer to the comment of + * 'damon_init_regions_of()' function definition in 'mm/damon.c' file. + * + * For example, suppose virtual address ranges of 10-20, 20-25, 200-210, + * 210-220, 300-305, and 307-330 (Other comments represent this mappings in + * more short form: 10-20-25, 200-210-220, 300-305, 307-330) of a process are + * mapped. To cover every mappings, the three regions should start with 10, + * and end with 305. The process also has three unmapped areas, 25-200, + * 220-300, and 305-307. Among those, 25-200 and 220-300 are the biggest two + * unmapped areas, and thus it should be converted to three regions of 10-25, + * 200-220, and 300-330. + */ +static void damon_test_three_regions_in_vmas(struct kunit *test) +{ + struct region regions[3] = {0,}; + /* 10-20-25, 200-210-220, 300-305, 307-330 */ + struct vm_area_struct vmas[] = { + (struct vm_area_struct) {.vm_start = 10, .vm_end = 20}, + (struct vm_area_struct) {.vm_start = 20, .vm_end = 25}, + (struct vm_area_struct) {.vm_start = 200, .vm_end = 210}, + (struct vm_area_struct) {.vm_start = 210, .vm_end = 220}, + (struct vm_area_struct) {.vm_start = 300, .vm_end = 305}, + (struct vm_area_struct) {.vm_start = 307, .vm_end = 330}, + }; + vmas[0].vm_next = &vmas[1]; + vmas[1].vm_next = &vmas[2]; + vmas[2].vm_next = &vmas[3]; + vmas[3].vm_next = &vmas[4]; + vmas[4].vm_next = &vmas[5]; + vmas[5].vm_next = NULL; + + damon_three_regions_in_vmas(&vmas[0], regions); + + KUNIT_EXPECT_EQ(test, 10ul, regions[0].start); + KUNIT_EXPECT_EQ(test, 25ul, regions[0].end); + KUNIT_EXPECT_EQ(test, 200ul, regions[1].start); + KUNIT_EXPECT_EQ(test, 220ul, regions[1].end); + KUNIT_EXPECT_EQ(test, 300ul, regions[2].start); + KUNIT_EXPECT_EQ(test, 330ul, regions[2].end); +} + +/* Clean up global state of damon */ +static void damon_cleanup_global_state(void) +{ + struct damon_task *t, *next; + + damon_for_each_task_safe(&damon_user_ctx, t, next) + damon_destroy_task(t); + + damon_user_ctx.rbuf_offset = 0; +} + +/* + * Test kdamond_flush_aggregated() + * + * DAMON checks access to each region and aggregates this information as the + * access frequency of each region. In detail, it increases '->nr_accesses' of + * regions that an access has confirmed. 'kdamond_flush_aggregated()' flushes + * the aggregated information ('->nr_accesses' of each regions) to the result + * buffer. As a result of the flushing, the '->nr_accesses' of regions are + * initialized to zero. + */ +static void damon_test_aggregate(struct kunit *test) +{ + struct damon_ctx *ctx = &damon_user_ctx; + unsigned long pids[] = {1, 2, 3}; + unsigned long saddr[][3] = {{10, 20, 30}, {5, 42, 49}, {13, 33, 55} }; + unsigned long eaddr[][3] = {{15, 27, 40}, {31, 45, 55}, {23, 44, 66} }; + unsigned long accesses[][3] = {{42, 95, 84}, {10, 20, 30}, {0, 1, 2} }; + struct damon_task *t; + struct damon_region *r; + int it, ir; + ssize_t sz, sr, sp; + + damon_set_recording(ctx, 256, "damon.data"); + damon_set_pids(ctx, pids, 3); + + it = 0; + damon_for_each_task(ctx, t) { + for (ir = 0; ir < 3; ir++) { + r = damon_new_region(ctx, + saddr[it][ir], eaddr[it][ir]); + r->nr_accesses = accesses[it][ir]; + damon_add_region_tail(r, t); + } + it++; + } + kdamond_flush_aggregated(ctx); + it = 0; + damon_for_each_task(ctx, t) { + ir = 0; + /* '->nr_accesses' should be zeroed */ + damon_for_each_region(r, t) { + KUNIT_EXPECT_EQ(test, 0u, r->nr_accesses); + ir++; + } + /* regions should be preserved */ + KUNIT_EXPECT_EQ(test, 3, ir); + it++; + } + /* tasks also should be preserved */ + KUNIT_EXPECT_EQ(test, 3, it); + + /* The aggregated information should be written in the buffer */ + sr = sizeof(r->vm_start) + sizeof(r->vm_end) + sizeof(r->nr_accesses); + sp = sizeof(t->pid) + sizeof(unsigned int) + 3 * sr; + sz = sizeof(struct timespec64) + sizeof(unsigned int) + 3 * sp; + KUNIT_EXPECT_EQ(test, (unsigned int)sz, ctx->rbuf_offset); + + damon_set_recording(ctx, 0, "damon.data"); + damon_cleanup_global_state(); +} + +static void damon_test_write_rbuf(struct kunit *test) +{ + struct damon_ctx *ctx = &damon_user_ctx; + char *data; + + damon_set_recording(&damon_user_ctx, 256, "damon.data"); + + data = "hello"; + damon_write_rbuf(ctx, data, strnlen(data, 256)); + KUNIT_EXPECT_EQ(test, ctx->rbuf_offset, 5u); + + damon_write_rbuf(ctx, data, 0); + KUNIT_EXPECT_EQ(test, ctx->rbuf_offset, 5u); + + KUNIT_EXPECT_STREQ(test, (char *)ctx->rbuf, data); + damon_set_recording(&damon_user_ctx, 0, "damon.data"); +} + +/* + * Test 'damon_apply_three_regions()' + * + * test kunit object + * regions an array containing start/end addresses of current + * monitoring target regions + * nr_regions the number of the addresses in 'regions' + * three_regions The three regions that need to be applied now + * expected start/end addresses of monitoring target regions that + * 'three_regions' are applied + * nr_expected the number of addresses in 'expected' + * + * The memory mapping of the target processes changes dynamically. To follow + * the change, DAMON periodically reads the mappings, simplifies it to the + * three regions, and updates the monitoring target regions to fit in the three + * regions. The update of current target regions is the role of + * 'damon_apply_three_regions()'. + * + * This test passes the given target regions and the new three regions that + * need to be applied to the function and check whether it updates the regions + * as expected. + */ +static void damon_do_test_apply_three_regions(struct kunit *test, + unsigned long *regions, int nr_regions, + struct region *three_regions, + unsigned long *expected, int nr_expected) +{ + struct damon_task *t; + struct damon_region *r; + int i; + + t = damon_new_task(42); + for (i = 0; i < nr_regions / 2; i++) { + r = damon_new_region(&damon_user_ctx, + regions[i * 2], regions[i * 2 + 1]); + damon_add_region_tail(r, t); + } + damon_add_task_tail(&damon_user_ctx, t); + + damon_apply_three_regions(&damon_user_ctx, t, three_regions); + + for (i = 0; i < nr_expected / 2; i++) { + r = damon_nth_region_of(t, i); + KUNIT_EXPECT_EQ(test, r->vm_start, expected[i * 2]); + KUNIT_EXPECT_EQ(test, r->vm_end, expected[i * 2 + 1]); + } + + damon_cleanup_global_state(); +} + +/* + * This function test most common case where the three big regions are only + * slightly changed. Target regions should adjust their boundary (10-20-30, + * 50-55, 70-80, 90-100) to fit with the new big regions or remove target + * regions (57-79) that now out of the three regions. + */ +static void damon_test_apply_three_regions1(struct kunit *test) +{ + /* 10-20-30, 50-55-57-59, 70-80-90-100 */ + unsigned long regions[] = {10, 20, 20, 30, 50, 55, 55, 57, 57, 59, + 70, 80, 80, 90, 90, 100}; + /* 5-27, 45-55, 73-104 */ + struct region new_three_regions[3] = { + (struct region){.start = 5, .end = 27}, + (struct region){.start = 45, .end = 55}, + (struct region){.start = 73, .end = 104} }; + /* 5-20-27, 45-55, 73-80-90-104 */ + unsigned long expected[] = {5, 20, 20, 27, 45, 55, + 73, 80, 80, 90, 90, 104}; + + damon_do_test_apply_three_regions(test, regions, ARRAY_SIZE(regions), + new_three_regions, expected, ARRAY_SIZE(expected)); +} + +/* + * Test slightly bigger change. Similar to above, but the second big region + * now require two target regions (50-55, 57-59) to be removed. + */ +static void damon_test_apply_three_regions2(struct kunit *test) +{ + /* 10-20-30, 50-55-57-59, 70-80-90-100 */ + unsigned long regions[] = {10, 20, 20, 30, 50, 55, 55, 57, 57, 59, + 70, 80, 80, 90, 90, 100}; + /* 5-27, 56-57, 65-104 */ + struct region new_three_regions[3] = { + (struct region){.start = 5, .end = 27}, + (struct region){.start = 56, .end = 57}, + (struct region){.start = 65, .end = 104} }; + /* 5-20-27, 56-57, 65-80-90-104 */ + unsigned long expected[] = {5, 20, 20, 27, 56, 57, + 65, 80, 80, 90, 90, 104}; + + damon_do_test_apply_three_regions(test, regions, ARRAY_SIZE(regions), + new_three_regions, expected, ARRAY_SIZE(expected)); +} + +/* + * Test a big change. The second big region has totally freed and mapped to + * different area (50-59 -> 61-63). The target regions which were in the old + * second big region (50-55-57-59) should be removed and new target region + * covering the second big region (61-63) should be created. + */ +static void damon_test_apply_three_regions3(struct kunit *test) +{ + /* 10-20-30, 50-55-57-59, 70-80-90-100 */ + unsigned long regions[] = {10, 20, 20, 30, 50, 55, 55, 57, 57, 59, + 70, 80, 80, 90, 90, 100}; + /* 5-27, 61-63, 65-104 */ + struct region new_three_regions[3] = { + (struct region){.start = 5, .end = 27}, + (struct region){.start = 61, .end = 63}, + (struct region){.start = 65, .end = 104} }; + /* 5-20-27, 61-63, 65-80-90-104 */ + unsigned long expected[] = {5, 20, 20, 27, 61, 63, + 65, 80, 80, 90, 90, 104}; + + damon_do_test_apply_three_regions(test, regions, ARRAY_SIZE(regions), + new_three_regions, expected, ARRAY_SIZE(expected)); +} + +/* + * Test another big change. Both of the second and third big regions (50-59 + * and 70-100) has totally freed and mapped to different area (30-32 and + * 65-68). The target regions which were in the old second and third big + * regions should now be removed and new target regions covering the new second + * and third big regions should be crated. + */ +static void damon_test_apply_three_regions4(struct kunit *test) +{ + /* 10-20-30, 50-55-57-59, 70-80-90-100 */ + unsigned long regions[] = {10, 20, 20, 30, 50, 55, 55, 57, 57, 59, + 70, 80, 80, 90, 90, 100}; + /* 5-7, 30-32, 65-68 */ + struct region new_three_regions[3] = { + (struct region){.start = 5, .end = 7}, + (struct region){.start = 30, .end = 32}, + (struct region){.start = 65, .end = 68} }; + /* expect 5-7, 30-32, 65-68 */ + unsigned long expected[] = {5, 7, 30, 32, 65, 68}; + + damon_do_test_apply_three_regions(test, regions, ARRAY_SIZE(regions), + new_three_regions, expected, ARRAY_SIZE(expected)); +} + +static void damon_test_split_evenly(struct kunit *test) +{ + struct damon_ctx *c = &damon_user_ctx; + struct damon_task *t; + struct damon_region *r; + unsigned long i; + + KUNIT_EXPECT_EQ(test, damon_split_region_evenly(c, NULL, 5), -EINVAL); + + t = damon_new_task(42); + r = damon_new_region(&damon_user_ctx, 0, 100); + KUNIT_EXPECT_EQ(test, damon_split_region_evenly(c, r, 0), -EINVAL); + + damon_add_region_tail(r, t); + KUNIT_EXPECT_EQ(test, damon_split_region_evenly(c, r, 10), 0); + KUNIT_EXPECT_EQ(test, nr_damon_regions(t), 10u); + + i = 0; + damon_for_each_region(r, t) { + KUNIT_EXPECT_EQ(test, r->vm_start, i++ * 10); + KUNIT_EXPECT_EQ(test, r->vm_end, i * 10); + } + damon_free_task(t); + + t = damon_new_task(42); + r = damon_new_region(&damon_user_ctx, 5, 59); + damon_add_region_tail(r, t); + KUNIT_EXPECT_EQ(test, damon_split_region_evenly(c, r, 5), 0); + KUNIT_EXPECT_EQ(test, nr_damon_regions(t), 5u); + + i = 0; + damon_for_each_region(r, t) { + if (i == 4) + break; + KUNIT_EXPECT_EQ(test, r->vm_start, 5 + 10 * i++); + KUNIT_EXPECT_EQ(test, r->vm_end, 5 + 10 * i); + } + KUNIT_EXPECT_EQ(test, r->vm_start, 5 + 10 * i); + KUNIT_EXPECT_EQ(test, r->vm_end, 59ul); + damon_free_task(t); + + t = damon_new_task(42); + r = damon_new_region(&damon_user_ctx, 5, 6); + damon_add_region_tail(r, t); + KUNIT_EXPECT_EQ(test, damon_split_region_evenly(c, r, 2), -EINVAL); + KUNIT_EXPECT_EQ(test, nr_damon_regions(t), 1u); + + damon_for_each_region(r, t) { + KUNIT_EXPECT_EQ(test, r->vm_start, 5ul); + KUNIT_EXPECT_EQ(test, r->vm_end, 6ul); + } + damon_free_task(t); +} + +static void damon_test_split_at(struct kunit *test) +{ + struct damon_task *t; + struct damon_region *r; + + t = damon_new_task(42); + r = damon_new_region(&damon_user_ctx, 0, 100); + damon_add_region_tail(r, t); + damon_split_region_at(&damon_user_ctx, r, 25); + KUNIT_EXPECT_EQ(test, r->vm_start, 0ul); + KUNIT_EXPECT_EQ(test, r->vm_end, 25ul); + + r = damon_next_region(r); + KUNIT_EXPECT_EQ(test, r->vm_start, 25ul); + KUNIT_EXPECT_EQ(test, r->vm_end, 100ul); + + damon_free_task(t); +} + +static void damon_test_merge_two(struct kunit *test) +{ + struct damon_task *t; + struct damon_region *r, *r2, *r3; + int i; + + t = damon_new_task(42); + r = damon_new_region(&damon_user_ctx, 0, 100); + r->nr_accesses = 10; + damon_add_region_tail(r, t); + r2 = damon_new_region(&damon_user_ctx, 100, 300); + r2->nr_accesses = 20; + damon_add_region_tail(r2, t); + + damon_merge_two_regions(r, r2); + KUNIT_EXPECT_EQ(test, r->vm_start, 0ul); + KUNIT_EXPECT_EQ(test, r->vm_end, 300ul); + KUNIT_EXPECT_EQ(test, r->nr_accesses, 16u); + + i = 0; + damon_for_each_region(r3, t) { + KUNIT_EXPECT_PTR_EQ(test, r, r3); + i++; + } + KUNIT_EXPECT_EQ(test, i, 1); + + damon_free_task(t); +} + +static void damon_test_merge_regions_of(struct kunit *test) +{ + struct damon_task *t; + struct damon_region *r; + unsigned long sa[] = {0, 100, 114, 122, 130, 156, 170, 184}; + unsigned long ea[] = {100, 112, 122, 130, 156, 170, 184, 230}; + unsigned int nrs[] = {0, 0, 10, 10, 20, 30, 1, 2}; + + unsigned long saddrs[] = {0, 114, 130, 156, 170}; + unsigned long eaddrs[] = {112, 130, 156, 170, 230}; + int i; + + t = damon_new_task(42); + for (i = 0; i < ARRAY_SIZE(sa); i++) { + r = damon_new_region(&damon_user_ctx, sa[i], ea[i]); + r->nr_accesses = nrs[i]; + damon_add_region_tail(r, t); + } + + damon_merge_regions_of(t, 9); + /* 0-112, 114-130, 130-156, 156-170 */ + KUNIT_EXPECT_EQ(test, nr_damon_regions(t), 5u); + for (i = 0; i < 5; i++) { + r = damon_nth_region_of(t, i); + KUNIT_EXPECT_EQ(test, r->vm_start, saddrs[i]); + KUNIT_EXPECT_EQ(test, r->vm_end, eaddrs[i]); + } + damon_free_task(t); +} + +static void damon_test_split_regions_of(struct kunit *test) +{ + struct damon_task *t; + struct damon_region *r; + + t = damon_new_task(42); + r = damon_new_region(&damon_user_ctx, 0, 22); + damon_add_region_tail(r, t); + damon_split_regions_of(&damon_user_ctx, t); + KUNIT_EXPECT_EQ(test, nr_damon_regions(t), 2u); + damon_free_task(t); +} + +static struct kunit_case damon_test_cases[] = { + KUNIT_CASE(damon_test_str_to_pids), + KUNIT_CASE(damon_test_tasks), + KUNIT_CASE(damon_test_regions), + KUNIT_CASE(damon_test_set_pids), + KUNIT_CASE(damon_test_three_regions_in_vmas), + KUNIT_CASE(damon_test_aggregate), + KUNIT_CASE(damon_test_write_rbuf), + KUNIT_CASE(damon_test_apply_three_regions1), + KUNIT_CASE(damon_test_apply_three_regions2), + KUNIT_CASE(damon_test_apply_three_regions3), + KUNIT_CASE(damon_test_apply_three_regions4), + KUNIT_CASE(damon_test_split_evenly), + KUNIT_CASE(damon_test_split_at), + KUNIT_CASE(damon_test_merge_two), + KUNIT_CASE(damon_test_merge_regions_of), + KUNIT_CASE(damon_test_split_regions_of), + {}, +}; + +static struct kunit_suite damon_test_suite = { + .name = "damon", + .test_cases = damon_test_cases, +}; +kunit_test_suite(damon_test_suite); + +#endif /* _DAMON_TEST_H */ + +#endif /* CONFIG_DAMON_KUNIT_TEST */ diff --git a/mm/damon.c b/mm/damon.c index c2a098843936..108476b07555 100644 --- a/mm/damon.c +++ b/mm/damon.c @@ -1408,3 +1408,5 @@ module_exit(damon_exit); MODULE_LICENSE("GPL"); MODULE_AUTHOR("SeongJae Park <sjpark@amazon.de>"); MODULE_DESCRIPTION("DAMON: Data Access MONitor"); + +#include "damon-test.h"