[0/3] ASoC: SOF: VirtIO: preparatory patches

Message

Guennadi Liakhovetski Jan. 31, 2020, 11:43 a.m. UTC

This is the first set of patches for the SOF virtualisation work. We
send these patches first because they touch the ASoC core. 2 of them
are mostly cosmetic with no functional changes, but patch 2/3 might
cause some discussions. Please review and comment.

Thanks
Guennadi

Guennadi Liakhovetski (3):
  ASoC: (cosmetic) simplify dpcm_prune_paths()
  ASoC: add function parameters to enable forced path pruning
  ASoC: export DPCM runtime update functions

 include/sound/soc-dpcm.h |  30 +++++++++--
 sound/soc/soc-compress.c |   2 +-
 sound/soc/soc-dapm.c     |   8 +--
 sound/soc/soc-pcm.c      | 126 ++++++++++++++++++++++++++++++-----------------
 4 files changed, 112 insertions(+), 54 deletions(-)

Comments

Guennadi Liakhovetski Feb. 10, 2020, 8:33 a.m. UTC | #1

Hi,

Any comment on this?

Thanks
Guennadi

On Fri, Jan 31, 2020 at 12:43:52PM +0100, Guennadi Liakhovetski wrote:
> This is the first set of patches for the SOF virtualisation work. We
> send these patches first because they touch the ASoC core. 2 of them
> are mostly cosmetic with no functional changes, but patch 2/3 might
> cause some discussions. Please review and comment.
> 
> Thanks
> Guennadi
> 
> Guennadi Liakhovetski (3):
>   ASoC: (cosmetic) simplify dpcm_prune_paths()
>   ASoC: add function parameters to enable forced path pruning
>   ASoC: export DPCM runtime update functions
> 
>  include/sound/soc-dpcm.h |  30 +++++++++--
>  sound/soc/soc-compress.c |   2 +-
>  sound/soc/soc-dapm.c     |   8 +--
>  sound/soc/soc-pcm.c      | 126 ++++++++++++++++++++++++++++++-----------------
>  4 files changed, 112 insertions(+), 54 deletions(-)
> 
> -- 
> 1.9.3
> 
> _______________________________________________
> Sound-open-firmware mailing list
> [e-mail]
> https://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware

Mark Brown Feb. 10, 2020, 12:25 p.m. UTC | #2

On Mon, Feb 10, 2020 at 09:33:00AM +0100, Guennadi Liakhovetski wrote:
> Hi,
> 
> Any comment on this?

Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so 
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  If there have been
review comments then people may be waiting for those to be addressed.

Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, so sending again is generally a better approach though there are
some other maintainers who like them - if in doubt look at how patches
for the subsystem are normally handled.