| Message ID | 20200211135335.55924-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [-next] dmaengine: idxd: remove set but not used variable 'group' | expand |
On 2/11/20 6:53 AM, YueHaibing wrote: > drivers/dma/idxd/sysfs.c: In function engine_group_id_store: > drivers/dma/idxd/sysfs.c:419:29: warning: variable group set but not used [-Wunused-but-set-variable] > > It is not used, so remove it. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Acked-by: Dave Jiang <dave.jiang@intel.com> > --- > drivers/dma/idxd/sysfs.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/dma/idxd/sysfs.c b/drivers/dma/idxd/sysfs.c > index 6d907fe..e4f35bd 100644 > --- a/drivers/dma/idxd/sysfs.c > +++ b/drivers/dma/idxd/sysfs.c > @@ -416,7 +416,7 @@ static ssize_t engine_group_id_store(struct device *dev, > struct idxd_device *idxd = engine->idxd; > long id; > int rc; > - struct idxd_group *prevg, *group; > + struct idxd_group *prevg; > > rc = kstrtol(buf, 10, &id); > if (rc < 0) > @@ -436,7 +436,6 @@ static ssize_t engine_group_id_store(struct device *dev, > return count; > } > > - group = &idxd->groups[id]; > prevg = engine->group; > > if (prevg) >
On 11-02-20, 21:53, YueHaibing wrote: > drivers/dma/idxd/sysfs.c: In function engine_group_id_store: > drivers/dma/idxd/sysfs.c:419:29: warning: variable group set but not used [-Wunused-but-set-variable] > > It is not used, so remove it. Applied, thanks
diff --git a/drivers/dma/idxd/sysfs.c b/drivers/dma/idxd/sysfs.c index 6d907fe..e4f35bd 100644 --- a/drivers/dma/idxd/sysfs.c +++ b/drivers/dma/idxd/sysfs.c @@ -416,7 +416,7 @@ static ssize_t engine_group_id_store(struct device *dev, struct idxd_device *idxd = engine->idxd; long id; int rc; - struct idxd_group *prevg, *group; + struct idxd_group *prevg; rc = kstrtol(buf, 10, &id); if (rc < 0) @@ -436,7 +436,6 @@ static ssize_t engine_group_id_store(struct device *dev, return count; } - group = &idxd->groups[id]; prevg = engine->group; if (prevg)
drivers/dma/idxd/sysfs.c: In function engine_group_id_store: drivers/dma/idxd/sysfs.c:419:29: warning: variable group set but not used [-Wunused-but-set-variable] It is not used, so remove it. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/dma/idxd/sysfs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)