| Message ID | 20200211135526.22793-1-marcos@mpdesouza.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | btrfs: ioctl: resize: Only how new size if size changed | expand |
Looks good,
Reviewed-by: Johannes Thumshirn <johannes.thumshnirn@wdc.com>
On Tue, Feb 11, 2020 at 10:55:26AM -0300, Marcos Paulo de Souza wrote: > There is no point to inform the user about "new size" if didn't changed > at all. Makes sense. I'll also update the message to show the old and new sizes. > Signed-off-by: Marcos Paulo de Souza <marcos@mpdesouza.com> > --- > fs/btrfs/ioctl.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c > index be5350582955..fa31a8021d24 100644 > --- a/fs/btrfs/ioctl.c > +++ b/fs/btrfs/ioctl.c > @@ -1712,9 +1712,6 @@ static noinline int btrfs_ioctl_resize(struct file *file, > > new_size = round_down(new_size, fs_info->sectorsize); > > - btrfs_info_in_rcu(fs_info, "new size for %s is %llu", > - rcu_str_deref(device->name), new_size); > - > if (new_size > old_size) { > trans = btrfs_start_transaction(root, 0); > if (IS_ERR(trans)) { > @@ -1727,6 +1724,9 @@ static noinline int btrfs_ioctl_resize(struct file *file, > ret = btrfs_shrink_device(device, new_size); > } /* equal, nothing need to do */ > > + if (ret == 0 && new_size != old_size) > + btrfs_info_in_rcu(fs_info, "new size for %s is %llu", > + rcu_str_deref(device->name), new_size); And maybe also print devid, other messages usually print both. > out_free: > kfree(vol_args); > out: > -- > 2.24.0
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index be5350582955..fa31a8021d24 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -1712,9 +1712,6 @@ static noinline int btrfs_ioctl_resize(struct file *file, new_size = round_down(new_size, fs_info->sectorsize); - btrfs_info_in_rcu(fs_info, "new size for %s is %llu", - rcu_str_deref(device->name), new_size); - if (new_size > old_size) { trans = btrfs_start_transaction(root, 0); if (IS_ERR(trans)) { @@ -1727,6 +1724,9 @@ static noinline int btrfs_ioctl_resize(struct file *file, ret = btrfs_shrink_device(device, new_size); } /* equal, nothing need to do */ + if (ret == 0 && new_size != old_size) + btrfs_info_in_rcu(fs_info, "new size for %s is %llu", + rcu_str_deref(device->name), new_size); out_free: kfree(vol_args); out:
There is no point to inform the user about "new size" if didn't changed at all. Signed-off-by: Marcos Paulo de Souza <marcos@mpdesouza.com> --- fs/btrfs/ioctl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)