mbox series

[v4,0/4] perf tools: Add support for some spe events and precise ip

Message ID 20200211140445.21986-1-james.clark@arm.com (mailing list archive)
Headers show
Series perf tools: Add support for some spe events and precise ip | expand

Message

James Clark Feb. 11, 2020, 2:04 p.m. UTC
Hi Jirka,

Oops. I've removed all the changes to evlist.c and evsel.h


James

Tan Xiaojun (4):
  perf tools: Move arm-spe-pkt-decoder.h/c to the new dir
  perf tools: Add support for "report" for some spe events
  perf report: Add SPE options to --itrace argument
  perf tools: Support "branch-misses:pp" on arm64

 tools/perf/Documentation/itrace.txt           |   5 +-
 tools/perf/arch/arm/util/auxtrace.c           |  38 +
 tools/perf/builtin-record.c                   |   5 +
 tools/perf/util/Build                         |   2 +-
 tools/perf/util/arm-spe-decoder/Build         |   1 +
 .../util/arm-spe-decoder/arm-spe-decoder.c    | 225 ++++++
 .../util/arm-spe-decoder/arm-spe-decoder.h    |  66 ++
 .../arm-spe-pkt-decoder.c                     |   0
 .../arm-spe-pkt-decoder.h                     |   2 +
 tools/perf/util/arm-spe.c                     | 756 +++++++++++++++++-
 tools/perf/util/arm-spe.h                     |   3 +
 tools/perf/util/auxtrace.c                    |  13 +
 tools/perf/util/auxtrace.h                    |  14 +-
 13 files changed, 1089 insertions(+), 41 deletions(-)
 create mode 100644 tools/perf/util/arm-spe-decoder/Build
 create mode 100644 tools/perf/util/arm-spe-decoder/arm-spe-decoder.c
 create mode 100644 tools/perf/util/arm-spe-decoder/arm-spe-decoder.h
 rename tools/perf/util/{ => arm-spe-decoder}/arm-spe-pkt-decoder.c (100%)
 rename tools/perf/util/{ => arm-spe-decoder}/arm-spe-pkt-decoder.h (96%)

Comments

Jiri Olsa Feb. 12, 2020, 12:24 p.m. UTC | #1
On Tue, Feb 11, 2020 at 02:04:41PM +0000, James Clark wrote:
> Hi Jirka,
> 
> Oops. I've removed all the changes to evlist.c and evsel.h

hi,
it looks ok from my POV, but I don't follow auxtrace that much

Adrian,
it's changing some generic bits of the auxtrace framework,
could you please check?

thanks,
jirka

> 
> 
> James
> 
> Tan Xiaojun (4):
>   perf tools: Move arm-spe-pkt-decoder.h/c to the new dir
>   perf tools: Add support for "report" for some spe events
>   perf report: Add SPE options to --itrace argument
>   perf tools: Support "branch-misses:pp" on arm64
> 
>  tools/perf/Documentation/itrace.txt           |   5 +-
>  tools/perf/arch/arm/util/auxtrace.c           |  38 +
>  tools/perf/builtin-record.c                   |   5 +
>  tools/perf/util/Build                         |   2 +-
>  tools/perf/util/arm-spe-decoder/Build         |   1 +
>  .../util/arm-spe-decoder/arm-spe-decoder.c    | 225 ++++++
>  .../util/arm-spe-decoder/arm-spe-decoder.h    |  66 ++
>  .../arm-spe-pkt-decoder.c                     |   0
>  .../arm-spe-pkt-decoder.h                     |   2 +
>  tools/perf/util/arm-spe.c                     | 756 +++++++++++++++++-
>  tools/perf/util/arm-spe.h                     |   3 +
>  tools/perf/util/auxtrace.c                    |  13 +
>  tools/perf/util/auxtrace.h                    |  14 +-
>  13 files changed, 1089 insertions(+), 41 deletions(-)
>  create mode 100644 tools/perf/util/arm-spe-decoder/Build
>  create mode 100644 tools/perf/util/arm-spe-decoder/arm-spe-decoder.c
>  create mode 100644 tools/perf/util/arm-spe-decoder/arm-spe-decoder.h
>  rename tools/perf/util/{ => arm-spe-decoder}/arm-spe-pkt-decoder.c (100%)
>  rename tools/perf/util/{ => arm-spe-decoder}/arm-spe-pkt-decoder.h (96%)
> 
> -- 
> 2.17.1
>
Adrian Hunter Feb. 12, 2020, 1:10 p.m. UTC | #2
On 12/02/20 2:24 pm, Jiri Olsa wrote:
> On Tue, Feb 11, 2020 at 02:04:41PM +0000, James Clark wrote:
>> Hi Jirka,
>>
>> Oops. I've removed all the changes to evlist.c and evsel.h
> 
> hi,
> it looks ok from my POV, but I don't follow auxtrace that much
> 
> Adrian,
> it's changing some generic bits of the auxtrace framework,
> could you please check?

Sure, in the next few days.

> 
> thanks,
> jirka
> 
>>
>>
>> James
>>
>> Tan Xiaojun (4):
>>   perf tools: Move arm-spe-pkt-decoder.h/c to the new dir
>>   perf tools: Add support for "report" for some spe events
>>   perf report: Add SPE options to --itrace argument
>>   perf tools: Support "branch-misses:pp" on arm64
>>
>>  tools/perf/Documentation/itrace.txt           |   5 +-
>>  tools/perf/arch/arm/util/auxtrace.c           |  38 +
>>  tools/perf/builtin-record.c                   |   5 +
>>  tools/perf/util/Build                         |   2 +-
>>  tools/perf/util/arm-spe-decoder/Build         |   1 +
>>  .../util/arm-spe-decoder/arm-spe-decoder.c    | 225 ++++++
>>  .../util/arm-spe-decoder/arm-spe-decoder.h    |  66 ++
>>  .../arm-spe-pkt-decoder.c                     |   0
>>  .../arm-spe-pkt-decoder.h                     |   2 +
>>  tools/perf/util/arm-spe.c                     | 756 +++++++++++++++++-
>>  tools/perf/util/arm-spe.h                     |   3 +
>>  tools/perf/util/auxtrace.c                    |  13 +
>>  tools/perf/util/auxtrace.h                    |  14 +-
>>  13 files changed, 1089 insertions(+), 41 deletions(-)
>>  create mode 100644 tools/perf/util/arm-spe-decoder/Build
>>  create mode 100644 tools/perf/util/arm-spe-decoder/arm-spe-decoder.c
>>  create mode 100644 tools/perf/util/arm-spe-decoder/arm-spe-decoder.h
>>  rename tools/perf/util/{ => arm-spe-decoder}/arm-spe-pkt-decoder.c (100%)
>>  rename tools/perf/util/{ => arm-spe-decoder}/arm-spe-pkt-decoder.h (96%)
>>
>> -- 
>> 2.17.1
>>
>