[v30,00/22] Add RX archtecture support

Message

Yoshinori Sato Feb. 12, 2020, 1:02 p.m. UTC

Hello.
This patch series is added Renesas RX target emulation.

Changes for v29.
Add target description XML. It required gdb-9.1.
Follow git master changes.

Changes for v28.
Allow -m option.
With this option, 16 Mbytes or more can be specified.
Add example for qemu-doc.
Fix build error on latest master.

Changes for v27.
Added RX section to qemu-doc.
Rebase for master

Changes for v26.
Rebase for 5.0
Update machine.json for 5.0

Changes for v25.
Update commit message.
Squashed qapi/machine.json changes.

Changes for v24.
Add note for qapi/machine.json.
Added Acked-by for 6/22.
git rebase master.

Changes for v23.
Follow master changes.

Changes for v22.
Added some include.

Changes for v21.
rebase latest master.
Remove unneeded hmp_info_tlb.

Chanegs for v20.
Reorderd patches.
Squashed v19 changes.

Changes for v19.
Follow tcg changes.
Cleanup cpu.c.
simplify rx_cpu_class_by_name and rx_load_image move to rx-virt.

My git repository is bellow.
git://git.pf.osdn.net/gitroot/y/ys/ysato/qemu.git tags/rx-20200212

Testing binaries bellow.
u-boot
Download - https://osdn.net/users/ysato/pf/qemu/dl/u-boot.bin.gz

starting
$ gzip -d u-boot.bin.gz
$ qemu-system-rx -bios u-boot.bin

linux and pico-root (only sash)
Download - https://osdn.net/users/ysato/pf/qemu/dl/zImage (kernel)
           https://osdn.net/users/ysato/pf/qemu/dl/rx-virt.dtb (DeviceTree)

starting
$ qemu-system-rx -kernel zImage -dtb rx-virt.dtb -append "earlycon"

Philippe Mathieu-Daudé (3):
  hw/registerfields.h: Add 8bit and 16bit register macros
  hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
  BootLinuxConsoleTest: Test the RX-Virt machine

Richard Henderson (7):
  target/rx: Disassemble rx_index_addr into a string
  target/rx: Replace operand with prt_ldmi in disassembler
  target/rx: Use prt_ldmi for XCHG_mr disassembly
  target/rx: Emit all disassembly in one prt()
  target/rx: Collect all bytes during disassembly
  target/rx: Dump bytes for each insn during disassembly
  hw/rx: Honor -accel qtest

Yoshinori Sato (12):
  MAINTAINERS: Add RX
  qemu/bitops.h: Add extract8 and extract16
  target/rx: TCG translation
  target/rx: TCG helper
  target/rx: CPU definition
  target/rx: RX disassembler
  hw/intc: RX62N interrupt controller (ICUa)
  hw/timer: RX62N internal timer modules
  hw/char: RX62N serial communication interface (SCI)
  hw/rx: RX Target hardware definition
  Add rx-softmmu
  qemu-doc.texi: Add RX section.

 qemu-doc.texi                          |   44 +
 configure                              |   11 +-
 default-configs/rx-softmmu.mak         |    3 +
 qapi/machine.json                      |    3 +-
 include/disas/dis-asm.h                |    5 +
 include/exec/poison.h                  |    1 +
 include/hw/char/renesas_sci.h          |   45 +
 include/hw/intc/rx_icu.h               |   56 +
 include/hw/registerfields.h            |   32 +-
 include/hw/rx/rx.h                     |    7 +
 include/hw/rx/rx62n.h                  |   91 +
 include/hw/timer/renesas_cmt.h         |   38 +
 include/hw/timer/renesas_tmr.h         |   53 +
 include/qemu/bitops.h                  |   38 +
 include/sysemu/arch_init.h             |    1 +
 target/rx/cpu-param.h                  |   31 +
 target/rx/cpu-qom.h                    |   42 +
 target/rx/cpu.h                        |  181 ++
 target/rx/helper.h                     |   31 +
 target/rx/insns.decode                 |  621 ++++++
 arch_init.c                            |    2 +
 hw/char/renesas_sci.c                  |  342 ++++
 hw/intc/rx_icu.c                       |  379 ++++
 hw/rx/rx-virt.c                        |  142 ++
 hw/rx/rx62n.c                          |  247 +++
 hw/timer/renesas_cmt.c                 |  278 +++
 hw/timer/renesas_tmr.c                 |  458 +++++
 target/rx/cpu.c                        |  218 +++
 target/rx/disas.c                      | 1446 ++++++++++++++
 target/rx/gdbstub.c                    |  112 ++
 target/rx/helper.c                     |  149 ++
 target/rx/op_helper.c                  |  470 +++++
 target/rx/translate.c                  | 2432 ++++++++++++++++++++++++
 tests/qtest/machine-none-test.c        |    1 +
 MAINTAINERS                            |   19 +
 gdb-xml/rx-core.xml                    |   70 +
 hw/Kconfig                             |    1 +
 hw/char/Kconfig                        |    3 +
 hw/char/Makefile.objs                  |    1 +
 hw/intc/Kconfig                        |    3 +
 hw/intc/Makefile.objs                  |    1 +
 hw/rx/Kconfig                          |   14 +
 hw/rx/Makefile.objs                    |    2 +
 hw/timer/Kconfig                       |    6 +
 hw/timer/Makefile.objs                 |    3 +
 target/rx/Makefile.objs                |   11 +
 tests/acceptance/boot_linux_console.py |   46 +
 47 files changed, 8187 insertions(+), 3 deletions(-)
 create mode 100644 default-configs/rx-softmmu.mak
 create mode 100644 include/hw/char/renesas_sci.h
 create mode 100644 include/hw/intc/rx_icu.h
 create mode 100644 include/hw/rx/rx.h
 create mode 100644 include/hw/rx/rx62n.h
 create mode 100644 include/hw/timer/renesas_cmt.h
 create mode 100644 include/hw/timer/renesas_tmr.h
 create mode 100644 target/rx/cpu-param.h
 create mode 100644 target/rx/cpu-qom.h
 create mode 100644 target/rx/cpu.h
 create mode 100644 target/rx/helper.h
 create mode 100644 target/rx/insns.decode
 create mode 100644 hw/char/renesas_sci.c
 create mode 100644 hw/intc/rx_icu.c
 create mode 100644 hw/rx/rx-virt.c
 create mode 100644 hw/rx/rx62n.c
 create mode 100644 hw/timer/renesas_cmt.c
 create mode 100644 hw/timer/renesas_tmr.c
 create mode 100644 target/rx/cpu.c
 create mode 100644 target/rx/disas.c
 create mode 100644 target/rx/gdbstub.c
 create mode 100644 target/rx/helper.c
 create mode 100644 target/rx/op_helper.c
 create mode 100644 target/rx/translate.c
 create mode 100644 gdb-xml/rx-core.xml
 create mode 100644 hw/rx/Kconfig
 create mode 100644 hw/rx/Makefile.objs
 create mode 100644 target/rx/Makefile.objs

Comments

[e-mail] Feb. 12, 2020, 1:22 p.m. UTC | #1

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v30 00/22] Add RX archtecture support
Message-id: [e-mail]
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]         patchew/[e-mail] -> patchew/[e-mail]
Switched to a new branch 'test'
f4d6eaf qemu-doc.texi: Add RX section.
0b8d847 BootLinuxConsoleTest: Test the RX-Virt machine
c557e26 Add rx-softmmu
43b988e hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
ff21308 hw/rx: Honor -accel qtest
8c88664 hw/rx: RX Target hardware definition
1b2fe5f hw/char: RX62N serial communication interface (SCI)
b2f8fa7 hw/timer: RX62N internal timer modules
ae62029 hw/intc: RX62N interrupt controller (ICUa)
765ce42 target/rx: Dump bytes for each insn during disassembly
a2a0a4b target/rx: Collect all bytes during disassembly
b746289 target/rx: Emit all disassembly in one prt()
c90e743 target/rx: Use prt_ldmi for XCHG_mr disassembly
89b0c41 target/rx: Replace operand with prt_ldmi in disassembler
c5849aa target/rx: Disassemble rx_index_addr into a string
88a4745 target/rx: RX disassembler
def33df target/rx: CPU definition
ec76660 target/rx: TCG helper
65fc0c5 target/rx: TCG translation
c225a52 hw/registerfields.h: Add 8bit and 16bit register macros
1b8ec2b qemu/bitops.h: Add extract8 and extract16
4292f08 MAINTAINERS: Add RX

=== OUTPUT BEGIN ===
1/22 Checking commit 4292f083c3fa (MAINTAINERS: Add RX)
2/22 Checking commit 1b8ec2b1e39d (qemu/bitops.h: Add extract8 and extract16)
3/22 Checking commit c225a5286644 (hw/registerfields.h: Add 8bit and 16bit register macros)
Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2490.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) };

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) / 2 };

total: 2 errors, 0 warnings, 56 lines checked

Patch 3/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/22 Checking commit 65fc0c5eab98 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 3065 lines checked

Patch 4/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/22 Checking commit ec766608772b (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

total: 0 errors, 1 warnings, 650 lines checked

Patch 5/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/22 Checking commit def33dfddaf5 (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22: 
new file mode 100644

total: 0 errors, 1 warnings, 659 lines checked

Patch 6/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/22 Checking commit 88a474516e8d (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 1497 lines checked

Patch 7/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/22 Checking commit c5849aab2ce9 (target/rx: Disassemble rx_index_addr into a string)
9/22 Checking commit 89b0c4140179 (target/rx: Replace operand with prt_ldmi in disassembler)
10/22 Checking commit c90e743d5f36 (target/rx: Use prt_ldmi for XCHG_mr disassembly)
11/22 Checking commit b74628914f4f (target/rx: Emit all disassembly in one prt())
12/22 Checking commit a2a0a4b84d0e (target/rx: Collect all bytes during disassembly)
13/22 Checking commit 765ce427f3f7 (target/rx: Dump bytes for each insn during disassembly)
14/22 Checking commit ae62029d9e72 (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

total: 0 errors, 1 warnings, 445 lines checked

Patch 14/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/22 Checking commit b2f8fa713ccb (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 845 lines checked

Patch 15/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/22 Checking commit 1b2fe5f13848 (hw/char: RX62N serial communication interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

total: 0 errors, 1 warnings, 400 lines checked

Patch 16/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/22 Checking commit 8c8866420ce2 (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#23: 
new file mode 100644

ERROR: trailing whitespace
#128: FILE: hw/rx/rx-virt.c:73:
+    $

ERROR: trailing whitespace
#146: FILE: hw/rx/rx-virt.c:91:
+        /* The kernel image is loaded into $

WARNING: Block comments use a leading /* on a separate line
#146: FILE: hw/rx/rx-virt.c:91:
+        /* The kernel image is loaded into 

WARNING: Block comments use * on subsequent lines
#147: FILE: hw/rx/rx-virt.c:92:
+        /* The kernel image is loaded into 
+           the latter half of the SDRAM space. */

WARNING: Block comments use a trailing */ on a separate line
#147: FILE: hw/rx/rx-virt.c:92:
+           the latter half of the SDRAM space. */

total: 2 errors, 4 warnings, 493 lines checked

Patch 17/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

18/22 Checking commit ff21308a5e17 (hw/rx: Honor -accel qtest)
19/22 Checking commit 43b988ef2318 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core)
20/22 Checking commit c557e261b764 (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#69: 
new file mode 100644

total: 0 errors, 1 warnings, 83 lines checked

Patch 20/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/22 Checking commit 0b8d84762b47 (BootLinuxConsoleTest: Test the RX-Virt machine)
22/22 Checking commit f4d6eaf69279 (qemu-doc.texi: Add RX section.)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/[e-mail]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [e-mail]

[e-mail] Feb. 12, 2020, 1:39 p.m. UTC | #2

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v30 00/22] Add RX archtecture support
Message-id: [e-mail]
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/[e-mail] -> patchew/[e-mail]
 - [tag update]      patchew/[e-mail] -> patchew/[e-mail]
Switched to a new branch 'test'
63d8f29 qemu-doc.texi: Add RX section.
0828fee BootLinuxConsoleTest: Test the RX-Virt machine
bea9ae2 Add rx-softmmu
46f27e3 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
2afce4c hw/rx: Honor -accel qtest
ed93bfd hw/rx: RX Target hardware definition
72f4963 hw/char: RX62N serial communication interface (SCI)
ad00efa hw/timer: RX62N internal timer modules
bf6c82f hw/intc: RX62N interrupt controller (ICUa)
253d941 target/rx: Dump bytes for each insn during disassembly
0d816ca target/rx: Collect all bytes during disassembly
bdfbcf3 target/rx: Emit all disassembly in one prt()
f587124 target/rx: Use prt_ldmi for XCHG_mr disassembly
eeca618 target/rx: Replace operand with prt_ldmi in disassembler
956befe target/rx: Disassemble rx_index_addr into a string
0835249 target/rx: RX disassembler
6821236 target/rx: CPU definition
0e76a8f target/rx: TCG helper
fe37ab1 target/rx: TCG translation
7cc01ef hw/registerfields.h: Add 8bit and 16bit register macros
d17802b qemu/bitops.h: Add extract8 and extract16
81462db MAINTAINERS: Add RX

=== OUTPUT BEGIN ===
1/22 Checking commit 81462db667b2 (MAINTAINERS: Add RX)
2/22 Checking commit d17802b2bd09 (qemu/bitops.h: Add extract8 and extract16)
3/22 Checking commit 7cc01ef2805e (hw/registerfields.h: Add 8bit and 16bit register macros)
Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2490.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) };

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) / 2 };

total: 2 errors, 0 warnings, 56 lines checked

Patch 3/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/22 Checking commit fe37ab11655e (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 3065 lines checked

Patch 4/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/22 Checking commit 0e76a8f988a8 (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

total: 0 errors, 1 warnings, 650 lines checked

Patch 5/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/22 Checking commit 6821236f1ec6 (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22: 
new file mode 100644

total: 0 errors, 1 warnings, 659 lines checked

Patch 6/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/22 Checking commit 083524988c91 (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 1497 lines checked

Patch 7/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/22 Checking commit 956befec0bfb (target/rx: Disassemble rx_index_addr into a string)
9/22 Checking commit eeca61803f65 (target/rx: Replace operand with prt_ldmi in disassembler)
10/22 Checking commit f58712457dc7 (target/rx: Use prt_ldmi for XCHG_mr disassembly)
11/22 Checking commit bdfbcf35637b (target/rx: Emit all disassembly in one prt())
12/22 Checking commit 0d816ca0983f (target/rx: Collect all bytes during disassembly)
13/22 Checking commit 253d941aaa86 (target/rx: Dump bytes for each insn during disassembly)
14/22 Checking commit bf6c82fc3bcd (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

total: 0 errors, 1 warnings, 445 lines checked

Patch 14/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/22 Checking commit ad00efa8d314 (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 845 lines checked

Patch 15/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/22 Checking commit 72f4963a91f9 (hw/char: RX62N serial communication interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

total: 0 errors, 1 warnings, 400 lines checked

Patch 16/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/22 Checking commit ed93bfd19986 (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#23: 
new file mode 100644

ERROR: trailing whitespace
#128: FILE: hw/rx/rx-virt.c:73:
+    $

ERROR: trailing whitespace
#146: FILE: hw/rx/rx-virt.c:91:
+        /* The kernel image is loaded into $

WARNING: Block comments use a leading /* on a separate line
#146: FILE: hw/rx/rx-virt.c:91:
+        /* The kernel image is loaded into 

WARNING: Block comments use * on subsequent lines
#147: FILE: hw/rx/rx-virt.c:92:
+        /* The kernel image is loaded into 
+           the latter half of the SDRAM space. */

WARNING: Block comments use a trailing */ on a separate line
#147: FILE: hw/rx/rx-virt.c:92:
+           the latter half of the SDRAM space. */

total: 2 errors, 4 warnings, 493 lines checked

Patch 17/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

18/22 Checking commit 2afce4c4ec24 (hw/rx: Honor -accel qtest)
19/22 Checking commit 46f27e3252e4 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core)
20/22 Checking commit bea9ae2c5ed7 (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#69: 
new file mode 100644

total: 0 errors, 1 warnings, 83 lines checked

Patch 20/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/22 Checking commit 0828feec3de9 (BootLinuxConsoleTest: Test the RX-Virt machine)
22/22 Checking commit 63d8f29d671c (qemu-doc.texi: Add RX section.)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/[e-mail]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [e-mail]

[e-mail] Feb. 12, 2020, 1:55 p.m. UTC | #3

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v30 00/22] Add RX archtecture support
Message-id: [e-mail]
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 - [tag update]      patchew/[e-mail] -> patchew/[e-mail]
Switched to a new branch 'test'
b99dc82 qemu-doc.texi: Add RX section.
0d81589 BootLinuxConsoleTest: Test the RX-Virt machine
e1fb98f Add rx-softmmu
9fb7102 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
3491db9 hw/rx: Honor -accel qtest
7905f70 hw/rx: RX Target hardware definition
6871a28 hw/char: RX62N serial communication interface (SCI)
430e7ae hw/timer: RX62N internal timer modules
029f7c2 hw/intc: RX62N interrupt controller (ICUa)
08436a0 target/rx: Dump bytes for each insn during disassembly
0922998 target/rx: Collect all bytes during disassembly
f7c9eeb target/rx: Emit all disassembly in one prt()
b26c962 target/rx: Use prt_ldmi for XCHG_mr disassembly
547cba7 target/rx: Replace operand with prt_ldmi in disassembler
72fdb0c target/rx: Disassemble rx_index_addr into a string
9ae47c8 target/rx: RX disassembler
6ce9166 target/rx: CPU definition
f44b93f target/rx: TCG helper
d12c2b0 target/rx: TCG translation
4765cee hw/registerfields.h: Add 8bit and 16bit register macros
d8bef98 qemu/bitops.h: Add extract8 and extract16
3b29a0a MAINTAINERS: Add RX

=== OUTPUT BEGIN ===
1/22 Checking commit 3b29a0a2c13b (MAINTAINERS: Add RX)
2/22 Checking commit d8bef9867414 (qemu/bitops.h: Add extract8 and extract16)
3/22 Checking commit 4765cee62a1b (hw/registerfields.h: Add 8bit and 16bit register macros)
Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2490.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) };

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) / 2 };

total: 2 errors, 0 warnings, 56 lines checked

Patch 3/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/22 Checking commit d12c2b05dc64 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 3065 lines checked

Patch 4/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/22 Checking commit f44b93fefa39 (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

total: 0 errors, 1 warnings, 650 lines checked

Patch 5/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/22 Checking commit 6ce916678c4b (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22: 
new file mode 100644

total: 0 errors, 1 warnings, 659 lines checked

Patch 6/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/22 Checking commit 9ae47c83cd99 (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 1497 lines checked

Patch 7/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/22 Checking commit 72fdb0cf8e02 (target/rx: Disassemble rx_index_addr into a string)
9/22 Checking commit 547cba7fec67 (target/rx: Replace operand with prt_ldmi in disassembler)
10/22 Checking commit b26c962f1e11 (target/rx: Use prt_ldmi for XCHG_mr disassembly)
11/22 Checking commit f7c9eebd32fb (target/rx: Emit all disassembly in one prt())
12/22 Checking commit 0922998c8ca2 (target/rx: Collect all bytes during disassembly)
13/22 Checking commit 08436a08ece7 (target/rx: Dump bytes for each insn during disassembly)
14/22 Checking commit 029f7c293c53 (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

total: 0 errors, 1 warnings, 445 lines checked

Patch 14/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/22 Checking commit 430e7ae5bc53 (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 845 lines checked

Patch 15/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/22 Checking commit 6871a2859564 (hw/char: RX62N serial communication interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

total: 0 errors, 1 warnings, 400 lines checked

Patch 16/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/22 Checking commit 7905f70a12a1 (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#23: 
new file mode 100644

ERROR: trailing whitespace
#128: FILE: hw/rx/rx-virt.c:73:
+    $

ERROR: trailing whitespace
#146: FILE: hw/rx/rx-virt.c:91:
+        /* The kernel image is loaded into $

WARNING: Block comments use a leading /* on a separate line
#146: FILE: hw/rx/rx-virt.c:91:
+        /* The kernel image is loaded into 

WARNING: Block comments use * on subsequent lines
#147: FILE: hw/rx/rx-virt.c:92:
+        /* The kernel image is loaded into 
+           the latter half of the SDRAM space. */

WARNING: Block comments use a trailing */ on a separate line
#147: FILE: hw/rx/rx-virt.c:92:
+           the latter half of the SDRAM space. */

total: 2 errors, 4 warnings, 493 lines checked

Patch 17/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

18/22 Checking commit 3491db96714e (hw/rx: Honor -accel qtest)
19/22 Checking commit 9fb7102e2ee2 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core)
20/22 Checking commit e1fb98f90c3b (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#69: 
new file mode 100644

total: 0 errors, 1 warnings, 83 lines checked

Patch 20/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/22 Checking commit 0d81589f7682 (BootLinuxConsoleTest: Test the RX-Virt machine)
22/22 Checking commit b99dc821dcb8 (qemu-doc.texi: Add RX section.)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/[e-mail]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [e-mail]

[e-mail] Feb. 12, 2020, 2:43 p.m. UTC | #4

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v30 00/22] Add RX archtecture support
Message-id: [e-mail]
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
fb4922a qemu-doc.texi: Add RX section.
edd4d76 BootLinuxConsoleTest: Test the RX-Virt machine
1f0e65e Add rx-softmmu
edf3f49 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
7e8b2d2 hw/rx: Honor -accel qtest
b45a90b hw/rx: RX Target hardware definition
393a9ff hw/char: RX62N serial communication interface (SCI)
fb03e33 hw/timer: RX62N internal timer modules
14af849 hw/intc: RX62N interrupt controller (ICUa)
097db5cd target/rx: Dump bytes for each insn during disassembly
d6b49d1 target/rx: Collect all bytes during disassembly
ee0e458 target/rx: Emit all disassembly in one prt()
c06d978 target/rx: Use prt_ldmi for XCHG_mr disassembly
67ecb36 target/rx: Replace operand with prt_ldmi in disassembler
0be1ef5 target/rx: Disassemble rx_index_addr into a string
ea7685e target/rx: RX disassembler
46e3e2b target/rx: CPU definition
5bc4129 target/rx: TCG helper
c18ded8 target/rx: TCG translation
0356712 hw/registerfields.h: Add 8bit and 16bit register macros
bb1b91d qemu/bitops.h: Add extract8 and extract16
3cbeee6 MAINTAINERS: Add RX

=== OUTPUT BEGIN ===
1/22 Checking commit 3cbeee611724 (MAINTAINERS: Add RX)
2/22 Checking commit bb1b91d61176 (qemu/bitops.h: Add extract8 and extract16)
3/22 Checking commit 0356712846d1 (hw/registerfields.h: Add 8bit and 16bit register macros)
Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2490.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) };

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) / 2 };

total: 2 errors, 0 warnings, 56 lines checked

Patch 3/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/22 Checking commit c18ded8e7e08 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 3065 lines checked

Patch 4/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/22 Checking commit 5bc412974455 (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

total: 0 errors, 1 warnings, 650 lines checked

Patch 5/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/22 Checking commit 46e3e2b13e31 (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22: 
new file mode 100644

total: 0 errors, 1 warnings, 659 lines checked

Patch 6/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/22 Checking commit ea7685ec72cc (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 1497 lines checked

Patch 7/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/22 Checking commit 0be1ef5d641a (target/rx: Disassemble rx_index_addr into a string)
9/22 Checking commit 67ecb36d6ff1 (target/rx: Replace operand with prt_ldmi in disassembler)
10/22 Checking commit c06d978520ce (target/rx: Use prt_ldmi for XCHG_mr disassembly)
11/22 Checking commit ee0e45884b35 (target/rx: Emit all disassembly in one prt())
12/22 Checking commit d6b49d1fd490 (target/rx: Collect all bytes during disassembly)
13/22 Checking commit 097db5cdc306 (target/rx: Dump bytes for each insn during disassembly)
14/22 Checking commit 14af8493f5f8 (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

total: 0 errors, 1 warnings, 445 lines checked

Patch 14/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/22 Checking commit fb03e3345795 (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 845 lines checked

Patch 15/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/22 Checking commit 393a9ffe035e (hw/char: RX62N serial communication interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

total: 0 errors, 1 warnings, 400 lines checked

Patch 16/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/22 Checking commit b45a90b39e03 (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#23: 
new file mode 100644

ERROR: trailing whitespace
#128: FILE: hw/rx/rx-virt.c:73:
+    $

ERROR: trailing whitespace
#146: FILE: hw/rx/rx-virt.c:91:
+        /* The kernel image is loaded into $

WARNING: Block comments use a leading /* on a separate line
#146: FILE: hw/rx/rx-virt.c:91:
+        /* The kernel image is loaded into 

WARNING: Block comments use * on subsequent lines
#147: FILE: hw/rx/rx-virt.c:92:
+        /* The kernel image is loaded into 
+           the latter half of the SDRAM space. */

WARNING: Block comments use a trailing */ on a separate line
#147: FILE: hw/rx/rx-virt.c:92:
+           the latter half of the SDRAM space. */

total: 2 errors, 4 warnings, 493 lines checked

Patch 17/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

18/22 Checking commit 7e8b2d211ffa (hw/rx: Honor -accel qtest)
19/22 Checking commit edf3f49bfe54 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core)
20/22 Checking commit 1f0e65e1da92 (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#69: 
new file mode 100644

total: 0 errors, 1 warnings, 83 lines checked

Patch 20/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/22 Checking commit edd4d76366b9 (BootLinuxConsoleTest: Test the RX-Virt machine)
22/22 Checking commit fb4922a3edc7 (qemu-doc.texi: Add RX section.)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/[e-mail]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [e-mail]

[e-mail] Feb. 12, 2020, 2:57 p.m. UTC | #5

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v30 00/22] Add RX archtecture support
Message-id: [e-mail]
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 - [tag update]      patchew/[e-mail] -> patchew/[e-mail]
Switched to a new branch 'test'
4470895 qemu-doc.texi: Add RX section.
f0b23ed BootLinuxConsoleTest: Test the RX-Virt machine
92a7207 Add rx-softmmu
e3ec889 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
b62a7e2 hw/rx: Honor -accel qtest
ecdf913 hw/rx: RX Target hardware definition
a7637c5 hw/char: RX62N serial communication interface (SCI)
3f8b83c hw/timer: RX62N internal timer modules
f2c5f71 hw/intc: RX62N interrupt controller (ICUa)
66902a4 target/rx: Dump bytes for each insn during disassembly
691260f target/rx: Collect all bytes during disassembly
7b77f1a target/rx: Emit all disassembly in one prt()
ced96c7 target/rx: Use prt_ldmi for XCHG_mr disassembly
e24ee8d target/rx: Replace operand with prt_ldmi in disassembler
cc5ad57 target/rx: Disassemble rx_index_addr into a string
db3bdeb target/rx: RX disassembler
b3d7bf4 target/rx: CPU definition
936ddc4 target/rx: TCG helper
2e5e44d target/rx: TCG translation
303744a hw/registerfields.h: Add 8bit and 16bit register macros
767e9e6 qemu/bitops.h: Add extract8 and extract16
c576bd7 MAINTAINERS: Add RX

=== OUTPUT BEGIN ===
1/22 Checking commit c576bd79d68d (MAINTAINERS: Add RX)
2/22 Checking commit 767e9e6adb78 (qemu/bitops.h: Add extract8 and extract16)
3/22 Checking commit 303744a62af8 (hw/registerfields.h: Add 8bit and 16bit register macros)
Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2490.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) };

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) / 2 };

total: 2 errors, 0 warnings, 56 lines checked

Patch 3/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/22 Checking commit 2e5e44dcfc69 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 3065 lines checked

Patch 4/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/22 Checking commit 936ddc4f1b14 (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

total: 0 errors, 1 warnings, 650 lines checked

Patch 5/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/22 Checking commit b3d7bf4ef6ae (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22: 
new file mode 100644

total: 0 errors, 1 warnings, 659 lines checked

Patch 6/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/22 Checking commit db3bdeb0a4bf (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 1497 lines checked

Patch 7/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/22 Checking commit cc5ad57c2c56 (target/rx: Disassemble rx_index_addr into a string)
9/22 Checking commit e24ee8d89615 (target/rx: Replace operand with prt_ldmi in disassembler)
10/22 Checking commit ced96c73a4f4 (target/rx: Use prt_ldmi for XCHG_mr disassembly)
11/22 Checking commit 7b77f1ab7077 (target/rx: Emit all disassembly in one prt())
12/22 Checking commit 691260ffe7fa (target/rx: Collect all bytes during disassembly)
13/22 Checking commit 66902a40736b (target/rx: Dump bytes for each insn during disassembly)
14/22 Checking commit f2c5f711f5ac (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

total: 0 errors, 1 warnings, 445 lines checked

Patch 14/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/22 Checking commit 3f8b83c03e1d (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 845 lines checked

Patch 15/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/22 Checking commit a7637c5043f1 (hw/char: RX62N serial communication interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

total: 0 errors, 1 warnings, 400 lines checked

Patch 16/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/22 Checking commit ecdf913ebc5b (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#23: 
new file mode 100644

ERROR: trailing whitespace
#128: FILE: hw/rx/rx-virt.c:73:
+    $

ERROR: trailing whitespace
#146: FILE: hw/rx/rx-virt.c:91:
+        /* The kernel image is loaded into $

WARNING: Block comments use a leading /* on a separate line
#146: FILE: hw/rx/rx-virt.c:91:
+        /* The kernel image is loaded into 

WARNING: Block comments use * on subsequent lines
#147: FILE: hw/rx/rx-virt.c:92:
+        /* The kernel image is loaded into 
+           the latter half of the SDRAM space. */

WARNING: Block comments use a trailing */ on a separate line
#147: FILE: hw/rx/rx-virt.c:92:
+           the latter half of the SDRAM space. */

total: 2 errors, 4 warnings, 493 lines checked

Patch 17/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

18/22 Checking commit b62a7e22a70c (hw/rx: Honor -accel qtest)
19/22 Checking commit e3ec88947610 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core)
20/22 Checking commit 92a72077979d (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#69: 
new file mode 100644

total: 0 errors, 1 warnings, 83 lines checked

Patch 20/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/22 Checking commit f0b23edc7d0a (BootLinuxConsoleTest: Test the RX-Virt machine)
22/22 Checking commit 44708958d5b5 (qemu-doc.texi: Add RX section.)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/[e-mail]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [e-mail]

[e-mail] Feb. 12, 2020, 3:08 p.m. UTC | #6

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v30 00/22] Add RX archtecture support
Message-id: [e-mail]
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/[e-mail] -> patchew/[e-mail]
Switched to a new branch 'test'
742aed2 qemu-doc.texi: Add RX section.
f8dc41e BootLinuxConsoleTest: Test the RX-Virt machine
37414e6 Add rx-softmmu
6bad46f hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
b6f9774 hw/rx: Honor -accel qtest
38bc73d hw/rx: RX Target hardware definition
f224df0 hw/char: RX62N serial communication interface (SCI)
ccd39c6 hw/timer: RX62N internal timer modules
3999489 hw/intc: RX62N interrupt controller (ICUa)
aa8d683 target/rx: Dump bytes for each insn during disassembly
8215d23 target/rx: Collect all bytes during disassembly
595382d target/rx: Emit all disassembly in one prt()
c722e15 target/rx: Use prt_ldmi for XCHG_mr disassembly
be31b82 target/rx: Replace operand with prt_ldmi in disassembler
90b054c target/rx: Disassemble rx_index_addr into a string
f2802e4 target/rx: RX disassembler
cb4c947 target/rx: CPU definition
5782455 target/rx: TCG helper
5435b95 target/rx: TCG translation
92c8a93 hw/registerfields.h: Add 8bit and 16bit register macros
ca806d1 qemu/bitops.h: Add extract8 and extract16
5239516 MAINTAINERS: Add RX

=== OUTPUT BEGIN ===
1/22 Checking commit 5239516cc8f1 (MAINTAINERS: Add RX)
2/22 Checking commit ca806d1ba65e (qemu/bitops.h: Add extract8 and extract16)
3/22 Checking commit 92c8a93e24b2 (hw/registerfields.h: Add 8bit and 16bit register macros)
Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2490.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) };

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) / 2 };

total: 2 errors, 0 warnings, 56 lines checked

Patch 3/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/22 Checking commit 5435b951d5f6 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 3065 lines checked

Patch 4/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/22 Checking commit 5782455eda42 (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

total: 0 errors, 1 warnings, 650 lines checked

Patch 5/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/22 Checking commit cb4c94748de8 (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22: 
new file mode 100644

total: 0 errors, 1 warnings, 659 lines checked

Patch 6/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/22 Checking commit f2802e4c7970 (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 1497 lines checked

Patch 7/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/22 Checking commit 90b054c90463 (target/rx: Disassemble rx_index_addr into a string)
9/22 Checking commit be31b8271561 (target/rx: Replace operand with prt_ldmi in disassembler)
10/22 Checking commit c722e1591484 (target/rx: Use prt_ldmi for XCHG_mr disassembly)
11/22 Checking commit 595382d7f38d (target/rx: Emit all disassembly in one prt())
12/22 Checking commit 8215d23159cd (target/rx: Collect all bytes during disassembly)
13/22 Checking commit aa8d68395ec1 (target/rx: Dump bytes for each insn during disassembly)
14/22 Checking commit 399948948c03 (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

total: 0 errors, 1 warnings, 445 lines checked

Patch 14/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/22 Checking commit ccd39c643aa0 (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 845 lines checked

Patch 15/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/22 Checking commit f224df014e23 (hw/char: RX62N serial communication interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

total: 0 errors, 1 warnings, 400 lines checked

Patch 16/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/22 Checking commit 38bc73d05b17 (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#23: 
new file mode 100644

ERROR: trailing whitespace
#128: FILE: hw/rx/rx-virt.c:73:
+    $

ERROR: trailing whitespace
#146: FILE: hw/rx/rx-virt.c:91:
+        /* The kernel image is loaded into $

WARNING: Block comments use a leading /* on a separate line
#146: FILE: hw/rx/rx-virt.c:91:
+        /* The kernel image is loaded into 

WARNING: Block comments use * on subsequent lines
#147: FILE: hw/rx/rx-virt.c:92:
+        /* The kernel image is loaded into 
+           the latter half of the SDRAM space. */

WARNING: Block comments use a trailing */ on a separate line
#147: FILE: hw/rx/rx-virt.c:92:
+           the latter half of the SDRAM space. */

total: 2 errors, 4 warnings, 493 lines checked

Patch 17/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

18/22 Checking commit b6f9774f8996 (hw/rx: Honor -accel qtest)
19/22 Checking commit 6bad46f6bb12 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core)
20/22 Checking commit 37414e62f6b4 (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#69: 
new file mode 100644

total: 0 errors, 1 warnings, 83 lines checked

Patch 20/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/22 Checking commit f8dc41e6173c (BootLinuxConsoleTest: Test the RX-Virt machine)
22/22 Checking commit 742aed21ef10 (qemu-doc.texi: Add RX section.)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/[e-mail]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [e-mail]

[e-mail] Feb. 12, 2020, 3:15 p.m. UTC | #7

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v30 00/22] Add RX archtecture support
Message-id: [e-mail]
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/[e-mail] -> patchew/[e-mail]
Switched to a new branch 'test'
c07b5e4 qemu-doc.texi: Add RX section.
d9e3115 BootLinuxConsoleTest: Test the RX-Virt machine
b1722b2 Add rx-softmmu
f88aff7 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
ce78c96 hw/rx: Honor -accel qtest
8097b53 hw/rx: RX Target hardware definition
dbc2b8b hw/char: RX62N serial communication interface (SCI)
979446e hw/timer: RX62N internal timer modules
5a15247 hw/intc: RX62N interrupt controller (ICUa)
f94a445 target/rx: Dump bytes for each insn during disassembly
ca644b3 target/rx: Collect all bytes during disassembly
9d474c3 target/rx: Emit all disassembly in one prt()
95020f2 target/rx: Use prt_ldmi for XCHG_mr disassembly
5b536a9 target/rx: Replace operand with prt_ldmi in disassembler
7c95e62 target/rx: Disassemble rx_index_addr into a string
196b5bd target/rx: RX disassembler
9312a61 target/rx: CPU definition
4b9939c target/rx: TCG helper
3b8d86a target/rx: TCG translation
84337e2 hw/registerfields.h: Add 8bit and 16bit register macros
203f17b qemu/bitops.h: Add extract8 and extract16
08aca69 MAINTAINERS: Add RX

=== OUTPUT BEGIN ===
1/22 Checking commit 08aca69fecc7 (MAINTAINERS: Add RX)
2/22 Checking commit 203f17b55f7c (qemu/bitops.h: Add extract8 and extract16)
3/22 Checking commit 84337e272083 (hw/registerfields.h: Add 8bit and 16bit register macros)
Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2490.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) };

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) / 2 };

total: 2 errors, 0 warnings, 56 lines checked

Patch 3/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/22 Checking commit 3b8d86a82898 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 3065 lines checked

Patch 4/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/22 Checking commit 4b9939cf24c9 (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

total: 0 errors, 1 warnings, 650 lines checked

Patch 5/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/22 Checking commit 9312a613ec1a (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22: 
new file mode 100644

total: 0 errors, 1 warnings, 659 lines checked

Patch 6/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/22 Checking commit 196b5bd702fc (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 1497 lines checked

Patch 7/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/22 Checking commit 7c95e627ab42 (target/rx: Disassemble rx_index_addr into a string)
9/22 Checking commit 5b536a9efbaa (target/rx: Replace operand with prt_ldmi in disassembler)
10/22 Checking commit 95020f2f8f2a (target/rx: Use prt_ldmi for XCHG_mr disassembly)
11/22 Checking commit 9d474c351686 (target/rx: Emit all disassembly in one prt())
12/22 Checking commit ca644b362f6f (target/rx: Collect all bytes during disassembly)
13/22 Checking commit f94a445e6fb0 (target/rx: Dump bytes for each insn during disassembly)
14/22 Checking commit 5a152470d6b2 (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

total: 0 errors, 1 warnings, 445 lines checked

Patch 14/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/22 Checking commit 979446eb0c51 (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 845 lines checked

Patch 15/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/22 Checking commit dbc2b8bb6f23 (hw/char: RX62N serial communication interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

total: 0 errors, 1 warnings, 400 lines checked

Patch 16/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/22 Checking commit 8097b536c109 (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#23: 
new file mode 100644

ERROR: trailing whitespace
#128: FILE: hw/rx/rx-virt.c:73:
+    $

ERROR: trailing whitespace
#146: FILE: hw/rx/rx-virt.c:91:
+        /* The kernel image is loaded into $

WARNING: Block comments use a leading /* on a separate line
#146: FILE: hw/rx/rx-virt.c:91:
+        /* The kernel image is loaded into 

WARNING: Block comments use * on subsequent lines
#147: FILE: hw/rx/rx-virt.c:92:
+        /* The kernel image is loaded into 
+           the latter half of the SDRAM space. */

WARNING: Block comments use a trailing */ on a separate line
#147: FILE: hw/rx/rx-virt.c:92:
+           the latter half of the SDRAM space. */

total: 2 errors, 4 warnings, 493 lines checked

Patch 17/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

18/22 Checking commit ce78c961bb0b (hw/rx: Honor -accel qtest)
19/22 Checking commit f88aff7a868d (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core)
20/22 Checking commit b1722b2fe634 (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#69: 
new file mode 100644

total: 0 errors, 1 warnings, 83 lines checked

Patch 20/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/22 Checking commit d9e311566e1e (BootLinuxConsoleTest: Test the RX-Virt machine)
22/22 Checking commit c07b5e41a8d4 (qemu-doc.texi: Add RX section.)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/[e-mail]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [e-mail]

[e-mail] Feb. 12, 2020, 3:25 p.m. UTC | #8

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v30 00/22] Add RX archtecture support
Message-id: [e-mail]
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 - [tag update]      patchew/[e-mail] -> patchew/[e-mail]
Switched to a new branch 'test'
96043cc qemu-doc.texi: Add RX section.
b7f311f BootLinuxConsoleTest: Test the RX-Virt machine
d928a96 Add rx-softmmu
46a5463 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
3602010 hw/rx: Honor -accel qtest
0ab77aa hw/rx: RX Target hardware definition
6d8c7a0 hw/char: RX62N serial communication interface (SCI)
b5b1aca hw/timer: RX62N internal timer modules
ad8af53 hw/intc: RX62N interrupt controller (ICUa)
b32635d target/rx: Dump bytes for each insn during disassembly
4363ee1 target/rx: Collect all bytes during disassembly
410e6f4 target/rx: Emit all disassembly in one prt()
ed23672 target/rx: Use prt_ldmi for XCHG_mr disassembly
5701623 target/rx: Replace operand with prt_ldmi in disassembler
fd886bb target/rx: Disassemble rx_index_addr into a string
1560408 target/rx: RX disassembler
0d304ec target/rx: CPU definition
57ca20a target/rx: TCG helper
003ca8c target/rx: TCG translation
79f2eaa hw/registerfields.h: Add 8bit and 16bit register macros
3148170 qemu/bitops.h: Add extract8 and extract16
79b00a8 MAINTAINERS: Add RX

=== OUTPUT BEGIN ===
1/22 Checking commit 79b00a820d7c (MAINTAINERS: Add RX)
2/22 Checking commit 3148170e9de8 (qemu/bitops.h: Add extract8 and extract16)
3/22 Checking commit 79f2eaaec033 (hw/registerfields.h: Add 8bit and 16bit register macros)
Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2490.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) };

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) / 2 };

total: 2 errors, 0 warnings, 56 lines checked

Patch 3/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/22 Checking commit 003ca8c0eb26 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 3065 lines checked

Patch 4/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/22 Checking commit 57ca20a306f9 (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

total: 0 errors, 1 warnings, 650 lines checked

Patch 5/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/22 Checking commit 0d304ec0ddd3 (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22: 
new file mode 100644

total: 0 errors, 1 warnings, 659 lines checked

Patch 6/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/22 Checking commit 15604085897f (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 1497 lines checked

Patch 7/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/22 Checking commit fd886bbd1449 (target/rx: Disassemble rx_index_addr into a string)
9/22 Checking commit 5701623d0c7b (target/rx: Replace operand with prt_ldmi in disassembler)
10/22 Checking commit ed236724afd5 (target/rx: Use prt_ldmi for XCHG_mr disassembly)
11/22 Checking commit 410e6f481e97 (target/rx: Emit all disassembly in one prt())
12/22 Checking commit 4363ee1bdef4 (target/rx: Collect all bytes during disassembly)
13/22 Checking commit b32635d70232 (target/rx: Dump bytes for each insn during disassembly)
14/22 Checking commit ad8af53c7b71 (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

total: 0 errors, 1 warnings, 445 lines checked

Patch 14/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/22 Checking commit b5b1aca6fd0b (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 845 lines checked

Patch 15/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/22 Checking commit 6d8c7a072968 (hw/char: RX62N serial communication interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

total: 0 errors, 1 warnings, 400 lines checked

Patch 16/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/22 Checking commit 0ab77aad73ee (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#23: 
new file mode 100644

ERROR: trailing whitespace
#128: FILE: hw/rx/rx-virt.c:73:
+    $

ERROR: trailing whitespace
#146: FILE: hw/rx/rx-virt.c:91:
+        /* The kernel image is loaded into $

WARNING: Block comments use a leading /* on a separate line
#146: FILE: hw/rx/rx-virt.c:91:
+        /* The kernel image is loaded into 

WARNING: Block comments use * on subsequent lines
#147: FILE: hw/rx/rx-virt.c:92:
+        /* The kernel image is loaded into 
+           the latter half of the SDRAM space. */

WARNING: Block comments use a trailing */ on a separate line
#147: FILE: hw/rx/rx-virt.c:92:
+           the latter half of the SDRAM space. */

total: 2 errors, 4 warnings, 493 lines checked

Patch 17/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

18/22 Checking commit 360201025f02 (hw/rx: Honor -accel qtest)
19/22 Checking commit 46a5463dc037 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core)
20/22 Checking commit d928a9664d5d (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#69: 
new file mode 100644

total: 0 errors, 1 warnings, 83 lines checked

Patch 20/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/22 Checking commit b7f311fc5ce4 (BootLinuxConsoleTest: Test the RX-Virt machine)
22/22 Checking commit 96043cc86d23 (qemu-doc.texi: Add RX section.)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/[e-mail]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [e-mail]

[e-mail] Feb. 12, 2020, 3:52 p.m. UTC | #9

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v30 00/22] Add RX archtecture support
Message-id: [e-mail]
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/[e-mail] -> patchew/[e-mail]
Switched to a new branch 'test'
01f0378 qemu-doc.texi: Add RX section.
756b686 BootLinuxConsoleTest: Test the RX-Virt machine
837ab5e Add rx-softmmu
a54c4a7 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
8f05d87 hw/rx: Honor -accel qtest
17b5d48 hw/rx: RX Target hardware definition
15aaf04 hw/char: RX62N serial communication interface (SCI)
863466a hw/timer: RX62N internal timer modules
8e2ddf8 hw/intc: RX62N interrupt controller (ICUa)
c2b722c target/rx: Dump bytes for each insn during disassembly
abe5c93 target/rx: Collect all bytes during disassembly
2856668 target/rx: Emit all disassembly in one prt()
fbb8022 target/rx: Use prt_ldmi for XCHG_mr disassembly
e02a968 target/rx: Replace operand with prt_ldmi in disassembler
ebe47d5 target/rx: Disassemble rx_index_addr into a string
2123e83 target/rx: RX disassembler
62b81b7 target/rx: CPU definition
d4da3eb target/rx: TCG helper
c6645faa target/rx: TCG translation
97f0ecf hw/registerfields.h: Add 8bit and 16bit register macros
4d682d8 qemu/bitops.h: Add extract8 and extract16
6e4e0c1 MAINTAINERS: Add RX

=== OUTPUT BEGIN ===
1/22 Checking commit 6e4e0c17243b (MAINTAINERS: Add RX)
2/22 Checking commit 4d682d871146 (qemu/bitops.h: Add extract8 and extract16)
3/22 Checking commit 97f0ecffe465 (hw/registerfields.h: Add 8bit and 16bit register macros)
Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2490.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) };

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) / 2 };

total: 2 errors, 0 warnings, 56 lines checked

Patch 3/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/22 Checking commit c6645faa5ab8 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 3065 lines checked

Patch 4/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/22 Checking commit d4da3eb54e32 (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

total: 0 errors, 1 warnings, 650 lines checked

Patch 5/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/22 Checking commit 62b81b7701c5 (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22: 
new file mode 100644

total: 0 errors, 1 warnings, 659 lines checked

Patch 6/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/22 Checking commit 2123e834292a (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 1497 lines checked

Patch 7/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/22 Checking commit ebe47d55bde6 (target/rx: Disassemble rx_index_addr into a string)
9/22 Checking commit e02a9686860e (target/rx: Replace operand with prt_ldmi in disassembler)
10/22 Checking commit fbb8022a3edc (target/rx: Use prt_ldmi for XCHG_mr disassembly)
11/22 Checking commit 2856668a7c4a (target/rx: Emit all disassembly in one prt())
12/22 Checking commit abe5c9380941 (target/rx: Collect all bytes during disassembly)
13/22 Checking commit c2b722c81fe2 (target/rx: Dump bytes for each insn during disassembly)
14/22 Checking commit 8e2ddf8e72aa (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

total: 0 errors, 1 warnings, 445 lines checked

Patch 14/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/22 Checking commit 863466adfcc5 (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 845 lines checked

Patch 15/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/22 Checking commit 15aaf048e883 (hw/char: RX62N serial communication interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

total: 0 errors, 1 warnings, 400 lines checked

Patch 16/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/22 Checking commit 17b5d48e9ee0 (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#23: 
new file mode 100644

ERROR: trailing whitespace
#128: FILE: hw/rx/rx-virt.c:73:
+    $

ERROR: trailing whitespace
#146: FILE: hw/rx/rx-virt.c:91:
+        /* The kernel image is loaded into $

WARNING: Block comments use a leading /* on a separate line
#146: FILE: hw/rx/rx-virt.c:91:
+        /* The kernel image is loaded into 

WARNING: Block comments use * on subsequent lines
#147: FILE: hw/rx/rx-virt.c:92:
+        /* The kernel image is loaded into 
+           the latter half of the SDRAM space. */

WARNING: Block comments use a trailing */ on a separate line
#147: FILE: hw/rx/rx-virt.c:92:
+           the latter half of the SDRAM space. */

total: 2 errors, 4 warnings, 493 lines checked

Patch 17/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

18/22 Checking commit 8f05d879200d (hw/rx: Honor -accel qtest)
19/22 Checking commit a54c4a7c0cde (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core)
20/22 Checking commit 837ab5e2281d (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#69: 
new file mode 100644

total: 0 errors, 1 warnings, 83 lines checked

Patch 20/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/22 Checking commit 756b686baccc (BootLinuxConsoleTest: Test the RX-Virt machine)
22/22 Checking commit 01f0378fbddb (qemu-doc.texi: Add RX section.)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/[e-mail]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [e-mail]

[e-mail] Feb. 12, 2020, 4:03 p.m. UTC | #10

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v30 00/22] Add RX archtecture support
Message-id: [e-mail]
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/[e-mail] -> patchew/[e-mail]
Switched to a new branch 'test'
babc84a qemu-doc.texi: Add RX section.
02671a3 BootLinuxConsoleTest: Test the RX-Virt machine
a7b171f Add rx-softmmu
157d061 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
6dd9e29 hw/rx: Honor -accel qtest
531f2e7 hw/rx: RX Target hardware definition
2f84384 hw/char: RX62N serial communication interface (SCI)
efb672d hw/timer: RX62N internal timer modules
2ecc8e8 hw/intc: RX62N interrupt controller (ICUa)
c48b1e3 target/rx: Dump bytes for each insn during disassembly
cf6bd23 target/rx: Collect all bytes during disassembly
0630f57 target/rx: Emit all disassembly in one prt()
c68232e target/rx: Use prt_ldmi for XCHG_mr disassembly
0c715cf target/rx: Replace operand with prt_ldmi in disassembler
56823e8 target/rx: Disassemble rx_index_addr into a string
bec88c6 target/rx: RX disassembler
e087756 target/rx: CPU definition
76fbf4b target/rx: TCG helper
077b749 target/rx: TCG translation
077083d hw/registerfields.h: Add 8bit and 16bit register macros
0e0b064 qemu/bitops.h: Add extract8 and extract16
e057d0d MAINTAINERS: Add RX

=== OUTPUT BEGIN ===
1/22 Checking commit e057d0d1eaa7 (MAINTAINERS: Add RX)
2/22 Checking commit 0e0b0640e7e8 (qemu/bitops.h: Add extract8 and extract16)
3/22 Checking commit 077083db9152 (hw/registerfields.h: Add 8bit and 16bit register macros)
Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2490.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) };

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) / 2 };

total: 2 errors, 0 warnings, 56 lines checked

Patch 3/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/22 Checking commit 077b74916e86 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 3065 lines checked

Patch 4/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/22 Checking commit 76fbf4b71e73 (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

total: 0 errors, 1 warnings, 650 lines checked

Patch 5/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/22 Checking commit e087756e80bc (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22: 
new file mode 100644

total: 0 errors, 1 warnings, 659 lines checked

Patch 6/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/22 Checking commit bec88c65c6d9 (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 1497 lines checked

Patch 7/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/22 Checking commit 56823e81616e (target/rx: Disassemble rx_index_addr into a string)
9/22 Checking commit 0c715cfcaf50 (target/rx: Replace operand with prt_ldmi in disassembler)
10/22 Checking commit c68232e9cbaa (target/rx: Use prt_ldmi for XCHG_mr disassembly)
11/22 Checking commit 0630f571ce7f (target/rx: Emit all disassembly in one prt())
12/22 Checking commit cf6bd23f5f99 (target/rx: Collect all bytes during disassembly)
13/22 Checking commit c48b1e310d06 (target/rx: Dump bytes for each insn during disassembly)
14/22 Checking commit 2ecc8e8d62d7 (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

total: 0 errors, 1 warnings, 445 lines checked

Patch 14/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/22 Checking commit efb672d6bcee (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 845 lines checked

Patch 15/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/22 Checking commit 2f843848c4d1 (hw/char: RX62N serial communication interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

total: 0 errors, 1 warnings, 400 lines checked

Patch 16/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/22 Checking commit 531f2e7ba4e9 (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#23: 
new file mode 100644

ERROR: trailing whitespace
#128: FILE: hw/rx/rx-virt.c:73:
+    $

ERROR: trailing whitespace
#146: FILE: hw/rx/rx-virt.c:91:
+        /* The kernel image is loaded into $

WARNING: Block comments use a leading /* on a separate line
#146: FILE: hw/rx/rx-virt.c:91:
+        /* The kernel image is loaded into 

WARNING: Block comments use * on subsequent lines
#147: FILE: hw/rx/rx-virt.c:92:
+        /* The kernel image is loaded into 
+           the latter half of the SDRAM space. */

WARNING: Block comments use a trailing */ on a separate line
#147: FILE: hw/rx/rx-virt.c:92:
+           the latter half of the SDRAM space. */

total: 2 errors, 4 warnings, 493 lines checked

Patch 17/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

18/22 Checking commit 6dd9e29294c7 (hw/rx: Honor -accel qtest)
19/22 Checking commit 157d061f696c (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core)
20/22 Checking commit a7b171fcf22b (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#69: 
new file mode 100644

total: 0 errors, 1 warnings, 83 lines checked

Patch 20/22 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/22 Checking commit 02671a3e7d1a (BootLinuxConsoleTest: Test the RX-Virt machine)
22/22 Checking commit babc84a4f27c (qemu-doc.texi: Add RX section.)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/[e-mail]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [e-mail]