| Message ID | 1608747495.7195569.1581513386780.JavaMail.zimbra@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | docs: Fix virtiofsd.1 location | expand |
On Wed, 12 Feb 2020 at 13:16, Miroslav Rezanina <mrezanin@redhat.com> wrote: > > Patch 6a7e2bbee5 docs: add virtiofsd(1) man page introduced new man > page virtiofsd.1. Unfortunately, wrong file location is used as > source for install command. This cause installation of docs fail. > > Fixing wrong location so installation is successful. > > Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com> Reviewed-by: Peter Maydell <peter.maydell@linaro.org> I noticed this in review of v1 of the patch https://patchew.org/QEMU/20200127162514.56784-1-stefanha@redhat.com/ but missed that it hadn't been fixed in v2/v3. thanks -- PMM
* Peter Maydell (peter.maydell@linaro.org) wrote: > On Wed, 12 Feb 2020 at 13:16, Miroslav Rezanina <mrezanin@redhat.com> wrote: > > > > Patch 6a7e2bbee5 docs: add virtiofsd(1) man page introduced new man > > page virtiofsd.1. Unfortunately, wrong file location is used as > > source for install command. This cause installation of docs fail. > > > > Fixing wrong location so installation is successful. > > > > Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com> > > Reviewed-by: Peter Maydell <peter.maydell@linaro.org> > > I noticed this in review of v1 of the patch > https://patchew.org/QEMU/20200127162514.56784-1-stefanha@redhat.com/ > but missed that it hadn't been fixed in v2/v3. Oops thanks! Does someone want to take this via build or trivial - I've not got any more virtiofsd stuff currently queued. Dave > thanks > -- PMM > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
On Wed, Feb 12, 2020 at 02:18:19PM +0000, Peter Maydell wrote: > On Wed, 12 Feb 2020 at 13:16, Miroslav Rezanina <mrezanin@redhat.com> wrote: > > > > Patch 6a7e2bbee5 docs: add virtiofsd(1) man page introduced new man > > page virtiofsd.1. Unfortunately, wrong file location is used as > > source for install command. This cause installation of docs fail. > > > > Fixing wrong location so installation is successful. > > > > Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com> > > Reviewed-by: Peter Maydell <peter.maydell@linaro.org> > > I noticed this in review of v1 of the patch > https://patchew.org/QEMU/20200127162514.56784-1-stefanha@redhat.com/ > but missed that it hadn't been fixed in v2/v3. How come the mistake didn't break any of our CI ? Looks like it should have failed due to non-existing source file Regards, Daniel
On Wed, 12 Feb 2020 at 14:28, Daniel P. Berrangé <berrange@redhat.com> wrote: > > On Wed, Feb 12, 2020 at 02:18:19PM +0000, Peter Maydell wrote: > > On Wed, 12 Feb 2020 at 13:16, Miroslav Rezanina <mrezanin@redhat.com> wrote: > > > > > > Patch 6a7e2bbee5 docs: add virtiofsd(1) man page introduced new man > > > page virtiofsd.1. Unfortunately, wrong file location is used as > > > source for install command. This cause installation of docs fail. > > > > > > Fixing wrong location so installation is successful. > > > > > > Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com> > > > > Reviewed-by: Peter Maydell <peter.maydell@linaro.org> > > > > I noticed this in review of v1 of the patch > > https://patchew.org/QEMU/20200127162514.56784-1-stefanha@redhat.com/ > > but missed that it hadn't been fixed in v2/v3. > > How come the mistake didn't break any of our CI ? Looks like it > should have failed due to non-existing source file I imagine all our CI setups use separate-build-dir and don't test 'make install'. This only shows up if you do build-in-source-tree and then 'make install'. (In a separate-build-dir setup, the MANUAL_BUILDDIR is the same as the actual build dir, which is the same as make's current working directory, so forgetting it in the install rune doesn't matter. In a build from the source tree, Sphinx requires the output to be to a different directory than the source, so we have to create a subdirectory to be the MANUAL_BUILDDIR.) thanks -- PMM
On 2/12/20 5:02 PM, Peter Maydell wrote: > On Wed, 12 Feb 2020 at 14:28, Daniel P. Berrangé <berrange@redhat.com> wrote: >> >> On Wed, Feb 12, 2020 at 02:18:19PM +0000, Peter Maydell wrote: >>> On Wed, 12 Feb 2020 at 13:16, Miroslav Rezanina <mrezanin@redhat.com> wrote: >>>> >>>> Patch 6a7e2bbee5 docs: add virtiofsd(1) man page introduced new man >>>> page virtiofsd.1. Unfortunately, wrong file location is used as >>>> source for install command. This cause installation of docs fail. >>>> >>>> Fixing wrong location so installation is successful. >>>> >>>> Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com> >>> >>> Reviewed-by: Peter Maydell <peter.maydell@linaro.org> >>> >>> I noticed this in review of v1 of the patch >>> https://patchew.org/QEMU/20200127162514.56784-1-stefanha@redhat.com/ >>> but missed that it hadn't been fixed in v2/v3. >> >> How come the mistake didn't break any of our CI ? Looks like it >> should have failed due to non-existing source file We stopped testing in-tree builds 2 months ago: commit bc4486fb233573e77b6e9ad6d6379afb5e37ad8c Author: Paolo Bonzini <pbonzini@redhat.com> Date: Wed Dec 11 15:33:49 2019 +0100 ci: build out-of-tree Most developers are using out-of-tree builds and it was discussed in the past to only allow those. To prepare for the transition, use out-of-tree builds in all continuous integration jobs. > > I imagine all our CI setups use separate-build-dir and don't > test 'make install'. This only shows up if you do build-in-source-tree > and then 'make install'. (In a separate-build-dir setup, the > MANUAL_BUILDDIR is the same as the actual build dir, > which is the same as make's current working directory, so > forgetting it in the install rune doesn't matter. In a build from > the source tree, Sphinx requires the output to be to a > different directory than the source, so we have to create > a subdirectory to be the MANUAL_BUILDDIR.) > > thanks > -- PMM >
On Wed, 12 Feb 2020 at 16:51, Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > We stopped testing in-tree builds 2 months ago: > > commit bc4486fb233573e77b6e9ad6d6379afb5e37ad8c > Author: Paolo Bonzini <pbonzini@redhat.com> > Date: Wed Dec 11 15:33:49 2019 +0100 > > ci: build out-of-tree > > Most developers are using out-of-tree builds and it was discussed > in the past > to only allow those. To prepare for the transition, use > out-of-tree builds > in all continuous integration jobs. I'd missed that. Paolo, do you have a plan for following through and actively forbidding in-tree-builds, if that's the route we're taking ? thanks -- PMM
On 12/02/20 18:51, Peter Maydell wrote: > On Wed, 12 Feb 2020 at 16:51, Philippe Mathieu-Daudé <philmd@redhat.com> wrote: >> We stopped testing in-tree builds 2 months ago: >> >> commit bc4486fb233573e77b6e9ad6d6379afb5e37ad8c >> Author: Paolo Bonzini <pbonzini@redhat.com> >> Date: Wed Dec 11 15:33:49 2019 +0100 >> >> ci: build out-of-tree >> >> Most developers are using out-of-tree builds and it was discussed >> in the past to only allow those. To prepare for the transition, >> use out-of-tree builds in all continuous integration jobs. > > I'd missed that. Paolo, do you have a plan for following > through and actively forbidding in-tree-builds, if that's > the route we're taking ? I can follow up on that, yes. Paolo
diff --git a/Makefile b/Makefile index f0e1a2f..62a367d 100644 --- a/Makefile +++ b/Makefile @@ -865,7 +865,7 @@ ifdef CONFIG_VIRTFS $(INSTALL_DATA) $(MANUAL_BUILDDIR)/interop/virtfs-proxy-helper.1 "$(DESTDIR)$(mandir)/man1" endif ifeq ($(CONFIG_LINUX)$(CONFIG_SECCOMP)$(CONFIG_LIBCAP_NG),yyy) - $(INSTALL_DATA) docs/interop/virtiofsd.1 "$(DESTDIR)$(mandir)/man1" + $(INSTALL_DATA) $(MANUAL_BUILDDIR)/interop/virtiofsd.1 "$(DESTDIR)$(mandir)/man1" endif install-datadir:
Patch 6a7e2bbee5 docs: add virtiofsd(1) man page introduced new man page virtiofsd.1. Unfortunately, wrong file location is used as source for install command. This cause installation of docs fail. Fixing wrong location so installation is successful. Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)