| Message ID | 20200212224732.736785-1-niklas.soderlund+renesas@ragnatech.se (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Daniel Lezcano |
| Headers | show |
| Series | thermal: rcar_gen3_thermal: Remove unneeded curly brackets | expand |
Hi Niklas-san, > From: Niklas Soderlund, Sent: Thursday, February 13, 2020 7:48 AM > > When devm_add_action() was turned into devm_add_action_or_reset() the > curly brackets for the error case where kept but are not needed, remove > them to match the style of the driver. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Thank you for the patch! Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Best regards, Yoshihiro Shimoda
On Wed, Feb 12, 2020 at 11:48 PM Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> wrote: > When devm_add_action() was turned into devm_add_action_or_reset() the > curly brackets for the error case where kept but are not needed, remove > them to match the style of the driver. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_gen3_thermal.c index 55d1736f532cdb33..a2bf9d8074cc4fcf 100644 --- a/drivers/thermal/rcar_gen3_thermal.c +++ b/drivers/thermal/rcar_gen3_thermal.c @@ -444,9 +444,8 @@ static int rcar_gen3_thermal_probe(struct platform_device *pdev) goto error_unregister; ret = devm_add_action_or_reset(dev, rcar_gen3_hwmon_action, zone); - if (ret) { + if (ret) goto error_unregister; - } ret = of_thermal_get_ntrips(tsc->zone); if (ret < 0)
When devm_add_action() was turned into devm_add_action_or_reset() the curly brackets for the error case where kept but are not needed, remove them to match the style of the driver. Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> --- drivers/thermal/rcar_gen3_thermal.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)