| Message ID | 20200214065309.27564-1-kai.heng.feng@canonical.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | be0aba826c4a6ba5929def1962a90d6127871969 |
| Delegated to: | Benjamin Tissoires |
| Headers | show |
| Series | HID: i2c-hid: add Trekstor Surfbook E11B to descriptor override | expand |
Hi, On 2/14/20 7:53 AM, Kai-Heng Feng wrote: > The Surfbook E11B uses the SIPODEV SP1064 touchpad, which does not supply > descriptors, so it has to be added to the override list. > > BugLink: https://bugs.launchpad.net/bugs/1858299 > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> Patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c b/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c > index d31ea82b84c1..a66f08041a1a 100644 > --- a/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c > +++ b/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c > @@ -341,6 +341,14 @@ static const struct dmi_system_id i2c_hid_dmi_desc_override_table[] = { > }, > .driver_data = (void *)&sipodev_desc > }, > + { > + .ident = "Trekstor SURFBOOK E11B", > + .matches = { > + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "TREKSTOR"), > + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "SURFBOOK E11B"), > + }, > + .driver_data = (void *)&sipodev_desc > + }, > { > .ident = "Direkt-Tek DTLAPY116-2", > .matches = { >
Hi, On Fri, Feb 14, 2020 at 9:32 AM Hans de Goede <hdegoede@redhat.com> wrote: > > Hi, > > On 2/14/20 7:53 AM, Kai-Heng Feng wrote: > > The Surfbook E11B uses the SIPODEV SP1064 touchpad, which does not supply > > descriptors, so it has to be added to the override list. > > > > BugLink: https://bugs.launchpad.net/bugs/1858299 > > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> > > Patch looks good to me: > > Reviewed-by: Hans de Goede <hdegoede@redhat.com> Thanks everybody for the patch submission and the quick review. Patch is now queued in for-5.6/upstream-fixes Cheers, Benjamin > > Regards, > > Hans > > > > > --- > > drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c b/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c > > index d31ea82b84c1..a66f08041a1a 100644 > > --- a/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c > > +++ b/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c > > @@ -341,6 +341,14 @@ static const struct dmi_system_id i2c_hid_dmi_desc_override_table[] = { > > }, > > .driver_data = (void *)&sipodev_desc > > }, > > + { > > + .ident = "Trekstor SURFBOOK E11B", > > + .matches = { > > + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "TREKSTOR"), > > + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "SURFBOOK E11B"), > > + }, > > + .driver_data = (void *)&sipodev_desc > > + }, > > { > > .ident = "Direkt-Tek DTLAPY116-2", > > .matches = { > > >
diff --git a/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c b/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c index d31ea82b84c1..a66f08041a1a 100644 --- a/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c +++ b/drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c @@ -341,6 +341,14 @@ static const struct dmi_system_id i2c_hid_dmi_desc_override_table[] = { }, .driver_data = (void *)&sipodev_desc }, + { + .ident = "Trekstor SURFBOOK E11B", + .matches = { + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "TREKSTOR"), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "SURFBOOK E11B"), + }, + .driver_data = (void *)&sipodev_desc + }, { .ident = "Direkt-Tek DTLAPY116-2", .matches = {
The Surfbook E11B uses the SIPODEV SP1064 touchpad, which does not supply descriptors, so it has to be added to the override list. BugLink: https://bugs.launchpad.net/bugs/1858299 Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> --- drivers/hid/i2c-hid/i2c-hid-dmi-quirks.c | 8 ++++++++ 1 file changed, 8 insertions(+)