[v4,0/3] IMA: improve log messages

Message

Tushar Sugandhi Feb. 15, 2020, 1:47 a.m. UTC

The log messages from IMA subsystem should be consistent for better
diagnosability and discoverability.

This patch set improves the logging by removing duplicate log formatting
macros, adding a consistent prefix to the log messages, and adding new 
log messages where necessary.

Tushar Sugandhi (3):
  add log prefix
  add log message to process_buffer_measurement failure conditions
  add module name prefix to log statements

 security/integrity/digsig.c                  | 2 --
 security/integrity/digsig_asymmetric.c       | 2 --
 security/integrity/evm/evm_crypto.c          | 2 --
 security/integrity/evm/evm_main.c            | 2 --
 security/integrity/evm/evm_secfs.c           | 2 --
 security/integrity/ima/Makefile              | 6 +++---
 security/integrity/ima/ima_asymmetric_keys.c | 2 --
 security/integrity/ima/ima_crypto.c          | 2 --
 security/integrity/ima/ima_fs.c              | 2 --
 security/integrity/ima/ima_init.c            | 2 --
 security/integrity/ima/ima_kexec.c           | 1 -
 security/integrity/ima/ima_main.c            | 5 +++--
 security/integrity/ima/ima_policy.c          | 2 --
 security/integrity/ima/ima_queue.c           | 2 --
 security/integrity/ima/ima_queue_keys.c      | 2 --
 security/integrity/ima/ima_template.c        | 2 --
 security/integrity/ima/ima_template_lib.c    | 2 --
 security/integrity/integrity.h               | 6 ++++++
 18 files changed, 12 insertions(+), 34 deletions(-)

Comments

Mimi Zohar Feb. 16, 2020, 12:40 p.m. UTC | #1

On Fri, 2020-02-14 at 17:47 -0800, Tushar Sugandhi wrote:
> The log messages from IMA subsystem should be consistent for better
> diagnosability and discoverability.

The change isn't limited to IMA.  I would change "IMA" to "integrity"
in the Subject line and in this patch description.

> This patch set improves the logging by removing duplicate log formatting
> macros, adding a consistent prefix to the log messages, and adding new 
> log messages where necessary.

Much better!

thanks,

Mimi

Tushar Sugandhi Feb. 18, 2020, 7:15 p.m. UTC | #2

On 2020-02-16 4:40 a.m., Mimi Zohar wrote:
> On Fri, 2020-02-14 at 17:47 -0800, Tushar Sugandhi wrote:
>> The log messages from IMA subsystem should be consistent for better
>> diagnosability and discoverability.
> 
> The change isn't limited to IMA.  I would change "IMA" to "integrity"
> in the Subject line and in this patch description.
> 
Will do.
>> This patch set improves the logging by removing duplicate log formatting
>> macros, adding a consistent prefix to the log messages, and adding new
>> log messages where necessary.
> 
> Much better!
> 
> thanks,
> 
> Mimi
>