| Message ID | 20200217064250.15516-6-samuel@sholland.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | sun8i-codec fixes and new features | expand |
On Mon, Feb 17, 2020 at 2:43 PM Samuel Holland <samuel@sholland.org> wrote: > > DSP_A and DSP_B are not interchangeable. The timing used by the codec in > DSP mode is consistent with DSP_A. This is verified with an EG25-G modem > connected to AIF2, as well as by comparing with the BSP driver. > > Remove the DSP_B option, as it is not supported by the hardware. > > Cc: stable@kernel.org > Fixes: 36c684936fae ("ASoC: Add sun8i digital audio codec") > Signed-off-by: Samuel Holland <samuel@sholland.org> Acked-by: Chen-Yu Tsai <wens@csie.org>
On Mon, Feb 17, 2020 at 12:42:21AM -0600, Samuel Holland wrote: > DSP_A and DSP_B are not interchangeable. The timing used by the codec in > DSP mode is consistent with DSP_A. This is verified with an EG25-G modem > connected to AIF2, as well as by comparing with the BSP driver. > > Remove the DSP_B option, as it is not supported by the hardware. > > Cc: stable@kernel.org > Fixes: 36c684936fae ("ASoC: Add sun8i digital audio codec") This can only break things for existing systems using stable, if they haven't noticed a problem with DSP B they'll certainly notice failing to set up the DAI at all without it.
On 2/17/20 9:02 AM, Mark Brown wrote: > On Mon, Feb 17, 2020 at 12:42:21AM -0600, Samuel Holland wrote: >> DSP_A and DSP_B are not interchangeable. The timing used by the codec in >> DSP mode is consistent with DSP_A. This is verified with an EG25-G modem >> connected to AIF2, as well as by comparing with the BSP driver. >> >> Remove the DSP_B option, as it is not supported by the hardware. >> >> Cc: stable@kernel.org >> Fixes: 36c684936fae ("ASoC: Add sun8i digital audio codec") > > This can only break things for existing systems using stable, if they > haven't noticed a problem with DSP B they'll certainly notice failing to > set up the DAI at all without it. Are you suggesting that I drop this patch entirely, or only that I remove the CC to stable (and/or Fixes: tag)? Is this something that can't be removed once it's there, or is the concern about making user-visible changes on stable? Thanks, Samuel
On Mon, Feb 17, 2020 at 07:35:08PM -0600, Samuel Holland wrote: > On 2/17/20 9:02 AM, Mark Brown wrote: > > On Mon, Feb 17, 2020 at 12:42:21AM -0600, Samuel Holland wrote: > >> DSP_A and DSP_B are not interchangeable. The timing used by the codec in > >> DSP mode is consistent with DSP_A. This is verified with an EG25-G modem > >> connected to AIF2, as well as by comparing with the BSP driver. > > This can only break things for existing systems using stable, if they > > haven't noticed a problem with DSP B they'll certainly notice failing to > > set up the DAI at all without it. > Are you suggesting that I drop this patch entirely, or only that I remove the CC > to stable (and/or Fixes: tag)? Is this something that can't be removed once it's > there, or is the concern about making user-visible changes on stable? Remove the stable tag, if someone is relying on the DSP B support in stable this will break it.
diff --git a/sound/soc/sunxi/sun8i-codec.c b/sound/soc/sunxi/sun8i-codec.c index 33ffbc2be47c..32b7410540c6 100644 --- a/sound/soc/sunxi/sun8i-codec.c +++ b/sound/soc/sunxi/sun8i-codec.c @@ -236,7 +236,6 @@ static int sun8i_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) value = 0x2; break; case SND_SOC_DAIFMT_DSP_A: - case SND_SOC_DAIFMT_DSP_B: value = 0x3; break; default:
DSP_A and DSP_B are not interchangeable. The timing used by the codec in DSP mode is consistent with DSP_A. This is verified with an EG25-G modem connected to AIF2, as well as by comparing with the BSP driver. Remove the DSP_B option, as it is not supported by the hardware. Cc: stable@kernel.org Fixes: 36c684936fae ("ASoC: Add sun8i digital audio codec") Signed-off-by: Samuel Holland <samuel@sholland.org> --- sound/soc/sunxi/sun8i-codec.c | 1 - 1 file changed, 1 deletion(-)