| Message ID | 20200217064250.15516-5-samuel@sholland.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 150cbf8e66ec86966c13fd7a0e3de8813bca03d8 |
| Headers | show |
| Series | sun8i-codec fixes and new features | expand |
On Mon, Feb 17, 2020 at 2:42 PM Samuel Holland <samuel@sholland.org> wrote: > > This field is not used anywhere in the driver, so remove it. > > Fixes: 36c684936fae ("ASoC: Add sun8i digital audio codec") > Signed-off-by: Samuel Holland <samuel@sholland.org> Acked-by: Chen-Yu Tsai <wens@csie.org>
On Mon, Feb 17, 2020 at 12:42:20AM -0600, Samuel Holland wrote: > This field is not used anywhere in the driver, so remove it. > Fixes: 36c684936fae ("ASoC: Add sun8i digital audio codec") This is in no way a bug fix, it's a random cleanup. This means that the Fixes tag isn't really appropriate and it should be done after the subsequent changes in the series that fix real bugs. You should always put bug fixes first so that they don't have any unneeded depenencies on other things and can be merged without them.
diff --git a/sound/soc/sunxi/sun8i-codec.c b/sound/soc/sunxi/sun8i-codec.c index 14cf31f5c535..33ffbc2be47c 100644 --- a/sound/soc/sunxi/sun8i-codec.c +++ b/sound/soc/sunxi/sun8i-codec.c @@ -86,7 +86,6 @@ #define SUN8I_AIF1CLK_CTRL_AIF1_BCLK_DIV_MASK GENMASK(12, 9) struct sun8i_codec { - struct device *dev; struct regmap *regmap; struct clk *clk_module; struct clk *clk_bus; @@ -544,8 +543,6 @@ static int sun8i_codec_probe(struct platform_device *pdev) if (!scodec) return -ENOMEM; - scodec->dev = &pdev->dev; - scodec->clk_module = devm_clk_get(&pdev->dev, "mod"); if (IS_ERR(scodec->clk_module)) { dev_err(&pdev->dev, "Failed to get the module clock\n");
This field is not used anywhere in the driver, so remove it. Fixes: 36c684936fae ("ASoC: Add sun8i digital audio codec") Signed-off-by: Samuel Holland <samuel@sholland.org> --- sound/soc/sunxi/sun8i-codec.c | 3 --- 1 file changed, 3 deletions(-)